Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to Update Outdated v1.7.2 Release Tag to Reflect Latest Commit on Master Branch #2325

Open
L0L1P0P1 opened this issue Mar 15, 2025 · 5 comments

Comments

@L0L1P0P1
Copy link

L0L1P0P1 commented Mar 15, 2025

Hi, I recently attempted to package 3b1b/manim for nixpkgs and noticed that the source code fetched using the release tag v1.7.2 is outdated. Specifically, the output of manimgl -v shows ManimGL v1.7.1, which indicates that the tag does not point to the most recent commit on the master branch.

It would be greatly appreciated if the commit for the v1.7.2 release tag could be updated to reflect the latest commit on the master branch. This would ensure consistency and accuracy for users and packagers relying on the release tags.

@L0L1P0P1 L0L1P0P1 changed the title tarball from tag v1.7.2 releases is outdated (v1.7.1) Request to Update Outdated v1.7.2 Release Tag to Reflect Latest Commit on Master Branch Mar 15, 2025
@osbm
Copy link

osbm commented Mar 15, 2025

It would be greatly appreciated if the commit for the v1.7.2 release tag could be updated to reflect the latest commit on the master branch. This would ensure consistency and accuracy for users and packagers relying on the release tags.

I think master branch being in front of the tags are ok but the main problem is as you said in NixOS/nixpkgs#389779 (comment) git tag version and the version inside the setup.cfg does not match.

git tag version setup.cfg version
v1.7.2 v.1.7.1
v1.7.1 v.1.7.0
v1.7.0 v.1.6.1
v1.6.1 v.1.6.1 (correct)
v1.6.0 v.1.6.0 (correct)

I think just updating the version in setup.cfg before tagging the commit would solve this problem.

@L0L1P0P1
Copy link
Author

I understand your statement but I said that because the latest commit on the master branch changed version to 1.7.2 in setup.cfg

@osbm
Copy link

osbm commented Mar 15, 2025

The latest commit is this: db421e3
The setup.cfg version update commit (0c69ab6) is 6 commit behind.

@L0L1P0P1
Copy link
Author

L0L1P0P1 commented Mar 15, 2025

Oh you are right. My bad.

@osbm
Copy link

osbm commented Mar 15, 2025

No problem, these version mismatches are still an issue tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants