Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-TICKET] chore: Update Ingress values #167

Open
xlejakx opened this issue Mar 17, 2025 · 1 comment
Open

[NO-TICKET] chore: Update Ingress values #167

xlejakx opened this issue Mar 17, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@xlejakx
Copy link

xlejakx commented Mar 17, 2025

Hey
Can't open PR for minor changes.

tls:
  - hosts:
      - workflow.example.com
    secretName: host-domain-cert

In the original configuration, the tls section was explicitly defined with a specific host (workflow.example.com) and a secret name (host-domain-cert). This meant that the Ingress resource would always include this TLS configuration unless it was manually overridden or commented out. However, this approach had a downside: if a custom certificate was being used (e.g., managed externally), or if TLS wasn’t needed, there was no clear way to disable it without modifying the template or values file. Additionally, this setup could unintentionally trigger tools like cert-manager to generate certificates for the listed hosts, even if that wasn’t desired.

tls: []
  # - hosts:
  #     - workflow.example.com
  #   secretName: host-domain-cert

In the updated configuration, the tls section is set to an empty list ([]) by default, with the previous configuration commented out as an example or reference. This change ensures that, by default, no TLS configuration is applied unless explicitly overridden in the values.yaml file or via Helm command-line arguments (e.g., --set).

@Vad1mo
Copy link
Member

Vad1mo commented Mar 17, 2025

ahh I see, this was a copy and paste error, I'll fix that. thank your for the rerpot

@Vad1mo Vad1mo added the bug Something isn't working label Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants