Skip to content

Commit 22673aa

Browse files
Revert "revert oss_fuzz_corpus typo fix (google#1997)" (google#1999)
This reverts commit aec0123.
1 parent aec0123 commit 22673aa

File tree

5 files changed

+0
-621
lines changed

5 files changed

+0
-621
lines changed

docs/internal-documentation/service.md

-50
This file was deleted.

presubmit.py

-30
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,10 @@
3131
import sys
3232
from typing import List, Optional
3333

34-
import yaml
35-
3634
from common import benchmark_utils
3735
from common import fuzzer_utils
3836
from common import filesystem
3937
from common import logs
40-
from common import yaml_utils
41-
from service import automatic_run_experiment
4238
from src_analysis import change_utils
4339
from src_analysis import diff_utils
4440

@@ -258,31 +254,6 @@ def yapf(paths: List[Path], validate: bool = True) -> bool:
258254
return success
259255

260256

261-
def validate_experiment_requests(paths: List[Path]):
262-
"""Returns False if service/experiment-requests.yaml it is in |paths| and is
263-
not valid."""
264-
if Path(automatic_run_experiment.REQUESTED_EXPERIMENTS_PATH) not in paths:
265-
return True
266-
267-
try:
268-
experiment_requests = yaml_utils.read(
269-
automatic_run_experiment.REQUESTED_EXPERIMENTS_PATH)
270-
except yaml.parser.ParserError:
271-
print('Error parsing '
272-
f'{automatic_run_experiment.REQUESTED_EXPERIMENTS_PATH}.')
273-
return False
274-
275-
# Only validate the latest request.
276-
result = automatic_run_experiment.validate_experiment_requests(
277-
experiment_requests[:1])
278-
279-
if not result:
280-
print(f'{automatic_run_experiment.REQUESTED_EXPERIMENTS_PATH}'
281-
'is not valid.')
282-
283-
return result
284-
285-
286257
def is_path_ignored(path: Path) -> bool:
287258
"""Returns True if |path| is a subpath of an ignored directory or is a
288259
third_party directory."""
@@ -441,7 +412,6 @@ def main() -> int:
441412
('typecheck', pytype),
442413
('test', pytest),
443414
('validate_fuzzers_and_benchmarks', validate_fuzzers_and_benchmarks),
444-
('validate_experiment_requests', validate_experiment_requests),
445415
('test_changed_integrations', test_changed_integrations),
446416
]
447417

0 commit comments

Comments
 (0)