Skip to content

Commit 42114d9

Browse files
Merge pull request shipwright-io#1645 from SaschaSchwarze0/sascha-fix-e2e
Pin to newer Node version that is still supported by Paketo
2 parents 28d8b8b + 3575e2a commit 42114d9

File tree

4 files changed

+18
-0
lines changed

4 files changed

+18
-0
lines changed

test/e2e/v1alpha1/common_suite_test.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,14 @@ func (b *buildPrototype) Dockerfile(dockerfile string) *buildPrototype {
110110
return b
111111
}
112112

113+
func (b *buildPrototype) Env(key string, value string) *buildPrototype {
114+
b.build.Spec.Env = append(b.build.Spec.Env, core.EnvVar{
115+
Name: key,
116+
Value: value,
117+
})
118+
return b
119+
}
120+
113121
func (b *buildPrototype) determineParameterIndex(name string) int {
114122
index := -1
115123
for i, paramValue := range b.build.Spec.ParamValues {

test/e2e/v1alpha1/e2e_image_mutate_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,7 @@ var _ = Describe("For a Kubernetes cluster with Tekton and build installed", fun
181181
OutputImageCredentials(os.Getenv(EnvVarImageRepoSecret)).
182182
OutputImageInsecure(insecure).
183183
OutputTimestamp(outputTimestamp).
184+
Env("BP_NODE_VERSION", "~20").
184185
BuildSpec()).
185186
MustCreate()
186187
}

test/e2e/v1beta1/common_suite_test.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,14 @@ func (b *buildPrototype) OutputImage(image string) *buildPrototype {
154154
return b
155155
}
156156

157+
func (b *buildPrototype) Env(key string, value string) *buildPrototype {
158+
b.build.Spec.Env = append(b.build.Spec.Env, core.EnvVar{
159+
Name: key,
160+
Value: value,
161+
})
162+
return b
163+
}
164+
157165
func (b *buildPrototype) OutputVulnerabilitySettings(settings buildv1beta1.VulnerabilityScanOptions) *buildPrototype {
158166
b.build.Spec.Output.VulnerabilityScan = &settings
159167
return b

test/e2e/v1beta1/e2e_image_mutate_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,7 @@ var _ = Describe("For a Kubernetes cluster with Tekton and build installed", fun
181181
OutputImageCredentials(os.Getenv(EnvVarImageRepoSecret)).
182182
OutputImageInsecure(insecure).
183183
OutputTimestamp(outputTimestamp).
184+
Env("BP_NODE_VERSION", "~20").
184185
BuildSpec()).
185186
MustCreate()
186187
}

0 commit comments

Comments
 (0)