Skip to content

Commit c3a0a5c

Browse files
committed
docs: fix broken links, tables and typos
- fixes typos and grammatical mistakes - reformatted tables - fix broken refrences to old files and links Signed-off-by: Avinal Kumar <[email protected]>
1 parent 60fa094 commit c3a0a5c

11 files changed

+162
-162
lines changed

DEVELOPMENT.md

+20-20
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,16 @@ Documentation inspired from https://github.com/tektoncd/pipeline/blob/ce7591acec
1111

1212
## Getting started
1313

14-
1. [Ramp up on kubernetes and CRDs](#ramp-up)
15-
1. Create [a GitHub account](https://github.com/join)
16-
1. Setup
14+
1. [Ramp up on kubernetes and CRDs](#ramp-up)
15+
2. Create [a GitHub account](https://github.com/join)
16+
3. Setup
1717
[GitHub access via SSH](https://help.github.com/articles/connecting-to-github-with-ssh/)
18-
1. [Create and checkout a repo fork](#checkout-your-fork)
19-
1. Install [requirements](#requirements)
20-
1. [Set up a Kubernetes cluster](#create-a-cluster-and-a-repo)
21-
1. Set up your [shell environment](#environment-setup)
22-
1. [Configure kubectl to use your cluster](https://kubernetes.io/docs/tasks/access-application-cluster/configure-access-multiple-clusters/)
23-
1. [Install Shipwright Build in your cluster](#install-shipwright-build)
18+
4. [Create and checkout a repo fork](#checkout-your-fork)
19+
5. Install [requirements](#requirements)
20+
6. [Set up a Kubernetes cluster](#create-a-cluster-and-a-repo)
21+
7. Set up your [shell environment](#environment-setup)
22+
8. [Configure kubectl to use your cluster](https://kubernetes.io/docs/tasks/access-application-cluster/configure-access-multiple-clusters/)
23+
9. [Install Shipwright Build in your cluster](#install-shipwright-build)
2424

2525
### Ramp up
2626

@@ -58,9 +58,9 @@ The Go tools require that you clone the repository to the
5858

5959
To check out this repository:
6060

61-
1. Create your own
61+
1. Create your own
6262
[fork of this repo](https://help.github.com/articles/fork-a-repo/)
63-
1. Clone it to your machine:
63+
2. Clone it to your machine:
6464

6565
```shell
6666
mkdir -p ${GOPATH}/src/github.com/shipwright-io
@@ -78,27 +78,27 @@ _Adding the `upstream` remote sets you up nicely for regularly
7878

7979
You must install these tools:
8080

81-
1. [`go`](https://golang.org/doc/install): The language Shipwright Build is
81+
1. [`go`](https://golang.org/doc/install): The language Shipwright Build is
8282
built in
83-
1. [`git`](https://help.github.com/articles/set-up-git/): For source control
84-
1 [`ko`](https://github.com/ko-build/ko): To build and deploy changes.
85-
1. [`kubectl`](https://kubernetes.io/docs/tasks/tools/install-kubectl/): For
83+
2. [`git`](https://help.github.com/articles/set-up-git/): For source control
84+
3. [`ko`](https://github.com/ko-build/ko): To build and deploy changes.
85+
4. [`kubectl`](https://kubernetes.io/docs/tasks/tools/install-kubectl/): For
8686
interacting with your kube cluster
8787

8888
### Create a cluster and a repo
8989

9090
1. Follow the instructions in the Kubernetes doc to [Set up a kubernetes cluster](https://kubernetes.io/docs/setup/)
91-
1. Set up a container image repository for pushing images. Any container image registry that is accessible to your cluster can be used for your repository. This can be a public registry like [Docker Hub](https://docs.docker.com/docker-hub/), [quay.io](https://quay.io), or a container registry runs by your cloud provider
91+
2. Set up a container image repository for pushing images. Any container image registry that is accessible to your cluster can be used for your repository. This can be a public registry like [Docker Hub](https://docs.docker.com/docker-hub/), [quay.io](https://quay.io), or a container registry runs by your cloud provider
9292

9393
**Note**: We support Kubernetes version 1.27 to 1.29. 1 cluster worker node for basic usage, 2+ cluster worker nodes for HA
9494

9595
## Environment Setup
9696

9797
To run your controller, you'll need to set these environment variables (we recommend adding them to your `.bashrc`):
9898

99-
1. `GOPATH`: If you don't have one, simply pick a directory and add `export
99+
1. `GOPATH`: If you don't have one, simply pick a directory and add `export
100100
GOPATH=...`
101-
1. `$GOPATH/bin` on `PATH`: This is so that tooling installed via `go get` will
101+
2. `$GOPATH/bin` on `PATH`: This is so that tooling installed via `go get` will
102102
work properly.
103103

104104
`.bashrc` example:
@@ -126,11 +126,11 @@ The following set of steps highlight how to deploy a Build controller pod into a
126126
./hack/install-tekton.sh
127127
```
128128

129-
1. Set your `KO_DOCKER_REPO` environment variable. This will be the container
129+
2. Set your `KO_DOCKER_REPO` environment variable. This will be the container
130130
image registry you push to, or `kind.local` if you're using
131131
[KinD](https://kind.sigs.k8s.io).
132132
133-
1. Build and deploy the controller from source, from within the root of the repo:
133+
3. Build and deploy the controller from source, from within the root of the repo:
134134
135135
```sh
136136
ko apply -P -R -f deploy/

README.md

+18-18
Original file line numberDiff line numberDiff line change
@@ -166,28 +166,28 @@ To find out more on what's the best strategy or what else can Shipwright do for
166166
167167
### Read the Docs
168168
169-
| Version | Docs | Examples |
170-
| ------- | ------------------------------ | --------------------------- |
171-
| HEAD | [Docs @ HEAD](docs/README.md) | [Examples @ HEAD](samples) |
172-
| [v0.12.0](https://github.com/shipwright-io/build/releases/tag/v0.12.0) | [Docs @ v0.12.0](https://github.com/shipwright-io/build/tree/v0.12.0/docs) | [Examples @ v0.12.0](https://github.com/shipwright-io/build/tree/v0.12.0/samples) |
173-
| [v0.11.0](https://github.com/shipwright-io/build/releases/tag/v0.11.0) | [Docs @ v0.11.0](https://github.com/shipwright-io/build/tree/v0.11.0/docs) | [Examples @ v0.11.0](https://github.com/shipwright-io/build/tree/v0.11.0/samples) |
174-
| [v0.10.0](https://github.com/shipwright-io/build/releases/tag/v0.10.0) | [Docs @ v0.10.0](https://github.com/shipwright-io/build/tree/v0.10.0/docs) | [Examples @ v0.10.0](https://github.com/shipwright-io/build/tree/v0.10.0/samples) |
175-
| [v0.9.0](https://github.com/shipwright-io/build/releases/tag/v0.9.0) | [Docs @ v0.9.0](https://github.com/shipwright-io/build/tree/v0.9.0/docs) | [Examples @ v0.9.0](https://github.com/shipwright-io/build/tree/v0.9.0/samples) |
176-
| [v0.8.0](https://github.com/shipwright-io/build/releases/tag/v0.8.0) | [Docs @ v0.8.0](https://github.com/shipwright-io/build/tree/v0.8.0/docs) | [Examples @ v0.8.0](https://github.com/shipwright-io/build/tree/v0.8.0/samples) |
177-
| [v0.7.0](https://github.com/shipwright-io/build/releases/tag/v0.7.0) | [Docs @ v0.7.0](https://github.com/shipwright-io/build/tree/v0.7.0/docs) | [Examples @ v0.7.0](https://github.com/shipwright-io/build/tree/v0.7.0/samples) |
178-
| [v0.6.0](https://github.com/shipwright-io/build/releases/tag/v0.6.0) | [Docs @ v0.6.0](https://github.com/shipwright-io/build/tree/v0.6.0/docs) | [Examples @ v0.6.0](https://github.com/shipwright-io/build/tree/v0.6.0/samples) |
179-
| [v0.5.1](https://github.com/shipwright-io/build/releases/tag/v0.5.1) | [Docs @ v0.5.1](https://github.com/shipwright-io/build/tree/v0.5.1/docs) | [Examples @ v0.5.1](https://github.com/shipwright-io/build/tree/v0.5.1/samples) |
180-
| [v0.5.0](https://github.com/shipwright-io/build/releases/tag/v0.5.0) | [Docs @ v0.5.0](https://github.com/shipwright-io/build/tree/v0.5.0/docs) | [Examples @ v0.5.0](https://github.com/shipwright-io/build/tree/v0.5.0/samples) |
181-
| [v0.4.0](https://github.com/shipwright-io/build/releases/tag/v0.4.0) | [Docs @ v0.4.0](https://github.com/shipwright-io/build/tree/v0.4.0/docs) | [Examples @ v0.4.0](https://github.com/shipwright-io/build/tree/v0.4.0/samples) |
182-
| [v0.3.0](https://github.com/shipwright-io/build/releases/tag/v0.3.0) | [Docs @ v0.3.0](https://github.com/shipwright-io/build/tree/v0.3.0/docs) | [Examples @ v0.3.0](https://github.com/shipwright-io/build/tree/v0.3.0/samples) |
183-
| [v0.2.0](https://github.com/shipwright-io/build/releases/tag/v0.2.0) | [Docs @ v0.2.0](https://github.com/shipwright-io/build/tree/v0.2.0/docs) | [Examples @ v0.2.0](https://github.com/shipwright-io/build/tree/v0.2.0/samples) |
184-
| [v0.1.1](https://github.com/shipwright-io/build/releases/tag/v0.1.1) | [Docs @ v0.1.1](https://github.com/shipwright-io/build/tree/v0.1.1/docs) | [Examples @ v0.1.1](https://github.com/shipwright-io/build/tree/v0.1.1/samples) |
185-
| [v0.1.0](https://github.com/shipwright-io/build/releases/tag/v0.1.0) | [Docs @ v0.1.0](https://github.com/shipwright-io/build/tree/v0.1.0/docs) | [Examples @ v0.1.0](https://github.com/shipwright-io/build/tree/v0.1.0/samples) |
169+
| Version | Docs | Examples |
170+
|------------------------------------------------------------------------|----------------------------------------------------------------------------|-----------------------------------------------------------------------------------|
171+
| HEAD | [Docs @ HEAD](docs/README.md) | [Examples @ HEAD](samples) |
172+
| [v0.12.0](https://github.com/shipwright-io/build/releases/tag/v0.12.0) | [Docs @ v0.12.0](https://github.com/shipwright-io/build/tree/v0.12.0/docs) | [Examples @ v0.12.0](https://github.com/shipwright-io/build/tree/v0.12.0/samples) |
173+
| [v0.11.0](https://github.com/shipwright-io/build/releases/tag/v0.11.0) | [Docs @ v0.11.0](https://github.com/shipwright-io/build/tree/v0.11.0/docs) | [Examples @ v0.11.0](https://github.com/shipwright-io/build/tree/v0.11.0/samples) |
174+
| [v0.10.0](https://github.com/shipwright-io/build/releases/tag/v0.10.0) | [Docs @ v0.10.0](https://github.com/shipwright-io/build/tree/v0.10.0/docs) | [Examples @ v0.10.0](https://github.com/shipwright-io/build/tree/v0.10.0/samples) |
175+
| [v0.9.0](https://github.com/shipwright-io/build/releases/tag/v0.9.0) | [Docs @ v0.9.0](https://github.com/shipwright-io/build/tree/v0.9.0/docs) | [Examples @ v0.9.0](https://github.com/shipwright-io/build/tree/v0.9.0/samples) |
176+
| [v0.8.0](https://github.com/shipwright-io/build/releases/tag/v0.8.0) | [Docs @ v0.8.0](https://github.com/shipwright-io/build/tree/v0.8.0/docs) | [Examples @ v0.8.0](https://github.com/shipwright-io/build/tree/v0.8.0/samples) |
177+
| [v0.7.0](https://github.com/shipwright-io/build/releases/tag/v0.7.0) | [Docs @ v0.7.0](https://github.com/shipwright-io/build/tree/v0.7.0/docs) | [Examples @ v0.7.0](https://github.com/shipwright-io/build/tree/v0.7.0/samples) |
178+
| [v0.6.0](https://github.com/shipwright-io/build/releases/tag/v0.6.0) | [Docs @ v0.6.0](https://github.com/shipwright-io/build/tree/v0.6.0/docs) | [Examples @ v0.6.0](https://github.com/shipwright-io/build/tree/v0.6.0/samples) |
179+
| [v0.5.1](https://github.com/shipwright-io/build/releases/tag/v0.5.1) | [Docs @ v0.5.1](https://github.com/shipwright-io/build/tree/v0.5.1/docs) | [Examples @ v0.5.1](https://github.com/shipwright-io/build/tree/v0.5.1/samples) |
180+
| [v0.5.0](https://github.com/shipwright-io/build/releases/tag/v0.5.0) | [Docs @ v0.5.0](https://github.com/shipwright-io/build/tree/v0.5.0/docs) | [Examples @ v0.5.0](https://github.com/shipwright-io/build/tree/v0.5.0/samples) |
181+
| [v0.4.0](https://github.com/shipwright-io/build/releases/tag/v0.4.0) | [Docs @ v0.4.0](https://github.com/shipwright-io/build/tree/v0.4.0/docs) | [Examples @ v0.4.0](https://github.com/shipwright-io/build/tree/v0.4.0/samples) |
182+
| [v0.3.0](https://github.com/shipwright-io/build/releases/tag/v0.3.0) | [Docs @ v0.3.0](https://github.com/shipwright-io/build/tree/v0.3.0/docs) | [Examples @ v0.3.0](https://github.com/shipwright-io/build/tree/v0.3.0/samples) |
183+
| [v0.2.0](https://github.com/shipwright-io/build/releases/tag/v0.2.0) | [Docs @ v0.2.0](https://github.com/shipwright-io/build/tree/v0.2.0/docs) | [Examples @ v0.2.0](https://github.com/shipwright-io/build/tree/v0.2.0/samples) |
184+
| [v0.1.1](https://github.com/shipwright-io/build/releases/tag/v0.1.1) | [Docs @ v0.1.1](https://github.com/shipwright-io/build/tree/v0.1.1/docs) | [Examples @ v0.1.1](https://github.com/shipwright-io/build/tree/v0.1.1/samples) |
185+
| [v0.1.0](https://github.com/shipwright-io/build/releases/tag/v0.1.0) | [Docs @ v0.1.0](https://github.com/shipwright-io/build/tree/v0.1.0/docs) | [Examples @ v0.1.0](https://github.com/shipwright-io/build/tree/v0.1.0/samples) |
186186
187187
### Dependencies
188188
189189
| Dependency | Supported versions |
190-
| -------------------------------------| ---------------------------- |
190+
|--------------------------------------|------------------------------|
191191
| [Kubernetes](https://kubernetes.io/) | v1.27.\*, v1.28.\*, v1.29.\* |
192192
| [Tekton](https://tekton.dev) | v0.50.\*, v0.53.\*, v0.56.\* |
193193

docs/build.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ A `Build` resource can specify a source type, such as a Git repository or an OCI
126126
- `source.type` - Specify the type of the data-source. Currently, the supported types are "Git", "OCIArtifact", and "Local".
127127
- `source.git.url` - Specify the source location using a Git repository.
128128
- `source.git.cloneSecret` - For private repositories or registries, the name references a secret in the namespace that contains the SSH private key or Docker access credentials, respectively.
129-
- `source.git.revision` - A specific revision to select from the source repository, this can be a commit, tag or branch name. If not defined, it will fallback to the Git repository default branch.
129+
- `source.git.revision` - A specific revision to select from the source repository, this can be a commit, tag or branch name. If not defined, it will fall back to the Git repository default branch.
130130
- `source.contextDir` - For repositories where the source code is not located at the root folder, you can specify this path here.
131131

132132
By default, the Build controller does not validate that the Git repository exists. If the validation is desired, users can explicitly define the `build.shipwright.io/verify.repository` annotation with `true`. For example:
@@ -283,7 +283,7 @@ spec:
283283

284284
### Defining ParamValues
285285

286-
A `Build` resource can specify _paramValues_ for parameters that are defined in the referenced `BuildStrategy`. You specify these parameter values to control how the steps of the build strategy behave. You can overwrite values in the `BuildRun` resource. See the related [documentation](./buildrun.md#defining-params) for more information.
286+
A `Build` resource can specify _paramValues_ for parameters that are defined in the referenced `BuildStrategy`. You specify these parameter values to control how the steps of the build strategy behave. You can overwrite values in the `BuildRun` resource. See the related [documentation](buildrun.md#defining-paramvalues) for more information.
287287

288288
The build strategy author can define a parameter as either a simple string or an array. Depending on that, you must specify the value accordingly. The build strategy parameter can be specified with a default value. You must specify a value in the `Build` or `BuildRun` for parameters without a default.
289289

docs/buildrun.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,7 @@ The following table illustrates the different states a BuildRun can have under i
392392
| False | BuildRunAmbiguousBuild | Yes | The defined `BuildRun` uses both `spec.build.name` and `spec.build.spec`. Only one of them is allowed at the same time. |
393393
| False | BuildRunBuildFieldOverrideForbidden | Yes | The defined `BuildRun` uses an override (e.g. `timeout`, `paramValues`, `output`, or `env`) in combination with `spec.build.spec`, which is not allowed. Use the `spec.build.spec` to directly specify the respective value. |
394394
| False | PodEvicted | Yes | The BuildRun Pod was evicted from the node it was running on. See [API-initiated Eviction](https://kubernetes.io/docs/concepts/scheduling-eviction/api-eviction/) and [Node-pressure Eviction](https://kubernetes.io/docs/concepts/scheduling-eviction/node-pressure-eviction/) for more information. |
395-
| False | StepOutOfMemory | Yes | The BuildRun Pod failed because a step went out of memory. |
395+
| False | StepOutOfMemory | Yes | The BuildRun Pod failed because a step went out of memory. |
396396

397397
**Note**: We heavily rely on the Tekton TaskRun [Conditions](https://github.com/tektoncd/pipeline/blob/main/docs/taskruns.md#monitoring-execution-status) for populating the BuildRun ones, with some exceptions.
398398

@@ -524,4 +524,4 @@ For every BuildRun controller reconciliation, the `buildSpec` in the status of t
524524

525525
The `BuildRun` resource abstracts the image construction by delegating this work to the Tekton Pipeline [TaskRun](https://github.com/tektoncd/pipeline/blob/main/docs/taskruns.md). Compared to a Tekton Pipeline [Task](https://github.com/tektoncd/pipeline/blob/main/docs/tasks.md), a `TaskRun` runs all `steps` until completion of the `Task` or until a failure occurs in the `Task`.
526526

527-
During the Reconcile, the `BuildRun` controller will generate a new `TaskRun`. The controller will embed in the `TaskRun` `Task` definition the requires `steps` to execute during the execution. These `steps` are defined in the strategy defined in the `Build` resource, either a `ClusterBuildStrategy` or a `BuildStrategy`.
527+
During the Reconcile, the `BuildRun` controller will generate a new `TaskRun`. The controller will embed in the `TaskRun` `Task` definition the required `steps` to execute during the execution. These `steps` are defined in the strategy defined in the `Build` resource, either a `ClusterBuildStrategy` or a `BuildStrategy`.

0 commit comments

Comments
 (0)