Skip to content

Consider deadpool-postgres #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
elpiel opened this issue Nov 22, 2019 · 2 comments · Fixed by #399
Closed

Consider deadpool-postgres #199

elpiel opened this issue Nov 22, 2019 · 2 comments · Fixed by #399
Labels
enhancement New feature or request question Further information is requested

Comments

@elpiel
Copy link
Member

elpiel commented Nov 22, 2019 •
edited
Loading

It seems much nicer and simpler that bb8:
https://crates.io/crates/deadpool-postgres/

Couple of things to note:

  1. It has Transactions baked in! 🎉
  2. async/await with non-blocking drop based interface
  3. Has statements caching
@elpiel elpiel added enhancement New feature or request question Further information is requested labels Nov 22, 2019
@elpiel
Copy link
Member Author

elpiel commented Mar 20, 2020 •
edited
Loading

How easy is to update: Very easy
What are the benefits: Code clean up
Why: bb8 is not very maintained atm and poses phalanges with it's API

@elpiel elpiel linked a pull request Jun 18, 2021 that will close this issue
replace bb8 & update test pool #399
Merged
@elpiel
Copy link
Member Author

elpiel commented Jun 18, 2021

we are using deadpool-postgres since PR #399 in preparation of the changes for AIP#61

@elpiel elpiel closed this as completed Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace bb8 & update test pool AmbireTech/adex-validator-stack-rust
1 participant
@elpiel