Skip to content

AIP #61 v5: GET /channel/:id/spender/all #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
elpiel opened this issue Mar 30, 2021 · 2 comments · Fixed by #424, #441 or #451
Closed
2 tasks done

AIP #61 v5: GET /channel/:id/spender/all #392

elpiel opened this issue Mar 30, 2021 · 2 comments · Fixed by #424, #441 or #451
Assignees
Milestone

Comments

@elpiel
Copy link
Member

elpiel commented Mar 30, 2021

https://github.com/AdExNetwork/aips/issues/61

Related to #391 as this should return all spenders limits

@elpiel elpiel added this to the sentry-v0.2.0 milestone Mar 30, 2021
@elpiel elpiel linked a pull request Sep 23, 2021 that will close this issue
@elpiel elpiel closed this as completed Oct 11, 2021
@elpiel
Copy link
Member Author

elpiel commented Oct 11, 2021

There are a few tests that still need to be done for the pagination. Please refer to this PR comment:

#441 (review)

@elpiel elpiel reopened this Oct 11, 2021
@elpiel
Copy link
Member Author

elpiel commented Oct 26, 2021

TODOs

(from #441 (review)):

Make sure to make test that covers:

  • 0 records
  • less than 1 page of records
  • 2 pages of records

This way we can test if queries are correct and returning the expected results

Make sure to write tests for the pagination in Sentry to:

@elpiel elpiel linked a pull request Nov 11, 2021 that will close this issue
@elpiel elpiel closed this as completed Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment