fix permission requesting inside extension

Author: pirate

config-tab.js

@@ -23,7 +23,7 @@ export async function initializeConfigTab() {
     const statusText = document.getElementById('serverStatusText');
 
     // check if we have permission to access the server
-    const permission = await chrome.permissions.request({origins: [`${serverUrl.value}/*`]});
+    const permission = await chrome.permissions.request({permissions: ['host_permissions'], origins: [`${serverUrl.value}/*`]});
     if (!permission) {
       alert('Permission denied.');
       return;

options.html

@@ -211,7 +211,7 @@ <h5 class="modal-title">Edit Tags</h5>
                   ⚙️ ADMIN UI
                 </button>
                 <button type="button" id="testServer" class="btn btn-outline-secondary">
-                  TEST SERVER
+                  SAVE
                   <span class="status-indicator" id="serverStatus"></span>
                 </button>
               </div>
@@ -232,7 +232,7 @@ <h5 class="modal-title">Edit Tags</h5>
                   🔑 GENERATE
                 </button>
                 <button type="button" id="testApiKey" class="btn btn-outline-secondary">
-                  TEST API KEY
+                  SAVE
                   <span class="status-indicator" id="apiKeyStatus"></span>
                 </button>
               </div>

utils.js

@@ -18,14 +18,6 @@ export function filterEntries(entries, filterText) {
 }
 
 export async function addToArchiveBox(addCommandArgs, onComplete, onError) {
-  // request permission to POST to the ArchiveBox server, upgrade optional_host_permissions
-  // const permission = await chrome.permissions.request({permissions: [archivebox_server_url, 'host_permissions']});
-  const permission = await chrome.permissions.request({origins: [`${archivebox_server_url}/*`]});
-  if (!permission) {
-    onError({ok: false, errorMessage: 'Permission denied.'});
-    return;
-  }
-
   try {
     const { archivebox_server_url, archivebox_api_key } = await new Promise((resolve, reject) => {
       const vals = chrome.storage.local.get([
@@ -44,6 +36,14 @@ export async function addToArchiveBox(addCommandArgs, onComplete, onError) {
       throw new Error('Server not configured.');
     }
 
+    // request permission to POST to the ArchiveBox server, upgrade optional_host_permissions
+    // const permission = await chrome.permissions.request({permissions: [archivebox_server_url, 'host_permissions']});
+    const permission = await chrome.permissions.request({origins: [`${archivebox_server_url}/*`]});
+    if (!permission) {
+      onError({ok: false, errorMessage: 'Permission denied.'});
+      return;
+    }
+
     let response = undefined;
     // try ArchiveBox v0.8.0+ API endpoint first
     if (archivebox_api_key) {