From a06122316e7c85456fae950dfa0e36f0a611203e Mon Sep 17 00:00:00 2001 From: tbradsha <32492176+tbradsha@users.noreply.github.com> Date: Thu, 24 Apr 2025 11:40:42 -0600 Subject: [PATCH 01/25] Undisable property-no-unknown --- tools/js-tools/stylelint.config.base.mjs | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/tools/js-tools/stylelint.config.base.mjs b/tools/js-tools/stylelint.config.base.mjs index 261c383ee7c72..a6a4416d50a4b 100644 --- a/tools/js-tools/stylelint.config.base.mjs +++ b/tools/js-tools/stylelint.config.base.mjs @@ -27,14 +27,21 @@ const baseConfig = { // https://github.com/stylelint/stylelint/issues/7844#issuecomment-2230857428 'no-descending-specificity': null, + 'property-no-unknown': [ + true, + { + ignoreSelectors: [ ':export' ], // Ignore selector used by CSS Modules. + ignoreProperties: [ 'shadow-color' ], // Ignore property used by React Native. + }, + ], + // Disabled until a valid pattern has been decided on: https://github.com/WordPress/gutenberg/issues/28616 'selector-class-pattern': null, - // Allow some pseudo-classes that are needed for CSS modules. 'selector-pseudo-class-no-unknown': [ true, { - ignorePseudoClasses: [ 'export', 'global' ], + ignorePseudoClasses: [ 'export', 'global' ], // Ignore pseudo-classes used by CSS Modules. }, ], @@ -49,7 +56,6 @@ const baseConfig = { // Disable all other rules for now. 'declaration-property-unit-allowed-list': null, 'no-duplicate-selectors': null, - 'property-no-unknown': null, 'scss/at-extend-no-missing-placeholder': null, 'scss/comment-no-empty': null, 'scss/no-global-function-names': null, From 150d4e0cbbc191e9a43b836c7cf055df96e073ae Mon Sep 17 00:00:00 2001 From: tbradsha <32492176+tbradsha@users.noreply.github.com> Date: Thu, 24 Apr 2025 12:49:08 -0600 Subject: [PATCH 02/25] Fix declaration-property-unit-allowed-list in VaultPress --- projects/plugins/vaultpress/styles.css | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/projects/plugins/vaultpress/styles.css b/projects/plugins/vaultpress/styles.css index 925474d688295..4813a5d48097c 100644 --- a/projects/plugins/vaultpress/styles.css +++ b/projects/plugins/vaultpress/styles.css @@ -885,7 +885,7 @@ Progress Bars margin: 0; padding: 15px 30px; width: 100%; - line-height: 100%; + line-height: 1; border-top: 1px solid rgba(0,0,0,0.3); border-bottom: 1px solid rgba(255,255,255,0.05); } @@ -988,7 +988,7 @@ Progress Bars color: #777; margin: 0 0 15px 0; font-size: 12px; - line-height: 160%; + line-height: 1.6; } .vp_progress-description strong { @@ -999,7 +999,7 @@ Progress Bars font-size: 12px; color: #999; font-style: italic; - line-height: 160%; + line-height: 1.6; margin: 0 0 30px 0; } From dce553344d38c8e9e1557227d9ad03ab0abd0407 Mon Sep 17 00:00:00 2001 From: tbradsha <32492176+tbradsha@users.noreply.github.com> Date: Thu, 24 Apr 2025 12:51:05 -0600 Subject: [PATCH 03/25] Fix declaration-property-unit-allowed-list in CRM --- projects/plugins/crm/css/welcome-to-zbs/wizard.scss | 2 +- .../modules/mailpoet/sass/jpcrm-mailpoet-hub-page.scss | 8 ++++---- .../modules/woo-sync/sass/jpcrm-woo-sync-hub-page.scss | 8 ++++---- .../plugins/crm/sass/ZeroBSCRM.admin.invoicebuilder.scss | 2 +- .../plugins/crm/sass/ZeroBSCRM.admin.quotebuilder.scss | 4 ++-- projects/plugins/crm/sass/ZeroBSCRM.admin.singleview.scss | 2 +- projects/plugins/crm/sass/ZeroBSCRM.admin.sortables.scss | 4 ++-- projects/plugins/crm/sass/_ZeroBSCRM.adminpages.scss | 2 +- projects/plugins/crm/sass/_ZeroBSCRM.customerfilters.scss | 2 +- projects/plugins/crm/sass/_ZeroBSCRM.editcontact.scss | 4 ++-- projects/plugins/crm/sass/_ZeroBSCRM.editview.scss | 2 +- projects/plugins/crm/sass/_ZeroBSCRM.forms.scss | 4 ++-- .../plugins/crm/sass/_ZeroBSCRM.genericeditpages.scss | 4 ++-- projects/plugins/crm/sass/_ZeroBSCRM.timelines.scss | 4 ++-- projects/plugins/crm/sass/_ZeroBSCRM.typeahead.scss | 2 +- projects/plugins/crm/sass/_daterangepicker.dirty.fix.scss | 2 +- projects/plugins/crm/sass/_wp-semantic-fixes.scss | 4 ++-- projects/plugins/crm/sass/jpcrm-admin-tasks.scss | 6 +++--- 18 files changed, 33 insertions(+), 33 deletions(-) diff --git a/projects/plugins/crm/css/welcome-to-zbs/wizard.scss b/projects/plugins/crm/css/welcome-to-zbs/wizard.scss index de36d45b6606e..f5e0691aa3364 100644 --- a/projects/plugins/crm/css/welcome-to-zbs/wizard.scss +++ b/projects/plugins/crm/css/welcome-to-zbs/wizard.scss @@ -161,7 +161,7 @@ input[type="checkbox"], input[type="radio"]{ /* divider image */ background: #f9f9f9; font-family: 'Helvetica Neue', Helvetica, Arial, Verdana, sans-serif; - line-height: 1.5em; + line-height: 1.5; overflow: hidden; color: #666; font-size: 16px; diff --git a/projects/plugins/crm/modules/mailpoet/sass/jpcrm-mailpoet-hub-page.scss b/projects/plugins/crm/modules/mailpoet/sass/jpcrm-mailpoet-hub-page.scss index a3bfc6f870e62..383655b0f404d 100644 --- a/projects/plugins/crm/modules/mailpoet/sass/jpcrm-mailpoet-hub-page.scss +++ b/projects/plugins/crm/modules/mailpoet/sass/jpcrm-mailpoet-hub-page.scss @@ -82,7 +82,7 @@ .jpcrm-mailpoet-stats-url { - line-height: 0.8em; + line-height: 0.8; } @@ -94,7 +94,7 @@ } - .jpcrm-mailpoet-recap { + .jpcrm-mailpoet-recap { margin: 0; color: #aca0a0; } @@ -136,7 +136,7 @@ background: #f1e9e9; color: #000; - line-height: 2em; + line-height: 2; overflow-x: scroll; padding: 0.5em 1em; @@ -171,4 +171,4 @@ .jpcrm-clickable:hover { cursor: pointer; } -} \ No newline at end of file +} diff --git a/projects/plugins/crm/modules/woo-sync/sass/jpcrm-woo-sync-hub-page.scss b/projects/plugins/crm/modules/woo-sync/sass/jpcrm-woo-sync-hub-page.scss index fd3febac4bec5..cc61d4e8dc236 100644 --- a/projects/plugins/crm/modules/woo-sync/sass/jpcrm-woo-sync-hub-page.scss +++ b/projects/plugins/crm/modules/woo-sync/sass/jpcrm-woo-sync-hub-page.scss @@ -84,7 +84,7 @@ .jpcrm-woosync-stats-url { - line-height: 0.8em; + line-height: 0.8; } @@ -165,7 +165,7 @@ font-size: 0.5em; margin-top: 1.0em; - line-height: 1.2em; + line-height: 1.2; } } @@ -178,7 +178,7 @@ background: #f1e9e9; color: #000; - line-height: 2em; + line-height: 2; overflow-x: scroll; padding: 0.5em 1em; @@ -213,4 +213,4 @@ .jpcrm-clickable:hover { cursor: pointer; } -} \ No newline at end of file +} diff --git a/projects/plugins/crm/sass/ZeroBSCRM.admin.invoicebuilder.scss b/projects/plugins/crm/sass/ZeroBSCRM.admin.invoicebuilder.scss index 5c3da633c0664..e8ee82a7d0929 100644 --- a/projects/plugins/crm/sass/ZeroBSCRM.admin.invoicebuilder.scss +++ b/projects/plugins/crm/sass/ZeroBSCRM.admin.invoicebuilder.scss @@ -1050,7 +1050,7 @@ input[type="checkbox"]{ margin-right: 0.7em; vertical-align: middle; - line-height: 1em; + line-height: 1; } label { diff --git a/projects/plugins/crm/sass/ZeroBSCRM.admin.quotebuilder.scss b/projects/plugins/crm/sass/ZeroBSCRM.admin.quotebuilder.scss index 7baafd4b51c13..575483fc0ee9c 100644 --- a/projects/plugins/crm/sass/ZeroBSCRM.admin.quotebuilder.scss +++ b/projects/plugins/crm/sass/ZeroBSCRM.admin.quotebuilder.scss @@ -77,10 +77,10 @@ transition: border-color ease-in-out 0.15s,box-shadow ease-in-out 0.15s; } - input[type="checkbox"]{ + input[type="checkbox"]{ margin-right: 0.7em; vertical-align: middle; - line-height: 1em; + line-height: 1; } label { diff --git a/projects/plugins/crm/sass/ZeroBSCRM.admin.singleview.scss b/projects/plugins/crm/sass/ZeroBSCRM.admin.singleview.scss index f7cdaa98a4cc6..b27a444e84cd0 100644 --- a/projects/plugins/crm/sass/ZeroBSCRM.admin.singleview.scss +++ b/projects/plugins/crm/sass/ZeroBSCRM.admin.singleview.scss @@ -89,7 +89,7 @@ font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Oxygen-Sans, Ubuntu, Cantarell, 'Helvetica Neue', sans-serif; margin: 0 0.25em 0 0; padding: 0.78571429em 1.5em 0.78571429em; - line-height: 1em; + line-height: 1; font-style: normal; text-align: center; text-decoration: none; diff --git a/projects/plugins/crm/sass/ZeroBSCRM.admin.sortables.scss b/projects/plugins/crm/sass/ZeroBSCRM.admin.sortables.scss index 7a3e8907874e5..784ab34c1acbc 100644 --- a/projects/plugins/crm/sass/ZeroBSCRM.admin.sortables.scss +++ b/projects/plugins/crm/sass/ZeroBSCRM.admin.sortables.scss @@ -51,7 +51,7 @@ float: right; text-align: right; - line-height: 1em; + line-height: 1; margin-top: -7px; label { @@ -63,7 +63,7 @@ input { - line-height: 1em; + line-height: 1; display: inline-block; vertical-align: middle; diff --git a/projects/plugins/crm/sass/_ZeroBSCRM.adminpages.scss b/projects/plugins/crm/sass/_ZeroBSCRM.adminpages.scss index 78a6c64b673b2..11ec6c873d68c 100644 --- a/projects/plugins/crm/sass/_ZeroBSCRM.adminpages.scss +++ b/projects/plugins/crm/sass/_ZeroBSCRM.adminpages.scss @@ -361,7 +361,7 @@ div.ui.learn.button { i { font-size: 4em; - line-height: 1.5em; + line-height: 1.5; } diff --git a/projects/plugins/crm/sass/_ZeroBSCRM.customerfilters.scss b/projects/plugins/crm/sass/_ZeroBSCRM.customerfilters.scss index ca45a4ecc9c70..be441fdf8b9d0 100644 --- a/projects/plugins/crm/sass/_ZeroBSCRM.customerfilters.scss +++ b/projects/plugins/crm/sass/_ZeroBSCRM.customerfilters.scss @@ -14,7 +14,7 @@ border: 1px solid #dedee3; padding: 11px; font-size: 12px; - line-height: 1.3em; + line-height: 1.3; margin-bottom: 22px; overflow: auto; border-radius: 4px; diff --git a/projects/plugins/crm/sass/_ZeroBSCRM.editcontact.scss b/projects/plugins/crm/sass/_ZeroBSCRM.editcontact.scss index e6244af74857d..003e4135bfb85 100644 --- a/projects/plugins/crm/sass/_ZeroBSCRM.editcontact.scss +++ b/projects/plugins/crm/sass/_ZeroBSCRM.editcontact.scss @@ -29,7 +29,7 @@ .zbs-social-acc-input { font-size: 14px !important; - line-height: 1.4em !important; + line-height: 1.4 !important; height: 36px !important; max-width: 100%; width: 75%; @@ -79,7 +79,7 @@ .zbs-aka-alias-input { font-size: 14px !important; - line-height: 1.4em !important; + line-height: 1.4 !important; height: 36px !important; max-width: 100%; width: 100%; diff --git a/projects/plugins/crm/sass/_ZeroBSCRM.editview.scss b/projects/plugins/crm/sass/_ZeroBSCRM.editview.scss index 177810d980722..1c250a2beb798 100644 --- a/projects/plugins/crm/sass/_ZeroBSCRM.editview.scss +++ b/projects/plugins/crm/sass/_ZeroBSCRM.editview.scss @@ -73,7 +73,7 @@ font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Oxygen-Sans, Ubuntu, Cantarell, 'Helvetica Neue', sans-serif; margin: 0 0.25em 0 0; padding: 0.78571429em 1.5em 0.78571429em; - line-height: 1em; + line-height: 1; font-style: normal; text-align: center; text-decoration: none; diff --git a/projects/plugins/crm/sass/_ZeroBSCRM.forms.scss b/projects/plugins/crm/sass/_ZeroBSCRM.forms.scss index c5e2d628e444b..5c70830263225 100644 --- a/projects/plugins/crm/sass/_ZeroBSCRM.forms.scss +++ b/projects/plugins/crm/sass/_ZeroBSCRM.forms.scss @@ -82,7 +82,7 @@ input.zbs-prominent { font-size: 14px !important; color: #008000 !important; - line-height: 1.4em; + line-height: 1.4; height: 38px !important; } @@ -179,5 +179,5 @@ tr.zbs-field-group-tr label.zbs-field-group-label { #zbs-add-tag-value { font-size: 14px; - line-height: 1.4em; + line-height: 1.4; } diff --git a/projects/plugins/crm/sass/_ZeroBSCRM.genericeditpages.scss b/projects/plugins/crm/sass/_ZeroBSCRM.genericeditpages.scss index c7fc8ac3f46d5..b406d7cb007ae 100644 --- a/projects/plugins/crm/sass/_ZeroBSCRM.genericeditpages.scss +++ b/projects/plugins/crm/sass/_ZeroBSCRM.genericeditpages.scss @@ -16,8 +16,8 @@ tr.wh-large label { } tr.wh-large select, tr.wh-large input { - font-size:14px; - line-height: 1.4em; + font-size:14px; + line-height: 1.4; } // fixes radio buttons + checkbox heights (which above breaks!) tr.wh-large input[type="radio"] { diff --git a/projects/plugins/crm/sass/_ZeroBSCRM.timelines.scss b/projects/plugins/crm/sass/_ZeroBSCRM.timelines.scss index f07b70512397a..54797e298ef4c 100644 --- a/projects/plugins/crm/sass/_ZeroBSCRM.timelines.scss +++ b/projects/plugins/crm/sass/_ZeroBSCRM.timelines.scss @@ -11,7 +11,7 @@ $primary-color-hover: scale-color($primary-color, $lightness: 32%); /*-- GENERAL STYLES ------------------------------*/ .zbs-timeline { - line-height: 1.4em; + line-height: 1.4; list-style: none; margin: 0; padding: 0; @@ -379,4 +379,4 @@ $primary-color-hover: scale-color($primary-color, $lightness: 32%); .zbs-timeline-item:hover .zbs-timeline-marker::before { background: $primary-color; } - } \ No newline at end of file + } diff --git a/projects/plugins/crm/sass/_ZeroBSCRM.typeahead.scss b/projects/plugins/crm/sass/_ZeroBSCRM.typeahead.scss index 61763246722dd..f1abf18ebe001 100644 --- a/projects/plugins/crm/sass/_ZeroBSCRM.typeahead.scss +++ b/projects/plugins/crm/sass/_ZeroBSCRM.typeahead.scss @@ -34,7 +34,7 @@ // overrides (smaller) font-size: 14px !important; - line-height: 1.4em !important; + line-height: 1.4 !important; height: 36px !important; max-width: 100%; min-width: 100% !important; diff --git a/projects/plugins/crm/sass/_daterangepicker.dirty.fix.scss b/projects/plugins/crm/sass/_daterangepicker.dirty.fix.scss index f3fbba2083396..dffec6eb176b1 100644 --- a/projects/plugins/crm/sass/_daterangepicker.dirty.fix.scss +++ b/projects/plugins/crm/sass/_daterangepicker.dirty.fix.scss @@ -190,7 +190,7 @@ table td[class*="col-"],table th[class*="col-"] { margin:2px 0 0; list-style:none; font-size:14px !important; - line-height: 1.4em; + line-height: 1.4; background-color:#fff; border:1px solid rgba(0,0,0,.15); border-radius:4px; diff --git a/projects/plugins/crm/sass/_wp-semantic-fixes.scss b/projects/plugins/crm/sass/_wp-semantic-fixes.scss index 86574c7a9d1fb..787e68853b791 100644 --- a/projects/plugins/crm/sass/_wp-semantic-fixes.scss +++ b/projects/plugins/crm/sass/_wp-semantic-fixes.scss @@ -78,7 +78,7 @@ i.card { text-align: center; font-size: 3em; - line-height: 1em; + line-height: 1; padding-top: 1em; padding-bottom: 0.5em; @@ -134,7 +134,7 @@ i.alternate { text-transform: none; text-shadow: none; font-weight: 500; - line-height: 1em; + line-height: 1; font-style: normal; text-align: center; text-decoration: none; diff --git a/projects/plugins/crm/sass/jpcrm-admin-tasks.scss b/projects/plugins/crm/sass/jpcrm-admin-tasks.scss index dbc1590ae45ce..076d55d0d6cfa 100644 --- a/projects/plugins/crm/sass/jpcrm-admin-tasks.scss +++ b/projects/plugins/crm/sass/jpcrm-admin-tasks.scss @@ -6,7 +6,7 @@ // this is extended throughout .zbs-tasks-field { - line-height: 1em; + line-height: 1; border: 1px solid #ccc; border-radius: 0.2em; box-shadow: inset 0 1px 2px rgba(0,0,0,.07); @@ -135,7 +135,7 @@ background: #fff; font-weight: 400; min-height: 0; padding: 0.2em 0.5em; - line-height: 1.4em; + line-height: 1.4; } .fc-event{ @@ -172,7 +172,7 @@ background: #fff; label { font-size: 14px; - line-height: 1.4em; + line-height: 1.4; font-weight: 400 !important; } } From b7ed896535758f130be7ea2c473e4a02ca32908f Mon Sep 17 00:00:00 2001 From: tbradsha <32492176+tbradsha@users.noreply.github.com> Date: Thu, 24 Apr 2025 13:18:18 -0600 Subject: [PATCH 04/25] Fix declaration-property-unit-allowed-list in packages/forms --- .../src/blocks/contact-form/components/help-message/style.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/packages/forms/src/blocks/contact-form/components/help-message/style.scss b/projects/packages/forms/src/blocks/contact-form/components/help-message/style.scss index b698716b74171..03f2a3a6bae59 100644 --- a/projects/packages/forms/src/blocks/contact-form/components/help-message/style.scss +++ b/projects/packages/forms/src/blocks/contact-form/components/help-message/style.scss @@ -2,7 +2,7 @@ .help-message { display: flex; font-size: 13px; - line-height: 1.4em; + line-height: 1.4; margin-bottom: 1em; margin-top: -0.5em; From 45676deb53f788955d51a0668faec9587f252f6e Mon Sep 17 00:00:00 2001 From: tbradsha <32492176+tbradsha@users.noreply.github.com> Date: Thu, 24 Apr 2025 13:19:32 -0600 Subject: [PATCH 05/25] Remove errant line --- .../video/components/details-panel/learn-how-notice/index.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/projects/packages/videopress/src/client/block-editor/blocks/video/components/details-panel/learn-how-notice/index.scss b/projects/packages/videopress/src/client/block-editor/blocks/video/components/details-panel/learn-how-notice/index.scss index 7558c9afb25ea..ff89233ff9072 100644 --- a/projects/packages/videopress/src/client/block-editor/blocks/video/components/details-panel/learn-how-notice/index.scss +++ b/projects/packages/videopress/src/client/block-editor/blocks/video/components/details-panel/learn-how-notice/index.scss @@ -9,7 +9,6 @@ p { margin: 0; - line-height: 1,8em; } .learn-how-modal__buttons { From 21d2e2a877a89d40404d3180b4f112c97410e341 Mon Sep 17 00:00:00 2001 From: tbradsha <32492176+tbradsha@users.noreply.github.com> Date: Thu, 24 Apr 2025 13:20:02 -0600 Subject: [PATCH 06/25] Comment-ignore remaining instances of declaration-property-unit-allowed-list --- .../js-packages/ai-client/src/components/message/style.scss | 1 + .../components/boost-score-graph/style-tooltip.scss | 3 ++- projects/js-packages/components/components/popover/style.scss | 3 ++- .../components/golden-token-modal/styles.module.scss | 2 ++ projects/packages/jitm/src/css/jetpack-admin-jitm.scss | 2 ++ .../src/dashboard/components/donut-meter-container/style.scss | 2 ++ .../src/instant-search/components/search-result-expanded.scss | 1 + projects/plugins/boost/app/assets/src/css/admin-banner.scss | 1 + .../error-description/error-description.module.scss | 1 + .../critical-css/numbered-list/numbered-list.module.scss | 2 ++ .../image-cdn/quality-settings/quality-settings.module.scss | 1 + .../multi-progress/multi-progress.module.scss | 1 + .../app/assets/src/js/layout/card-page/card-page.module.scss | 1 + .../modules/inc/css/wpcom-api-request-tracker.css | 1 + .../_inc/client/at-a-glance/backup-getting-started/style.scss | 4 +++- projects/plugins/jetpack/_inc/client/at-a-glance/style.scss | 2 ++ .../jetpack/_inc/client/components/apps-card/style.scss | 1 + .../_inc/client/components/jetpack-dialogue-modern/style.scss | 1 + .../jetpack/_inc/client/components/reconnect-modal/style.scss | 1 + .../recommendations/sidebar/one-click-restores/style.scss | 2 ++ projects/plugins/jetpack/_inc/client/traffic/style.scss | 1 + .../plugins/jetpack/extensions/blocks/donations/editor.scss | 1 + .../jetpack/extensions/blocks/related-posts/style.scss | 2 ++ .../jetpack/extensions/blocks/simple-payments/editor.scss | 1 + .../plugins/jetpack/extensions/blocks/wordads/editor.scss | 1 + projects/plugins/jetpack/extensions/shared/help-message.scss | 1 + .../plugins/jetpack/modules/carousel/jetpack-carousel.css | 1 + .../jetpack/modules/infinite-scroll/themes/twentysixteen.css | 2 ++ projects/plugins/jetpack/modules/shortcodes/css/quiz.css | 1 + .../jetpack/modules/theme-tools/compat/twentyfifteen.css | 3 +++ .../jetpack/modules/theme-tools/compat/twentysixteen.css | 1 + .../plugins/jetpack/scss/templates/_connection-landing.scss | 1 + 32 files changed, 46 insertions(+), 3 deletions(-) diff --git a/projects/js-packages/ai-client/src/components/message/style.scss b/projects/js-packages/ai-client/src/components/message/style.scss index ded7c9e3e6519..7e962cb4bbd87 100644 --- a/projects/js-packages/ai-client/src/components/message/style.scss +++ b/projects/js-packages/ai-client/src/components/message/style.scss @@ -18,6 +18,7 @@ .jetpack-ai-assistant__message-content { flex-grow: 2; margin: 0 8px; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 1.4em; display: flex; gap: 4px; diff --git a/projects/js-packages/components/components/boost-score-graph/style-tooltip.scss b/projects/js-packages/components/components/boost-score-graph/style-tooltip.scss index 095d024967edc..c21fad616f377 100644 --- a/projects/js-packages/components/components/boost-score-graph/style-tooltip.scss +++ b/projects/js-packages/components/components/boost-score-graph/style-tooltip.scss @@ -43,6 +43,7 @@ $white: #fff; &__date { font-size: 1em; font-weight: 600; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 1.6em; } @@ -69,4 +70,4 @@ $white: #fff; left: 50%; transform: translateX(-50%); } -} \ No newline at end of file +} diff --git a/projects/js-packages/components/components/popover/style.scss b/projects/js-packages/components/components/popover/style.scss index deaa755d26a9a..d0d812dc664de 100644 --- a/projects/js-packages/components/components/popover/style.scss +++ b/projects/js-packages/components/components/popover/style.scss @@ -19,7 +19,8 @@ &__body p { font-weight: 400; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 1.6em; font-family: "SF Pro Text", -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", sans-serif; } -} \ No newline at end of file +} diff --git a/projects/js-packages/licensing/components/golden-token-modal/styles.module.scss b/projects/js-packages/licensing/components/golden-token-modal/styles.module.scss index 744989a5bf190..290ad11096564 100644 --- a/projects/js-packages/licensing/components/golden-token-modal/styles.module.scss +++ b/projects/js-packages/licensing/components/golden-token-modal/styles.module.scss @@ -68,10 +68,12 @@ $tablet-width: 760px; .headline { margin-bottom: 8px; font-weight: 500; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 110%; } .paragraph { + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 140%; } diff --git a/projects/packages/jitm/src/css/jetpack-admin-jitm.scss b/projects/packages/jitm/src/css/jetpack-admin-jitm.scss index 80a0f183757ea..5c113ad3042a5 100644 --- a/projects/packages/jitm/src/css/jetpack-admin-jitm.scss +++ b/projects/packages/jitm/src/css/jetpack-admin-jitm.scss @@ -425,11 +425,13 @@ $jp-gray-20: #a7aaad; .jitm-banner__title { font-size: rem( 15px ); font-weight: 700; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 136%; } .jitm-banner__description { font-size: rem( 13px ); + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 150%; margin-top: rem( 2px ); } diff --git a/projects/packages/search/src/dashboard/components/donut-meter-container/style.scss b/projects/packages/search/src/dashboard/components/donut-meter-container/style.scss index 2d87f3b5b10c4..badacf50d7a06 100644 --- a/projects/packages/search/src/dashboard/components/donut-meter-container/style.scss +++ b/projects/packages/search/src/dashboard/components/donut-meter-container/style.scss @@ -24,6 +24,7 @@ .donut-info-primary { margin: 0 0 8px 0; font-size: 1em; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 1em; font-weight: 700; } @@ -32,6 +33,7 @@ color: $studio-gray-60; margin: 0; font-size: 0.7em; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 0.7em; .info-link { diff --git a/projects/packages/search/src/instant-search/components/search-result-expanded.scss b/projects/packages/search/src/instant-search/components/search-result-expanded.scss index 3b8acd881afe1..5b731bc82c4b6 100644 --- a/projects/packages/search/src/instant-search/components/search-result-expanded.scss +++ b/projects/packages/search/src/instant-search/components/search-result-expanded.scss @@ -116,6 +116,7 @@ $image-square-size: 128px; font-style: normal; font-weight: 600; font-size: 13px; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 180%; } diff --git a/projects/plugins/boost/app/assets/src/css/admin-banner.scss b/projects/plugins/boost/app/assets/src/css/admin-banner.scss index fe41a1827fed5..57618d63855eb 100644 --- a/projects/plugins/boost/app/assets/src/css/admin-banner.scss +++ b/projects/plugins/boost/app/assets/src/css/admin-banner.scss @@ -53,6 +53,7 @@ &__title { font-size: 1.8rem; margin: 0 0 2rem; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 2.1rem; } diff --git a/projects/plugins/boost/app/assets/src/js/features/critical-css/error-description/error-description.module.scss b/projects/plugins/boost/app/assets/src/js/features/critical-css/error-description/error-description.module.scss index 2c5b701749512..a4f8791cc4265 100644 --- a/projects/plugins/boost/app/assets/src/js/features/critical-css/error-description/error-description.module.scss +++ b/projects/plugins/boost/app/assets/src/js/features/critical-css/error-description/error-description.module.scss @@ -1,4 +1,5 @@ .error-description { + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 1.5rem; color: var( --primary-black ); diff --git a/projects/plugins/boost/app/assets/src/js/features/critical-css/numbered-list/numbered-list.module.scss b/projects/plugins/boost/app/assets/src/js/features/critical-css/numbered-list/numbered-list.module.scss index 6f1485b0e24f5..8e2db169e6ef2 100644 --- a/projects/plugins/boost/app/assets/src/js/features/critical-css/numbered-list/numbered-list.module.scss +++ b/projects/plugins/boost/app/assets/src/js/features/critical-css/numbered-list/numbered-list.module.scss @@ -13,6 +13,7 @@ .text { flex: 1; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 1.3em; } @@ -23,6 +24,7 @@ width: 1.4em; height: 1.4em; text-align: center; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 1.3em; font-size: 14px; margin-right: 5px; diff --git a/projects/plugins/boost/app/assets/src/js/features/image-cdn/quality-settings/quality-settings.module.scss b/projects/plugins/boost/app/assets/src/js/features/image-cdn/quality-settings/quality-settings.module.scss index 5e519d281ca8d..ac1e5e875c18f 100644 --- a/projects/plugins/boost/app/assets/src/js/features/image-cdn/quality-settings/quality-settings.module.scss +++ b/projects/plugins/boost/app/assets/src/js/features/image-cdn/quality-settings/quality-settings.module.scss @@ -20,6 +20,7 @@ .info-icon { vertical-align: text-top; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 1em; display: inline-block; margin-left: 8px; diff --git a/projects/plugins/boost/app/assets/src/js/features/image-size-analysis/multi-progress/multi-progress.module.scss b/projects/plugins/boost/app/assets/src/js/features/image-size-analysis/multi-progress/multi-progress.module.scss index 33247e3aacd54..aff7d8b2d8bee 100644 --- a/projects/plugins/boost/app/assets/src/js/features/image-size-analysis/multi-progress/multi-progress.module.scss +++ b/projects/plugins/boost/app/assets/src/js/features/image-size-analysis/multi-progress/multi-progress.module.scss @@ -58,5 +58,6 @@ .category { grid-area: category; display: flex; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 1.6rem; } diff --git a/projects/plugins/boost/app/assets/src/js/layout/card-page/card-page.module.scss b/projects/plugins/boost/app/assets/src/js/layout/card-page/card-page.module.scss index 6203bf2b59fde..06fe6e3ba12d2 100644 --- a/projects/plugins/boost/app/assets/src/js/layout/card-page/card-page.module.scss +++ b/projects/plugins/boost/app/assets/src/js/layout/card-page/card-page.module.scss @@ -20,6 +20,7 @@ background: url(\$images/check.svg) no-repeat; background-position: 0 2px; background-size: 1.5em; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 1.5em; list-style-type: none; } diff --git a/projects/plugins/debug-helper/modules/inc/css/wpcom-api-request-tracker.css b/projects/plugins/debug-helper/modules/inc/css/wpcom-api-request-tracker.css index 93543c12ff537..b065b6bcefc81 100644 --- a/projects/plugins/debug-helper/modules/inc/css/wpcom-api-request-tracker.css +++ b/projects/plugins/debug-helper/modules/inc/css/wpcom-api-request-tracker.css @@ -11,6 +11,7 @@ background: #f1f1f1; z-index: 99000; color: #000; + /* stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values */ line-height: 150% !important; text-align: left; font-size: 12px; diff --git a/projects/plugins/jetpack/_inc/client/at-a-glance/backup-getting-started/style.scss b/projects/plugins/jetpack/_inc/client/at-a-glance/backup-getting-started/style.scss index 42c67c4dd7531..b7cb8c1fe2e3a 100644 --- a/projects/plugins/jetpack/_inc/client/at-a-glance/backup-getting-started/style.scss +++ b/projects/plugins/jetpack/_inc/client/at-a-glance/backup-getting-started/style.scss @@ -46,12 +46,14 @@ .dash-backup-getting-started__header { margin: 0 0 0.5rem; font-size: 1.25rem; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 1.75rem; } .dash-backup-getting-started__text { margin: 0; font-size: 0.75rem; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 1rem; letter-spacing: -0.02em; } @@ -62,4 +64,4 @@ @include breakpoint( '>660px' ) { margin-left: auto; } -} \ No newline at end of file +} diff --git a/projects/plugins/jetpack/_inc/client/at-a-glance/style.scss b/projects/plugins/jetpack/_inc/client/at-a-glance/style.scss index 76b9fd36276d1..c5fba4c30839e 100644 --- a/projects/plugins/jetpack/_inc/client/at-a-glance/style.scss +++ b/projects/plugins/jetpack/_inc/client/at-a-glance/style.scss @@ -118,6 +118,7 @@ margin: 0; font-size: 15px; font-weight: 700; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 136%; color: $black; } @@ -538,6 +539,7 @@ margin: rem( 16px ) rem( 24px ) 0; font-size: $font-body; font-weight: 400; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 1.5em; color: $blue-heading; } diff --git a/projects/plugins/jetpack/_inc/client/components/apps-card/style.scss b/projects/plugins/jetpack/_inc/client/components/apps-card/style.scss index bdf6a7939e8db..daa30c46baafe 100644 --- a/projects/plugins/jetpack/_inc/client/components/apps-card/style.scss +++ b/projects/plugins/jetpack/_inc/client/components/apps-card/style.scss @@ -56,6 +56,7 @@ .jp-apps-card__paragraph { margin: 14px 0 0 0; font-size: 17px; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 145%; color: var( --gray-100 ); letter-spacing: -0.24px; diff --git a/projects/plugins/jetpack/_inc/client/components/jetpack-dialogue-modern/style.scss b/projects/plugins/jetpack/_inc/client/components/jetpack-dialogue-modern/style.scss index 5d22387e42943..04aa8a34dcde5 100644 --- a/projects/plugins/jetpack/_inc/client/components/jetpack-dialogue-modern/style.scss +++ b/projects/plugins/jetpack/_inc/client/components/jetpack-dialogue-modern/style.scss @@ -103,6 +103,7 @@ h1.jp-dialogue-modern__title { .jp-dialogue-modern__cta-container { text-align: center; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 200%; padding: rem( 8px ) 0 0; diff --git a/projects/plugins/jetpack/_inc/client/components/reconnect-modal/style.scss b/projects/plugins/jetpack/_inc/client/components/reconnect-modal/style.scss index 9b82659995b01..bfee5773148b8 100644 --- a/projects/plugins/jetpack/_inc/client/components/reconnect-modal/style.scss +++ b/projects/plugins/jetpack/_inc/client/components/reconnect-modal/style.scss @@ -18,6 +18,7 @@ margin: rem( 16px ) rem( 24px ) 0; font-size: rem( 16px ); font-weight: 400; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 1.5em; color: $blue-heading; } diff --git a/projects/plugins/jetpack/_inc/client/recommendations/sidebar/one-click-restores/style.scss b/projects/plugins/jetpack/_inc/client/recommendations/sidebar/one-click-restores/style.scss index f00be20fd2038..20d51c857ca28 100644 --- a/projects/plugins/jetpack/_inc/client/recommendations/sidebar/one-click-restores/style.scss +++ b/projects/plugins/jetpack/_inc/client/recommendations/sidebar/one-click-restores/style.scss @@ -29,6 +29,7 @@ h2 { margin: 0 0 0.2rem; font-size: 0.75rem; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 1rem; letter-spacing: -0.02em; } @@ -36,6 +37,7 @@ p { margin: 0; font-size: 0.625rem; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 1rem; letter-spacing: -0.02em; } diff --git a/projects/plugins/jetpack/_inc/client/traffic/style.scss b/projects/plugins/jetpack/_inc/client/traffic/style.scss index 52fae30bf4b63..c45dbb7280f37 100644 --- a/projects/plugins/jetpack/_inc/client/traffic/style.scss +++ b/projects/plugins/jetpack/_inc/client/traffic/style.scss @@ -43,6 +43,7 @@ .jp-form-input-with-prefix-bottom-message { top: rem( -20px ); position: relative; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 2em; margin-top: 5px; } diff --git a/projects/plugins/jetpack/extensions/blocks/donations/editor.scss b/projects/plugins/jetpack/extensions/blocks/donations/editor.scss index de97f83f4b7a9..005869c11fb5c 100644 --- a/projects/plugins/jetpack/extensions/blocks/donations/editor.scss +++ b/projects/plugins/jetpack/extensions/blocks/donations/editor.scss @@ -48,6 +48,7 @@ .jetpack-donations__currency-toggle { font-weight: 700; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 100%; width: max-content; } diff --git a/projects/plugins/jetpack/extensions/blocks/related-posts/style.scss b/projects/plugins/jetpack/extensions/blocks/related-posts/style.scss index e862ee643de01..ef2525310e256 100644 --- a/projects/plugins/jetpack/extensions/blocks/related-posts/style.scss +++ b/projects/plugins/jetpack/extensions/blocks/related-posts/style.scss @@ -39,12 +39,14 @@ &__post-heading { margin: 0.5rem 0; font-size: 1rem; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 1.2em; } &__post-link { display: block; width: 100%; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 1.2em; margin: 0.2em 0; } diff --git a/projects/plugins/jetpack/extensions/blocks/simple-payments/editor.scss b/projects/plugins/jetpack/extensions/blocks/simple-payments/editor.scss index 0855304fdf45b..923a1c557815b 100644 --- a/projects/plugins/jetpack/extensions/blocks/simple-payments/editor.scss +++ b/projects/plugins/jetpack/extensions/blocks/simple-payments/editor.scss @@ -125,6 +125,7 @@ margin-bottom: 5px; .components-toggle-control__label { + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 1.4em; } } diff --git a/projects/plugins/jetpack/extensions/blocks/wordads/editor.scss b/projects/plugins/jetpack/extensions/blocks/wordads/editor.scss index b111190ba25d5..4f758fe7d0169 100644 --- a/projects/plugins/jetpack/extensions/blocks/wordads/editor.scss +++ b/projects/plugins/jetpack/extensions/blocks/wordads/editor.scss @@ -15,6 +15,7 @@ } .components-toggle-control__label { + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 1.4em; } diff --git a/projects/plugins/jetpack/extensions/shared/help-message.scss b/projects/plugins/jetpack/extensions/shared/help-message.scss index b698716b74171..935f53c45fc64 100644 --- a/projects/plugins/jetpack/extensions/shared/help-message.scss +++ b/projects/plugins/jetpack/extensions/shared/help-message.scss @@ -2,6 +2,7 @@ .help-message { display: flex; font-size: 13px; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 1.4em; margin-bottom: 1em; margin-top: -0.5em; diff --git a/projects/plugins/jetpack/modules/carousel/jetpack-carousel.css b/projects/plugins/jetpack/modules/carousel/jetpack-carousel.css index 0b1a940c2e3df..422871824b011 100644 --- a/projects/plugins/jetpack/modules/carousel/jetpack-carousel.css +++ b/projects/plugins/jetpack/modules/carousel/jetpack-carousel.css @@ -481,6 +481,7 @@ div.jp-carousel-buttons a:hover { background: none !important; border: none !important; font-weight: 400 !important; + /* stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values */ line-height: 1.3em !important; } diff --git a/projects/plugins/jetpack/modules/infinite-scroll/themes/twentysixteen.css b/projects/plugins/jetpack/modules/infinite-scroll/themes/twentysixteen.css index dade50c40463b..fd22a46de3547 100644 --- a/projects/plugins/jetpack/modules/infinite-scroll/themes/twentysixteen.css +++ b/projects/plugins/jetpack/modules/infinite-scroll/themes/twentysixteen.css @@ -76,6 +76,7 @@ body #infinite-footer .container { body #infinite-footer .blog-info { font-family: Montserrat, "Helvetica Neue", sans-serif; height: 2.1875em; + /* stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values */ line-height: 2.1875em; } @@ -88,6 +89,7 @@ body #infinite-footer .blog-credits { font-size: 13px; font-size: 0.8125rem; height: 2.692307692em; + /* stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values */ line-height: 2.692307692em; } diff --git a/projects/plugins/jetpack/modules/shortcodes/css/quiz.css b/projects/plugins/jetpack/modules/shortcodes/css/quiz.css index 461c4434224f5..95a11b828b653 100644 --- a/projects/plugins/jetpack/modules/shortcodes/css/quiz.css +++ b/projects/plugins/jetpack/modules/shortcodes/css/quiz.css @@ -2,6 +2,7 @@ div.jetpack-quiz { border: 1px solid #deede3; background-color: #f3f3f3; padding: 1em; + /* stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values */ line-height: 1.3em; margin-bottom: 2em; border-radius: .2em; diff --git a/projects/plugins/jetpack/modules/theme-tools/compat/twentyfifteen.css b/projects/plugins/jetpack/modules/theme-tools/compat/twentyfifteen.css index 37a10afcb7163..ac6a7a3624aca 100644 --- a/projects/plugins/jetpack/modules/theme-tools/compat/twentyfifteen.css +++ b/projects/plugins/jetpack/modules/theme-tools/compat/twentyfifteen.css @@ -290,6 +290,7 @@ iframe[id*="twitter-widget-"] { .comment-subscription-form { font-size: 12px; font-size: 1.2rem; + /* stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values */ line-height: 1.5em; margin: 2em 0 0; } @@ -559,6 +560,7 @@ iframe[id*="twitter-widget-"] { .hentry div#jp-relatedposts div.jp-relatedposts-items p { font-size: 1.6rem; font-size: 16px; + /* stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values */ line-height: 1.5em; } @@ -779,6 +781,7 @@ iframe[id*="twitter-widget-"] { .hentry div#jp-relatedposts div.jp-relatedposts-items p { font-size: 16px; font-size: 1.6rem; + /* stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values */ line-height: 1.5em; } diff --git a/projects/plugins/jetpack/modules/theme-tools/compat/twentysixteen.css b/projects/plugins/jetpack/modules/theme-tools/compat/twentysixteen.css index 6fb07a69bb1d2..34c720678f1cd 100644 --- a/projects/plugins/jetpack/modules/theme-tools/compat/twentysixteen.css +++ b/projects/plugins/jetpack/modules/theme-tools/compat/twentysixteen.css @@ -742,6 +742,7 @@ iframe[src^="http://api.mixcloud.com/"] { } .widget_jetpack_display_posts_widget .jetpack-display-remote-posts p { + /* stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values */ line-height: 1.615384615em !important; margin: 0 0 1.615384615em !important; } diff --git a/projects/plugins/jetpack/scss/templates/_connection-landing.scss b/projects/plugins/jetpack/scss/templates/_connection-landing.scss index 96a5fa1ee6deb..83b4eba5dbc76 100644 --- a/projects/plugins/jetpack/scss/templates/_connection-landing.scss +++ b/projects/plugins/jetpack/scss/templates/_connection-landing.scss @@ -24,6 +24,7 @@ h1 { font-weight: 400; + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 1.75em; position: relative; z-index: 3; From 2db1de8067c0685970650c7d5d5afe708ab2df5c Mon Sep 17 00:00:00 2001 From: tbradsha <32492176+tbradsha@users.noreply.github.com> Date: Thu, 24 Apr 2025 13:20:23 -0600 Subject: [PATCH 07/25] Undisable declaration-property-unit-allowed-list --- tools/js-tools/stylelint.config.base.mjs | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/js-tools/stylelint.config.base.mjs b/tools/js-tools/stylelint.config.base.mjs index a6a4416d50a4b..7a4f80dfbcd54 100644 --- a/tools/js-tools/stylelint.config.base.mjs +++ b/tools/js-tools/stylelint.config.base.mjs @@ -54,7 +54,6 @@ const baseConfig = { ], // Disable all other rules for now. - 'declaration-property-unit-allowed-list': null, 'no-duplicate-selectors': null, 'scss/at-extend-no-missing-placeholder': null, 'scss/comment-no-empty': null, From bb6c05d370f9e1c7f59bd0ad20b861874fe7169c Mon Sep 17 00:00:00 2001 From: tbradsha <32492176+tbradsha@users.noreply.github.com> Date: Thu, 24 Apr 2025 13:55:52 -0600 Subject: [PATCH 08/25] Ignore purposely-blank file --- .stylelintignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.stylelintignore b/.stylelintignore index 20d61573efa1f..7a13fe68e4576 100644 --- a/.stylelintignore +++ b/.stylelintignore @@ -11,6 +11,7 @@ # Ignore CSS copied in from elsewhere projects/js-packages/components/components/boost-score-graph/style-uplot.scss +projects/packages/jetpack-mu-wpcom/src/features/custom-css/custom-css/css/blank.css projects/packages/jetpack-mu-wpcom/src/features/newspack-blocks/synced-newspack-blocks projects/plugins/crm/css/lib projects/plugins/crm/css/semantic-ui From ab5b571b128a139ed99794781f684aca2a54db9f Mon Sep 17 00:00:00 2001 From: tbradsha <32492176+tbradsha@users.noreply.github.com> Date: Thu, 24 Apr 2025 13:58:31 -0600 Subject: [PATCH 09/25] Undisable scss/comment-no-empty --- .../components/masthead/calypso-colors.scss | 24 ++++---- .../customberg/lib/wordpress-interface.scss | 27 +++------ .../components/record-meter/notice-box.scss | 2 - .../components/record-meter/style.scss | 2 - .../search/src/dashboard/scss/_variables.scss | 2 - .../src/dashboard/scss/calypso-colors.scss | 22 +++---- .../src/dashboard/scss/functions/rem.scss | 15 +++-- .../search/src/dashboard/scss/z-index.scss | 60 +++++++++---------- .../instant-search/components/search-app.scss | 2 - .../components/search-result.scss | 8 +-- .../instant-search/lib/styles/_mixins.scss | 2 - .../instant-search/lib/styles/_variables.scss | 2 - .../src/dashboard/scss/_variables.scss | 2 - .../src/dashboard/scss/calypso-colors.scss | 22 +++---- .../src/dashboard/scss/functions/rem.scss | 15 +++-- .../wordads/src/dashboard/scss/z-index.scss | 60 +++++++++---------- .../_inc/client/scss/calypso-colors.scss | 22 +++---- .../_inc/client/scss/functions/rem.scss | 14 ++--- .../client/scss/mixin_long-content-fade.scss | 12 ++-- .../scss/mixins/_long-content-fade.scss | 12 ++-- .../jetpack/_inc/client/scss/mixins/_rna.scss | 10 ++-- .../jetpack/_inc/client/scss/style.scss | 18 +++--- .../_inc/client/scss/variables/_colors.scss | 21 ++++--- .../jetpack/_inc/client/scss/z-index.scss | 60 +++++++++---------- .../blocks/ai-assistant/editor.scss | 3 +- .../extensions/blocks/slideshow/editor.scss | 26 ++++---- .../scss/_utilities/mixins/_breakpoint.scss | 27 +++++---- .../scss/atoms/icons/_automatticons.scss | 10 ++-- .../scss/atoms/typography/_functions.scss | 17 +++--- tools/js-tools/stylelint.config.base.mjs | 1 - 30 files changed, 254 insertions(+), 266 deletions(-) diff --git a/projects/packages/backup/src/js/components/masthead/calypso-colors.scss b/projects/packages/backup/src/js/components/masthead/calypso-colors.scss index 7237b4d44b54d..b6de2aab512ad 100644 --- a/projects/packages/backup/src/js/components/masthead/calypso-colors.scss +++ b/projects/packages/backup/src/js/components/masthead/calypso-colors.scss @@ -13,16 +13,18 @@ $light-gray-700: #c3c4c7; $gray-original: #87a6bc; $gray: desaturate( $gray-original, 100% ); // Intermediary transform to match dotcom's colors -// $gray color functions: -// -// lighten( $gray, 10% ) -// lighten( $gray, 20% ) -// lighten( $gray, 30% ) -// darken( $gray, 10% ) -// darken( $gray, 20% ) -// darken( $gray, 30% ) -// -// See wordpress.com/design-handbook/colors/ for more info. +/** + * $gray color functions: + * + * lighten( $gray, 10% ) + * lighten( $gray, 20% ) + * lighten( $gray, 30% ) + * darken( $gray, 10% ) + * darken( $gray, 20% ) + * darken( $gray, 30% ) + * + * See wordpress.com/design-handbook/colors/ for more info. + */ $gray-light: lighten( $gray, 33% ); //#f6f6f6 $gray-dark: darken( $gray, 38% ); //#404040 @@ -57,4 +59,4 @@ $link-highlight: tint($blue-medium, 20%); $white: rgba(255,255,255,1); $transparent: rgba(255,255,255,0); -$border-ultra-light-gray: #e8f0f5; \ No newline at end of file +$border-ultra-light-gray: #e8f0f5; diff --git a/projects/packages/search/src/customberg/lib/wordpress-interface.scss b/projects/packages/search/src/customberg/lib/wordpress-interface.scss index 9ed2d1958845f..28db81c89e100 100644 --- a/projects/packages/search/src/customberg/lib/wordpress-interface.scss +++ b/projects/packages/search/src/customberg/lib/wordpress-interface.scss @@ -1,11 +1,11 @@ -// These styles are copied directly from @wordpress/interface -// in order to remove our dependency on this experimental package. - -// TODO: Replace these styles with our own styles. - -// -// complementary-area-header -// +/** + * These styles are copied directly from @wordpress/interface + * in order to remove our dependency on this experimental package. + * + * TODO: Replace these styles with our own styles. + * + * complementary-area-header + */ .components-panel__header.interface-complementary-area-header__small { background: $white; padding-right: $grid-unit-05; @@ -27,9 +27,7 @@ padding-right: $grid-unit-05; } -// // complementary-area -// .interface-complementary-area { background: $white; color: $gray-900; @@ -98,9 +96,7 @@ } } -// // fullscreen-mode -// body.js.is-fullscreen-mode { @include break-medium { @@ -121,9 +117,8 @@ body.js.is-fullscreen-mode { } } -// // interface-skeleton -// + // On Mobile devices, swiping the HTML element should not scroll. // By making it fixed, we prevent that. html.interface-interface-skeleton__html-container { @@ -258,9 +253,7 @@ html.interface-interface-skeleton__html-container { } } -// // more-menu-dropdown -// .interface-more-menu-dropdown { margin-left: -4px; @@ -297,9 +290,7 @@ html.interface-interface-skeleton__html-container { z-index: z-index( '.components-popover.interface-more-menu__content' ); } -// // pinned-items -// .interface-pinned-items { display: flex; diff --git a/projects/packages/search/src/dashboard/components/record-meter/notice-box.scss b/projects/packages/search/src/dashboard/components/record-meter/notice-box.scss index 6ac6c6191fdf1..dd616dce2d754 100644 --- a/projects/packages/search/src/dashboard/components/record-meter/notice-box.scss +++ b/projects/packages/search/src/dashboard/components/record-meter/notice-box.scss @@ -1,6 +1,4 @@ -// // Variables -// @import '~@automattic/color-studio/dist/color-variables'; .jp-search-notice-box { diff --git a/projects/packages/search/src/dashboard/components/record-meter/style.scss b/projects/packages/search/src/dashboard/components/record-meter/style.scss index b732dee238378..ed0ed591246a4 100644 --- a/projects/packages/search/src/dashboard/components/record-meter/style.scss +++ b/projects/packages/search/src/dashboard/components/record-meter/style.scss @@ -1,6 +1,4 @@ -// // Variables -// @import '~@automattic/color-studio/dist/color-variables'; .jp-search-bar-chart__container { diff --git a/projects/packages/search/src/dashboard/scss/_variables.scss b/projects/packages/search/src/dashboard/scss/_variables.scss index 84617419333ae..702a6bd196968 100644 --- a/projects/packages/search/src/dashboard/scss/_variables.scss +++ b/projects/packages/search/src/dashboard/scss/_variables.scss @@ -1,6 +1,4 @@ -// // Variables -// @import 'node_modules/@automattic/color-studio/dist/color-variables'; /********* RNA styles *********/ diff --git a/projects/packages/search/src/dashboard/scss/calypso-colors.scss b/projects/packages/search/src/dashboard/scss/calypso-colors.scss index 63e23fcca8b79..b6de2aab512ad 100644 --- a/projects/packages/search/src/dashboard/scss/calypso-colors.scss +++ b/projects/packages/search/src/dashboard/scss/calypso-colors.scss @@ -13,16 +13,18 @@ $light-gray-700: #c3c4c7; $gray-original: #87a6bc; $gray: desaturate( $gray-original, 100% ); // Intermediary transform to match dotcom's colors -// $gray color functions: -// -// lighten( $gray, 10% ) -// lighten( $gray, 20% ) -// lighten( $gray, 30% ) -// darken( $gray, 10% ) -// darken( $gray, 20% ) -// darken( $gray, 30% ) -// -// See wordpress.com/design-handbook/colors/ for more info. +/** + * $gray color functions: + * + * lighten( $gray, 10% ) + * lighten( $gray, 20% ) + * lighten( $gray, 30% ) + * darken( $gray, 10% ) + * darken( $gray, 20% ) + * darken( $gray, 30% ) + * + * See wordpress.com/design-handbook/colors/ for more info. + */ $gray-light: lighten( $gray, 33% ); //#f6f6f6 $gray-dark: darken( $gray, 38% ); //#404040 diff --git a/projects/packages/search/src/dashboard/scss/functions/rem.scss b/projects/packages/search/src/dashboard/scss/functions/rem.scss index af0831b43a425..1b9a7c0461adf 100644 --- a/projects/packages/search/src/dashboard/scss/functions/rem.scss +++ b/projects/packages/search/src/dashboard/scss/functions/rem.scss @@ -1,11 +1,10 @@ - -// ====================================================================== -// Rem function -// -// Convert px to rem in a readable fashion. -// -// Example: font-size: rem( 21px ); -// ====================================================================== +/** + * Rem function + * + * Convert px to rem in a readable fashion. + * + * Example: font-size: rem( 21px ); + */ @use "sass:math"; diff --git a/projects/packages/search/src/dashboard/scss/z-index.scss b/projects/packages/search/src/dashboard/scss/z-index.scss index ed753aef2c8ec..dc616ba184bba 100644 --- a/projects/packages/search/src/dashboard/scss/z-index.scss +++ b/projects/packages/search/src/dashboard/scss/z-index.scss @@ -1,33 +1,33 @@ -// ========================================================================== -// A nested map of all of our z-index values. -// -// Please add new values relative to their parent stacking context. For -// example the values of 'root' are elements with a stacking context that have no -// parents with a stacking context, other than the default html root. -// -// A Stacking Context is created when: -// 1. It's the root element (HTML) -// 2. Has a position other than static, with a z-index value -// 3. position:fixed -// 4. Has one of the following css properties: (transform, opacity<1, mix-blend-mode, filter) -// 5. isolation:isolate -// 6: -webkit-overflow-scrolling: touch -// -// So before adding a new z-index: -// 1. You'll want to make sure the element actually creates a stacking context -// 2. Look up what its parent stacking context is -// You can run this handy gist: https://gist.github.com/gwwar/2f661deec7b99a1a418b in the console to find both. -// -// For readability please sort values from lowest to highest. -// -// Usage: -// .environment-badge { -// z-index: z-index( 'root' '.environment-badge' ); -// } -// -// For a refresher on stacking contexts see: -// https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Positioning/Understanding_z_index/The_stacking_context -// ========================================================================== +/** + * A nested map of all of our z-index values. + * + * Please add new values relative to their parent stacking context. For + * example the values of 'root' are elements with a stacking context that have no + * parents with a stacking context, other than the default html root. + * + * A Stacking Context is created when: + * 1. It's the root element (HTML) + * 2. Has a position other than static, with a z-index value + * 3. position:fixed + * 4. Has one of the following css properties: (transform, opacity<1, mix-blend-mode, filter) + * 5. isolation:isolate + * 6: -webkit-overflow-scrolling: touch + * + * So before adding a new z-index: + * 1. You'll want to make sure the element actually creates a stacking context + * 2. Look up what its parent stacking context is + * You can run this handy gist: https://gist.github.com/gwwar/2f661deec7b99a1a418b in the console to find both. + * + * For readability please sort values from lowest to highest. + * + * Usage: + * .environment-badge { + * z-index: z-index( 'root' '.environment-badge' ); + * } + * + * For a refresher on stacking contexts see: + * https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Positioning/Understanding_z_index/The_stacking_context + */ $z-layers: ( 'root': ( diff --git a/projects/packages/search/src/instant-search/components/search-app.scss b/projects/packages/search/src/instant-search/components/search-app.scss index e1506a66519fb..9fefd9c669426 100644 --- a/projects/packages/search/src/instant-search/components/search-app.scss +++ b/projects/packages/search/src/instant-search/components/search-app.scss @@ -42,9 +42,7 @@ body.enable-search-modal .cover-modal.show-modal.search-modal.active { word-wrap: normal !important; } -// // Dark theme styling -// .jetpack-instant-search__overlay.jetpack-instant-search__overlay--dark { background: $color-dark-modal-backdrop-background; color: $color-dark-text; diff --git a/projects/packages/search/src/instant-search/components/search-result.scss b/projects/packages/search/src/instant-search/components/search-result.scss index 189dd859cd508..c650307946a97 100644 --- a/projects/packages/search/src/instant-search/components/search-result.scss +++ b/projects/packages/search/src/instant-search/components/search-result.scss @@ -1,9 +1,9 @@ @import '../lib/styles/helper'; -// -// Only add styles here that should be shared across different result types (minimal, expanded, product). -// NOTE: Due to Webpack import order, these styles will apply AFTER minimal/expanded/product styles. -// +/** + * Only add styles here that should be shared across different result types (minimal, expanded, product). + * NOTE: Due to Webpack import order, these styles will apply AFTER minimal/expanded/product styles. + */ .jetpack-instant-search__search-result { margin: 0 0 2em; } diff --git a/projects/packages/search/src/instant-search/lib/styles/_mixins.scss b/projects/packages/search/src/instant-search/lib/styles/_mixins.scss index ba1232bb09432..2cb666c665f32 100644 --- a/projects/packages/search/src/instant-search/lib/styles/_mixins.scss +++ b/projects/packages/search/src/instant-search/lib/styles/_mixins.scss @@ -1,8 +1,6 @@ @import './variables'; -// // Mixins -// // @breakpoint is a string prefixed with < or > followed by a breakpoint size. // (e.g. ">sm" or " Date: Thu, 24 Apr 2025 14:36:50 -0600 Subject: [PATCH 10/25] Fix no-duplicate-selectors in CRM --- .../crm/css/welcome-to-zbs/wizard.scss | 32 +-- .../portal/sass/jpcrm-public-portal.scss | 266 +++++++----------- .../crm/sass/ZeroBSCRM.admin.email.scss | 41 +-- .../sass/ZeroBSCRM.admin.extensions-page.scss | 5 +- .../sass/ZeroBSCRM.admin.invoicebuilder.scss | 46 ++- .../sass/ZeroBSCRM.admin.invoicepreview.scss | 39 +-- .../crm/sass/ZeroBSCRM.admin.singleview.scss | 28 +- .../crm/sass/_ZeroBSCRM.prevadmincore.scss | 47 +--- .../crm/sass/_daterangepicker.dirty.fix.scss | 9 +- .../plugins/crm/sass/jpcrm-admin-tasks.scss | 19 +- 10 files changed, 182 insertions(+), 350 deletions(-) diff --git a/projects/plugins/crm/css/welcome-to-zbs/wizard.scss b/projects/plugins/crm/css/welcome-to-zbs/wizard.scss index f5e0691aa3364..4ac16fe9d92e7 100644 --- a/projects/plugins/crm/css/welcome-to-zbs/wizard.scss +++ b/projects/plugins/crm/css/welcome-to-zbs/wizard.scss @@ -62,6 +62,7 @@ body { display: table-cell; text-align: center; position: relative; + width:25%; } .btn-circle { @@ -114,18 +115,14 @@ body { #zbs_other_details{ display:none; + height:150px; + margin-bottom:20px; } .setup-content textarea{ width:90%; } -.setup-content select{ - width:90%; - height:30px !important; - line-height:30px !important; -} - input[type="checkbox"], input[type="radio"]{ width:20px; } @@ -145,16 +142,6 @@ input[type="checkbox"], input[type="radio"]{ color: #fff; } -#zbs_other_details{ - height:150px; - margin-bottom:20px; -} - - -/* WAS A BUNCH OF HTML HERE?! */ - - - /* Layout */ .ck_form.ck_minimal { @@ -339,11 +326,9 @@ input[type="checkbox"], input[type="radio"]{ } .setup-content h3 { - font-size: 22px; - margin-top: 22px; margin-bottom: 26px; - + margin-top:10px !important; } .setup-content select { @@ -502,15 +487,6 @@ $darkenColor: darken($activeColor, 20%); } } - -.setup-content h3 { - margin-top:10px !important; -} - -.stepwizard-step { - width:25%; -} - .wizopt { margin-bottom: 24px; } diff --git a/projects/plugins/crm/modules/portal/sass/jpcrm-public-portal.scss b/projects/plugins/crm/modules/portal/sass/jpcrm-public-portal.scss index b4eef8a15ebcd..0ae76934299fb 100644 --- a/projects/plugins/crm/modules/portal/sass/jpcrm-public-portal.scss +++ b/projects/plugins/crm/modules/portal/sass/jpcrm-public-portal.scss @@ -12,34 +12,53 @@ // Import JS CSS vars @import '../../../sass/emerald/jp_vars'; - -// 17/10/19 - started to clean up this file as was a bit of a mess. ¯\_(ツ)_/¯ -// had lost it's scss virtues, partly now restored - .zbs-client-portal-wrap { position: relative; min-height:650px !important; + display: flex; #zbs-nav-tabs { list-style-type: none; width: 30%; float: left; - padding-left: 20px; min-height:650px; + margin: 0; + padding-left:0; + box-shadow: 0 1px 0 1px #ccc; + border-radius: 7px 0 0 7px; + padding-top:7px; + flex: 1; + + li { + list-style: none; + position: relative; + padding:0; + + a { + display: block; + padding:10px; + box-shadow:none; + } + + a:hover{ + box-shadow:none; + background: #000; + color: #fff; + } + } - li { - list-style: none; - // wh not a fan border-bottom: 1px solid rgba(0, 0, 0, 0.05); - position: relative; - padding: 5px; - } + a{ + color: #ccc; + } - li a { - padding: .875em 0; - display: block; - } + a:hover{ + color:#ccc !important; + } + .fa{ + margin-right: 0.5em; + } } #zbs_invoice_logos img { @@ -74,6 +93,16 @@ margin-left: auto; margin-right: auto; } + + .zbs-portal-wrapper{ + padding:20px; + box-shadow: 1px 1px 1px 1px #ccc; + border-radius: 0 7px 7px 0; + min-height:650px !important; + position:relative; + flex: 1; + flex-grow: 3; + } } .zbs-client-portal-pro-note { @@ -122,16 +151,71 @@ } .zbs-portal-wrapper { - padding-left: 20px; - padding-right: 20px; - float: right; - width: 70%; - box-sizing: border-box !important; + padding-left: 20px; + padding-right: 20px; + float: right; + width: 70%; + box-sizing: border-box !important; + + h1 { + margin-top: 0; + } - h1 { - margin-top: 0; - } + .zbs-field-checkbox-wrap { + // overall padding margin: 0.5em 1em 1em; + .zbs-cf-checkbox { + margin-top: 0; + margin-bottom: 0; + } + .zbs-cf-checkbox label { + padding: 0 0 0 23px !important; + } + + .zbs-cf-checkbox:first-of-type { + padding-left:0 !important; + } + + .zbs-cf-checkbox label, .zbs-cf-checkbox+label { + font-size: 16px !important; + font-weight: 400; + } + } + // edit pages radio custom fields + .zbs-field-radio-wrap { + // overall padding margin: 0.5em 1em 1em; + text-align:left; + + .zbs-radio { + margin: 0; + padding: 0; + -webkit-backface-visibility: hidden; + backface-visibility: hidden; + outline: none; + vertical-align: baseline; + font-style: normal; + min-height: 17px; + line-height: 17px; + min-width: 17px; + // good if these match the above checkbox labels ^^ label { + font-size: 16px !important; + font-weight: 400; + } + } + + /* Few tweaks as provided by Alvaro in slack ... wh selectively added those which made sense for multi-theme userbase JIRA-ZBS-531 */ + .zbs-portal-login .login-form input[type="text"], .zbs-portal-login .login-form input[type="password"], .form-control.widetext, .form-control.zbs-tel, .form-control.zbs-email, .form-control.zbs-date, input[type="text"], input[type="password"], input[type="tel"], input[type="email"], input.text, input.title, textarea, select { + padding-left: 1em; + padding-right: 1em; + margin-bottom: 1em; + width: 100%; + height:50px; + } + + /* Fixes for Astra Theme and general poor display on WP.org themes */ + label{ + clear: left; + } } .zbs-portal-wrapper-sin { @@ -346,11 +430,6 @@ } -.zbs-client-portal-wrap #zbs_invoice_logos img { - max-width: 50%; - max-height: 100px; -} - .zbs-fieldgroup-main_address, .zbs-fieldgroup-second_address{ width: 48%; float: left; @@ -384,83 +463,6 @@ margin-top:2em } -/* Few tweaks as provided by Alvaro in slack ... wh selectively added those which made sense for multi-theme userbase JIRA-ZBS-531 */ -.zbs-portal-wrapper { - - .zbs-portal-login .login-form input[type="text"], .zbs-portal-login .login-form input[type="password"], .form-control.widetext, .form-control.zbs-tel, .form-control.zbs-email, .form-control.zbs-date, input[type="text"], input[type="password"], input[type="tel"], input[type="email"], input.text, input.title, textarea, select { - padding-left: 1em; - padding-right: 1em; - margin-bottom: 1em; - width: 100%; - height:50px; - } -} - -/* Fixes for Astra Theme and general poor display on WP.org themes */ -.zbs-portal-wrapper{ - - label{ - clear: left; - } -} - -/* WH added for Your details page additions of checkbox radio buttons 2.98.5 */ -// edit pages checkbox custom fields -.zbs-portal-wrapper { - - .zbs-field-checkbox-wrap { - // overall padding margin: 0.5em 1em 1em; - .zbs-cf-checkbox { - margin-top: 0; - margin-bottom: 0; - } - - .zbs-cf-checkbox label { - padding: 0 0 0 23px !important; - } - - .zbs-cf-checkbox:first-of-type { - padding-left:0 !important; - } - - .zbs-cf-checkbox label, .zbs-cf-checkbox+label { - font-size: 16px !important; - font-weight: 400; - } - } - // edit pages radio custom fields - .zbs-field-radio-wrap { - // overall padding margin: 0.5em 1em 1em; - text-align:left; - - .zbs-radio:first-of-type { - //padding-left:0 !important; - } - - .zbs-radio { - // cloned from ui checkbox 12/3/19 border: none; - margin: 0; - padding: 0; - //padding-left: 20px; - //margin-top: 10px; - //margin-bottom: 10px; - //position: relative; - //display: inline-block; - -webkit-backface-visibility: hidden; - backface-visibility: hidden; - outline: none; - vertical-align: baseline; - font-style: normal; - min-height: 17px; - line-height: 17px; - min-width: 17px; - // good if these match the above checkbox labels ^^ label { - font-size: 16px !important; - font-weight: 400; - } - } -} - //hide the title from the Portal Page .entry-title{ display:none !important; @@ -469,56 +471,6 @@ .fullW{ width: 100% !important; } -//newer styles -.zbs-client-portal-wrap{ - display: flex; - - .zbs-portal-wrapper{ - padding:20px; - box-shadow: 1px 1px 1px 1px #ccc; - border-radius: 0 7px 7px 0; - min-height:650px !important; - position:relative; - flex: 1; - flex-grow: 3; - } - - #zbs-nav-tabs{ - margin: 0; - padding-left:0; - box-shadow: 0 1px 0 1px #ccc; - border-radius: 7px 0 0 7px; - padding-top:7px; - flex: 1; - - li{ - padding:0; - - a{ - padding:10px; - box-shadow:none; - } - - a:hover{ - box-shadow:none; - background: #000; - color: #fff; - } - } - - a{ - color: #ccc; - } - - a:hover{ - color:#ccc !important; - } - - .fa{ - margin-right: 0.5em; - } - } -} .zbs-line-info-title { font-size: 30px; @@ -585,14 +537,10 @@ td::before { position: absolute; - top: 6px; left: 6px; width: 45%; padding-right: 10px; white-space: nowrap; - } - - td::before { content: attr(data-title); top: 50%; transform: translateY(-50%); diff --git a/projects/plugins/crm/sass/ZeroBSCRM.admin.email.scss b/projects/plugins/crm/sass/ZeroBSCRM.admin.email.scss index 9e9e9c8fbe177..a405c9439334f 100644 --- a/projects/plugins/crm/sass/ZeroBSCRM.admin.email.scss +++ b/projects/plugins/crm/sass/ZeroBSCRM.admin.email.scss @@ -97,6 +97,8 @@ html,body{ padding-top: 10px !important; padding-bottom: 10px; position:relative; + border-top: 0 solid #fff !important; + border-bottom: 1px solid #dededf; } .zbs-email-list .item { @@ -122,8 +124,12 @@ html,body{ } .zbs-contact{ - width: 100%; - height: 30px; + width: 100%; + height: 30px; + + .zbs-open{ + float:right; + } } .the_content{ @@ -169,6 +175,7 @@ html,body{ .spinner-gif{ display:none; + margin-top:-55px; } .click-email-to-load{ @@ -177,11 +184,6 @@ html,body{ margin-top:-50px; } -.zbs-email-list-item{ - border-top: 0 solid #fff !important; - border-bottom: 1px solid #dededf; -} - .zbs-click-email-icon{ font-size: 10px; font-weight: 100; @@ -193,10 +195,6 @@ html,body{ margin-top:-10px; } -.spinner-gif{ - margin-top:-55px; -} - .zbs-email-list::-webkit-scrollbar, #zbs-email-body::-webkit-scrollbar{ width: 0; /* remove scrollbar space */ background: transparent; /* optional: just make scrollbar invisible */ @@ -343,6 +341,7 @@ font-weight:300; color: #000; margin-top:0; font-weight:900; + display:none; } .zbs-email-body-content{ @@ -381,13 +380,10 @@ font-weight:300; cursor:pointer; } } -} - -.zbs-contact{ - .zbs-open{ - float:right; - } + .em-sub-0{ + display:block; + } } .zbs-email-thread{ @@ -501,17 +497,6 @@ font-weight:300; } } -#zbs-email-body{ - - .zbs-email-subject{ - display:none; - } - - .em-sub-0{ - display:block; - } -} - .zbs-email-body-content{ ul{ diff --git a/projects/plugins/crm/sass/ZeroBSCRM.admin.extensions-page.scss b/projects/plugins/crm/sass/ZeroBSCRM.admin.extensions-page.scss index 5564986a1ffbb..f9f3c2677bc86 100644 --- a/projects/plugins/crm/sass/ZeroBSCRM.admin.extensions-page.scss +++ b/projects/plugins/crm/sass/ZeroBSCRM.admin.extensions-page.scss @@ -59,6 +59,7 @@ .premium-box{ margin-top:10px !important; border-bottom: 0 !important; + height:52px; } .upgrade-bullie-box{ @@ -239,10 +240,6 @@ float:right; } - .premium-box{ - height:52px; - } - .actions-block{ float: right; padding: 10px; diff --git a/projects/plugins/crm/sass/ZeroBSCRM.admin.invoicebuilder.scss b/projects/plugins/crm/sass/ZeroBSCRM.admin.invoicebuilder.scss index e8ee82a7d0929..1aca300aba5cf 100644 --- a/projects/plugins/crm/sass/ZeroBSCRM.admin.invoicebuilder.scss +++ b/projects/plugins/crm/sass/ZeroBSCRM.admin.invoicebuilder.scss @@ -45,8 +45,8 @@ } #billing-to{ - //width:80% !important; width:90% !important; + float:left; .inv-to-form{ float: left; @@ -75,6 +75,12 @@ .wh-large select, .wh-large input, input.typeahead { max-width: 100%; } + + th{ + vertical-align:middle; + font-size:18px; + font-weight:100; + } } #zbs-add-new-row{ @@ -361,17 +367,6 @@ outline: 0 !important; } - #billing-to{ - width:50%; - float:left; - - th{ - vertical-align:middle; - font-size:18px; - font-weight:100; - } - } - #assign-to{ width:50%; float:right; @@ -564,6 +559,7 @@ .bord-l{ text-align:right; + border-left: 2px solid #ccc !important; } td.bord{ @@ -579,10 +575,6 @@ text-align:right; border-right: 2px solid #ccc !important; } - - .bord-l{ - border-left: 2px solid #ccc !important; - } } #zbs-invoice-items{ @@ -632,6 +624,11 @@ .zbs-row-actions{ cursor:pointer; + border: 1px solid #ccc; + color: #999; + font-size: 13px; + font-weight: 100; + text-align:center; } .padding{ @@ -683,14 +680,6 @@ .add-row{ border-left: 0 solid #fff; } - - .zbs-row-actions{ - border: 1px solid #ccc; - color: #999; - font-size: 13px; - font-weight: 100; - text-align:center; - } } #zbs_invoice_actions{ @@ -847,6 +836,9 @@ width:100%; position:relative; display:none; + margin-top: 20px; + margin-bottom: 20px; + margin-left: 12px; .zbs-remove, .zbs-update{ cursor:pointer; @@ -872,12 +864,6 @@ } } - .wh-logo-set{ - margin-top: 20px; - margin-bottom: 20px; - margin-left: 12px; - } - .wh-logo-set:hover{ .zbs-logo-options{ diff --git a/projects/plugins/crm/sass/ZeroBSCRM.admin.invoicepreview.scss b/projects/plugins/crm/sass/ZeroBSCRM.admin.invoicepreview.scss index 0b9c97ad2622e..2510268012319 100644 --- a/projects/plugins/crm/sass/ZeroBSCRM.admin.invoicepreview.scss +++ b/projects/plugins/crm/sass/ZeroBSCRM.admin.invoicepreview.scss @@ -33,6 +33,10 @@ font-size: 15px; font-weight: 100; text-align: right; + + .form-table { + float:right; + } } .container{ @@ -47,13 +51,6 @@ font-size: 13px; } - .zbs-invoice-topper{ - - .form-table{ - float:right; - } - } - #zbs-business-info-wrapper{ margin-top:-85px; } @@ -303,6 +300,7 @@ .bord-l{ text-align:right; + border-left: 2px solid #ccc !important; } td.bord{ @@ -317,10 +315,6 @@ text-align:right; border-right: 2px solid #ccc !important; } - - .bord-l{ - border-left: 2px solid #ccc !important; - } } #zbs-invoice-items{ @@ -363,6 +357,11 @@ .zbs-row-actions{ cursor:pointer; + border: 1px solid #ccc; + color: #999; + font-size: 13px; + font-weight: 100; + text-align:center; } .padding{ @@ -386,15 +385,6 @@ .bottom-row, .row-amount{ border-bottom: 1px solid #ccc; } - - - .zbs-row-actions{ - border: 1px solid #ccc; - color: #999; - font-size: 13px; - font-weight: 100; - text-align:center; - } } #zbs_invoice_actions{ @@ -538,6 +528,9 @@ width:100%; position:relative; display:none; + margin-top: 20px; + margin-bottom: 20px; + margin-left: 12px; .zbs-remove, .zbs-update{ cursor:pointer; @@ -556,12 +549,6 @@ } } - .wh-logo-set{ - margin-top: 20px; - margin-bottom: 20px; - margin-left: 12px; - } - .wh-logo-set:hover{ .zbs-logo-options{ diff --git a/projects/plugins/crm/sass/ZeroBSCRM.admin.singleview.scss b/projects/plugins/crm/sass/ZeroBSCRM.admin.singleview.scss index b27a444e84cd0..728499c6280c4 100644 --- a/projects/plugins/crm/sass/ZeroBSCRM.admin.singleview.scss +++ b/projects/plugins/crm/sass/ZeroBSCRM.admin.singleview.scss @@ -60,12 +60,12 @@ } .zbs-sentence { - - font-size: 1.1em; - color: #5d4949; - padding-left: 2em; - padding-top: 0.2em; - padding-bottom: 0.2em; + padding-top: 0.2em; + padding-bottom: 0.2em; + padding-left:0; + color: #000; + margin-top:5px; + font-size:14px; } // NOTE this is also in contact edit metabox! copy any changes if made: @@ -227,15 +227,9 @@ font-size:14px; display:none !important; } -.zbs-view-card .zbs-sentence{ -padding-left:0; -color: #000; -margin-top:5px; -font-size:14px; -} - .zbs-sentence{ -line-height: 21px; + line-height: 21px; + width:80%; } .zbs-contact-owner{ @@ -262,12 +256,6 @@ margin-top:10px !important; margin-right:10px !important; } -.zbs-sentence{ -width:80%; -} - - - // === Pinned notes #jpcrm-pinned-logs-header { margin-top: 0; diff --git a/projects/plugins/crm/sass/_ZeroBSCRM.prevadmincore.scss b/projects/plugins/crm/sass/_ZeroBSCRM.prevadmincore.scss index 4bf8e5d761252..69b96916f0fa7 100644 --- a/projects/plugins/crm/sass/_ZeroBSCRM.prevadmincore.scss +++ b/projects/plugins/crm/sass/_ZeroBSCRM.prevadmincore.scss @@ -135,7 +135,9 @@ input { input[type="checkbox"],input[type="radio"] { box-sizing:border-box; - padding:0 + padding:0; + margin:4px 0 0; + line-height:normal; } input[type="number"]::-webkit-inner-spin-button,input[type="number"]::-webkit-outer-spin-button { @@ -143,7 +145,8 @@ input[type="number"]::-webkit-inner-spin-button,input[type="number"]::-webkit-ou } input[type="search"] { - -webkit-appearance:textfield + -webkit-appearance:textfield; + box-sizing:border-box; } input[type="search"]::-webkit-search-cancel-button,input[type="search"]::-webkit-search-decoration { @@ -160,7 +163,9 @@ optgroup { table { border-collapse:collapse; - border-spacing:0 + border-spacing:0; + max-width:100%; + background-color:transparent; } td,th { @@ -556,11 +561,6 @@ address { line-height:1.42857 } -table { - max-width:100%; - background-color:transparent -} - th { text-align:left } @@ -728,15 +728,6 @@ label { font-weight:700 } -input[type="search"] { - box-sizing:border-box -} - -input[type="checkbox"],input[type="radio"] { - margin:4px 0 0; - line-height:normal -} - input[type="file"] { display:block } @@ -4025,7 +4016,7 @@ table [class*="span"],.row-fluid table [class*="span"] { outline-offset: -2px; } -#ZeroBSCRMAdminPage .btn.active,#ZeroBSCRMAdminPage .btn:active { +#ZeroBSCRMAdminPage .btn.active { background-color: #d9d9d9 \9; background-image: none; outline: 0; @@ -4281,11 +4272,11 @@ input[type="submit"]#ZeroBSCRMAdminPage .btn-block,input[type="reset"]#ZeroBSCRM cursor: pointer; } -#ZeroBSCRMAdminPage .clearfix,#ZeroBSCRMAdminPage .clearfix { +#ZeroBSCRMAdminPage .clearfix { zoom: 1; } -#ZeroBSCRMAdminPage .clearfix::after,#ZeroBSCRMAdminPage .clearfix::after { +#ZeroBSCRMAdminPage .clearfix::after { clear: both; } @@ -4317,6 +4308,7 @@ th.column-ID { #sbSubPage { max-width: 800px; + margin-top:18px; } @@ -4330,6 +4322,7 @@ th.column-ID { background: #FFF; border-radius: 10px; margin-bottom:10px; + font-size:18px; } .sbhomep.imp { @@ -4460,20 +4453,11 @@ th.column-ID { height: 54px; } -.whide { - display: none; -} - /* style tweaks 26/11 */ #sbDesc { padding: 18px 10px 0 10px; } -#sbSubPage { - margin-top:18px; -} - - .whclpActionMsg, .lle580 { background:#FFF; text-align:center; @@ -4592,11 +4576,6 @@ th.column-ID { } - -.sbhomep { - font-size:18px; -} - // for small column metaboxes .wh-metatab-side { diff --git a/projects/plugins/crm/sass/_daterangepicker.dirty.fix.scss b/projects/plugins/crm/sass/_daterangepicker.dirty.fix.scss index dffec6eb176b1..94b0b26a7815d 100644 --- a/projects/plugins/crm/sass/_daterangepicker.dirty.fix.scss +++ b/projects/plugins/crm/sass/_daterangepicker.dirty.fix.scss @@ -20,18 +20,15 @@ table { border-collapse:collapse; - border-spacing:0 + border-spacing:0; + max-width:100%; + background-color:transparent; } td,th { padding:0 } -table { - max-width:100%; - background-color:transparent -} - th { text-align:left } diff --git a/projects/plugins/crm/sass/jpcrm-admin-tasks.scss b/projects/plugins/crm/sass/jpcrm-admin-tasks.scss index 076d55d0d6cfa..ced9e18cb6ef2 100644 --- a/projects/plugins/crm/sass/jpcrm-admin-tasks.scss +++ b/projects/plugins/crm/sass/jpcrm-admin-tasks.scss @@ -67,11 +67,6 @@ background: #edf8ff !important; } -.fc-event{ - background: #fff; - border: 1px solid #ddd; -} - .fc-content{ color: #000; } @@ -210,6 +205,10 @@ background: #fff; .no-owner{ float: left; + position: relative; + border: 1px solid #ccc; + border-radius: 0.2em; + z-index: 0; } .no-task-date{ @@ -274,21 +273,11 @@ background: #fff; border: 0; } - - .select2-container--default .select2-selection--single{ border: 0 solid !important; font-size:20px; } -.no-owner{ - position: relative; - border: 1px solid #ccc; - border-radius: 0.2em; - z-index: 0; -} - - .task-comp{ width: 19%; float: right; From 068aa64a7227705d47e8385d5f03bbf99b577c7b Mon Sep 17 00:00:00 2001 From: tbradsha <32492176+tbradsha@users.noreply.github.com> Date: Fri, 25 Apr 2025 11:43:06 -0600 Subject: [PATCH 11/25] Undisable no-duplicate-selectors --- .../components/dot-pager/style.scss | 20 +++--- .../components/icon-tooltip/style.scss | 19 +++--- .../components/icons/style.module.scss | 4 -- .../styles.module.scss | 4 -- .../components/disconnect-dialog/style.scss | 27 ++++---- .../src/components/social-previews/modal.scss | 15 ++--- .../src/css/strength-meter.css | 3 - .../src/social-menu/social-menu.css | 4 +- .../forms/src/blocks/contact-form/editor.scss | 1 + .../css/editor-inline-editing-style.css | 4 -- .../forms/src/contact-form/css/file-field.css | 5 +- .../forms/src/contact-form/css/grunion.css | 1 + .../forms/src/dashboard/inbox/style.scss | 43 +++++-------- .../src/components/FrequencyToggle/style.scss | 40 ++++++------ .../wpcom-admin-bar/wpcom-admin-bar.scss | 1 + .../wpcom-hotfixes/colors/modern/colors.css | 1 - .../jitm/src/css/jetpack-admin-jitm.scss | 6 +- .../admin-color-schemes/colors/_admin.scss | 1 - .../colors/_overrides.scss | 52 ++++++--------- .../masterbar/src/admin-menu/admin-menu.css | 8 +-- .../components/onboarding-tour/styles.scss | 11 ++-- .../dashboard/components/notice/style.scss | 15 ++--- .../components/record-meter/notice-box.scss | 1 - .../components/search-result-expanded.scss | 5 -- .../components/video-card/style.module.scss | 3 +- .../dashboard/components/notice/style.scss | 15 ++--- .../connection-card/styles.module.scss | 38 +---------- .../plugins/inspect/app-ui/css/style.scss | 3 - .../_inc/client/at-a-glance/style.scss | 5 +- .../client/components/dash-item/style.scss | 36 ++++------- .../_inc/client/components/notice/style.scss | 15 ++--- .../client/components/section-nav/style.scss | 15 ++--- .../components/settings-group/style.scss | 7 +-- .../client/components/text-input/style.scss | 40 +++++------- .../components/tree-dropdown/style.scss | 3 - .../jetpack/_inc/client/my-plan/style.scss | 4 -- .../extensions/blocks/goodreads/style.scss | 8 --- .../extensions/blocks/image-compare/view.scss | 34 +++------- .../extensions/blocks/like/editor.scss | 15 ++--- .../jetpack/extensions/blocks/map/editor.scss | 5 +- .../extensions/blocks/rating-star/editor.scss | 6 +- .../extensions/blocks/rating-star/style.scss | 12 +--- .../blocks/simple-payments/editor.scss | 3 - .../shared/components/audio-player/style.scss | 3 - .../modules/carousel/jetpack-carousel.css | 3 - .../modules/infinite-scroll/infinity.css | 14 ++--- .../jetpack/modules/sharedaddy/sharing.css | 10 +-- .../jetpack/modules/shortcodes/css/style.css | 5 +- .../theme-tools/compat/twentyfourteen.css | 7 --- .../theme-tools/social-menu/social-menu.css | 4 +- .../widget-conditions/widget-conditions.css | 4 -- .../modules/widgets/milestone/style-admin.css | 13 +--- .../social-icons/social-icons-admin.css | 5 +- .../plugins/jetpack/scss/templates/_main.scss | 18 ++---- .../plugins/jetpack/scss/wordads-ccpa.scss | 26 ++------ .../threats-list/styles.module.scss | 23 +++---- projects/plugins/vaultpress/nav-styles.css | 5 +- .../custom-colors/css/colors-control.css | 59 +++++------------ .../css/rtl/colors-control-rtl.css | 63 +++++-------------- tools/js-tools/stylelint.config.base.mjs | 1 - 60 files changed, 233 insertions(+), 588 deletions(-) diff --git a/projects/js-packages/components/components/dot-pager/style.scss b/projects/js-packages/components/components/dot-pager/style.scss index 399f85627eff6..a204e2bd6aa16 100644 --- a/projects/js-packages/components/components/dot-pager/style.scss +++ b/projects/js-packages/components/components/dot-pager/style.scss @@ -50,6 +50,11 @@ .dot-pager__control-choose-page { cursor: pointer; + border-radius: 50%; + width: 6px; + height: 6px; + padding: 0; + background-color: var(--jp-white-off); &:disabled { cursor: default; @@ -58,14 +63,6 @@ &:focus-visible { box-shadow: 0 0 0 2px var(--jp-gray-90); } -} - -.dot-pager__control-choose-page { - border-radius: 50%; - width: 6px; - height: 6px; - padding: 0; - background-color: var(--jp-white-off); &:hover { background-color: var(--jp-gray-20); @@ -76,9 +73,6 @@ } } -.dot-pager { - - &__button { - margin-right: 10px; - } +.dot-pager__button { + margin-right: 10px; } diff --git a/projects/js-packages/components/components/icon-tooltip/style.scss b/projects/js-packages/components/components/icon-tooltip/style.scss index 7d282a06b7862..6dae76669a986 100644 --- a/projects/js-packages/components/components/icon-tooltip/style.scss +++ b/projects/js-packages/components/components/icon-tooltip/style.scss @@ -9,6 +9,14 @@ $arrow-color: var( --jp-gray ); // Namespace to avoid overriding global styles .icon-tooltip-helper { + // POPOVER_HELPER_WIDTH + width: 124px; + height: 18px; + position: absolute; + top: 0; + // -( POPOVER_HELPER_WIDTH / 2 - iconSize / 2 ) + 'px' + left: -53px; + pointer-events: none; /* * Fix arrow placement - section start @@ -71,17 +79,6 @@ $arrow-color: var( --jp-gray ); } } -.icon-tooltip-helper { - // POPOVER_HELPER_WIDTH - width: 124px; - height: 18px; - position: absolute; - top: 0; - // -( POPOVER_HELPER_WIDTH / 2 - iconSize / 2 ) + 'px' - left: -53px; - pointer-events: none; -} - .icon-tooltip-container { // Recover events pointer-events: all; diff --git a/projects/js-packages/components/components/icons/style.module.scss b/projects/js-packages/components/components/icons/style.module.scss index ccf61382e28aa..db4ba603fbbd6 100644 --- a/projects/js-packages/components/components/icons/style.module.scss +++ b/projects/js-packages/components/components/icons/style.module.scss @@ -24,10 +24,6 @@ } } - &.instagram { - fill: var( --color-instagram ); - } - &.twitter { fill: var( --color-twitter ); } diff --git a/projects/js-packages/connection/components/connection-error-notice/styles.module.scss b/projects/js-packages/connection/components/connection-error-notice/styles.module.scss index 705b2eb03de0c..45e463c239e42 100644 --- a/projects/js-packages/connection/components/connection-error-notice/styles.module.scss +++ b/projects/js-packages/connection/components/connection-error-notice/styles.module.scss @@ -76,10 +76,6 @@ margin-bottom: 25px; } -.error { - margin-bottom: 25px; -} - .message { margin-right: var( --spacing-base ); // 8px flex-grow: 1; diff --git a/projects/js-packages/connection/components/disconnect-dialog/style.scss b/projects/js-packages/connection/components/disconnect-dialog/style.scss index d34e7f8304a38..aa1ffb91b77da 100644 --- a/projects/js-packages/connection/components/disconnect-dialog/style.scss +++ b/projects/js-packages/connection/components/disconnect-dialog/style.scss @@ -79,19 +79,6 @@ width: calc(100% - 48px); // Help with the margin on the row. } - &__content{ - background: var( --jp-white-off ); - margin: 0; - padding: 2rem 1rem; - border-radius: 4px; - text-align: center; - flex-grow: 1; - display: flex; - flex-direction: column; - justify-content: center; - align-items: center; - } - &__actions{ background: var( --jp-white ); padding: 2rem 0; @@ -157,9 +144,19 @@ } } -// When the screen height is shorter, hide the decorative cards to show the text and controls without scrolling. .jp-connection__disconnect-dialog__content { - + background: var( --jp-white-off ); + margin: 0; + padding: 2rem 1rem; + border-radius: 4px; + text-align: center; + flex-grow: 1; + display: flex; + flex-direction: column; + justify-content: center; + align-items: center; + + // When the screen height is shorter, hide the decorative cards to show the text and controls without scrolling. @media (max-height: 900px) { .jp-components__decorative-card { diff --git a/projects/js-packages/publicize-components/src/components/social-previews/modal.scss b/projects/js-packages/publicize-components/src/components/social-previews/modal.scss index c6f8331c24140..813d3084b0ea8 100644 --- a/projects/js-packages/publicize-components/src/components/social-previews/modal.scss +++ b/projects/js-packages/publicize-components/src/components/social-previews/modal.scss @@ -78,6 +78,11 @@ display: flex; justify-content: center; } + + // Mastodon + .mastodon-preview { + max-width: 578px; + } } @media ( min-width: $break-small ) { @@ -100,19 +105,9 @@ } // Facebook - .facebook-preview { width: 100%; } - - // Mastodon - - .components-tab-panel__tab-content { - - .mastodon-preview { - max-width: 578px; - } - } } // Modal containing the upgrade nudge diff --git a/projects/packages/account-protection/src/css/strength-meter.css b/projects/packages/account-protection/src/css/strength-meter.css index 6651ebf967571..937ec7f7fb5d9 100644 --- a/projects/packages/account-protection/src/css/strength-meter.css +++ b/projects/packages/account-protection/src/css/strength-meter.css @@ -113,9 +113,6 @@ display: flex; align-items: center; gap: 4px; -} - -.branding { .powered-by { font-size: 12px; diff --git a/projects/packages/classic-theme-helper/src/social-menu/social-menu.css b/projects/packages/classic-theme-helper/src/social-menu/social-menu.css index 610ec77e4daad..43b59e599730b 100644 --- a/projects/packages/classic-theme-helper/src/social-menu/social-menu.css +++ b/projects/packages/classic-theme-helper/src/social-menu/social-menu.css @@ -48,10 +48,8 @@ Genericons text-decoration: inherit; vertical-align: top; width: 1em; -} -/* Default */ -.jetpack-social-navigation-genericons a::before { + /* Default */ content: "\f415"; } diff --git a/projects/packages/forms/src/blocks/contact-form/editor.scss b/projects/packages/forms/src/blocks/contact-form/editor.scss index 007ef2565d12f..ceaaf8f5251cb 100644 --- a/projects/packages/forms/src/blocks/contact-form/editor.scss +++ b/projects/packages/forms/src/blocks/contact-form/editor.scss @@ -777,6 +777,7 @@ // For some reason, when keeping the rule below together with the above selector, // on production builds, the attributes are being reordered, causing side-effects + // stylelint-disable-next-line no-duplicate-selectors .notched-label__notch { border-left: none; border-right: none; diff --git a/projects/packages/forms/src/contact-form/css/editor-inline-editing-style.css b/projects/packages/forms/src/contact-form/css/editor-inline-editing-style.css index 658bbc04ffd88..0d584d03d3dd4 100644 --- a/projects/packages/forms/src/contact-form/css/editor-inline-editing-style.css +++ b/projects/packages/forms/src/contact-form/css/editor-inline-editing-style.css @@ -622,10 +622,6 @@ input[type="submit"].button-primary:disabled { color: #fff; } -input[type="submit"].button-primary { - color: #fff; -} - /* ========================================================================== ** Inline editor styles diff --git a/projects/packages/forms/src/contact-form/css/file-field.css b/projects/packages/forms/src/contact-form/css/file-field.css index 8c38b6da99ee7..3a29f9bcb5a3a 100644 --- a/projects/packages/forms/src/contact-form/css/file-field.css +++ b/projects/packages/forms/src/contact-form/css/file-field.css @@ -265,16 +265,13 @@ .jetpack-form-file-field__success { color: #008A20; + display: none; } .jetpack-form-file-field__error { color: #b32d2e; } -.jetpack-form-file-field__success { - display: none; -} - .jetpack-form-file-field__preview.is-error .jetpack-form-file-field__uploading, .jetpack-form-file-field__preview.is-complete .jetpack-form-file-field__uploading { display: none; diff --git a/projects/packages/forms/src/contact-form/css/grunion.css b/projects/packages/forms/src/contact-form/css/grunion.css index e20f70db628cd..66846a5c4cee8 100644 --- a/projects/packages/forms/src/contact-form/css/grunion.css +++ b/projects/packages/forms/src/contact-form/css/grunion.css @@ -474,6 +474,7 @@ For some reason, when keeping the rule below together with the above selector, on production builds, the attributes are being reordered, causing side-effects */ +/* stylelint-disable-next-line no-duplicate-selectors*/ .contact-form .is-style-outlined .grunion-field-wrap .notched-label .notched-label__notch { border-left: none; border-right: none; diff --git a/projects/packages/forms/src/dashboard/inbox/style.scss b/projects/packages/forms/src/dashboard/inbox/style.scss index 151964ec2519b..83a6a406deb33 100644 --- a/projects/packages/forms/src/dashboard/inbox/style.scss +++ b/projects/packages/forms/src/dashboard/inbox/style.scss @@ -30,11 +30,20 @@ $action-bar-height: 88px; } .jp-forms__inbox-tabs { + flex: 1 1 auto; /* Flex, and grow */ + + /* Continue flexing downwards from here. */ + display: flex; + flex-direction: column; + + /* Important to pair with flex-shrink */ + min-height: 0;; .components-tab-panel__tabs { margin: 0; padding: 16px 48px 0; z-index: 1; + flex: 0 1 auto; @media (max-width: 600px) { top: 0; @@ -75,17 +84,6 @@ $action-bar-height: 88px; padding: 0 6px; } -.jp-forms__inbox-response { - border: 1px solid #dcdcde; - border-radius: 8px; - box-sizing: border-box; - display: flex; - flex-direction: column; - min-height: 300px; - overflow: hidden; - width: 100%; -} - @keyframes jp-forms__slide-in { from { @@ -105,6 +103,14 @@ $action-bar-height: 88px; } .jp-forms__inbox-response { + border: 1px solid #dcdcde; + border-radius: 8px; + box-sizing: border-box; + display: flex; + flex-direction: column; + min-height: 300px; + overflow: hidden; + width: 100%; background-color: #fff; position: relative; @@ -363,21 +369,6 @@ $action-bar-height: 88px; } } -.jp-forms__inbox-tabs { - flex: 1 1 auto; /* Flex, and grow */ - - /* Continue flexing downwards from here. */ - display: flex; - flex-direction: column; - - /* Important to pair with flex-shrink */ - min-height: 0;; -} - -.jp-forms__inbox-tabs .components-tab-panel__tabs { - flex: 0 1 auto; -} - .jp-forms__inbox-tabs .components-tab-panel__tab-content { flex: 1 1 auto; diff --git a/projects/packages/jetpack-mu-wpcom/src/features/verbum-comments/src/components/FrequencyToggle/style.scss b/projects/packages/jetpack-mu-wpcom/src/features/verbum-comments/src/components/FrequencyToggle/style.scss index 2edc4eebb7b4a..8e6eda0c4bb2e 100644 --- a/projects/packages/jetpack-mu-wpcom/src/features/verbum-comments/src/components/FrequencyToggle/style.scss +++ b/projects/packages/jetpack-mu-wpcom/src/features/verbum-comments/src/components/FrequencyToggle/style.scss @@ -24,6 +24,24 @@ label.label-wrapper { // protect the button from style leaks from the site; reset all. all: unset; + + background-color: var(--verbum-border-color); + padding: 2px 0; + cursor: pointer; + display: inline-flex; + border: 1px solid transparent; + + &:first-of-type { + border-top-left-radius: 8px; + border-bottom-left-radius: 8px; + padding-left: 2px; + } + + &:last-of-type { + border-top-right-radius: 8px; + border-bottom-right-radius: 8px; + padding-right: 2px; + } } input { @@ -60,26 +78,6 @@ box-shadow: none; } - label.label-wrapper { - background-color: var(--verbum-border-color); - padding: 2px 0; - cursor: pointer; - display: inline-flex; - border: 1px solid transparent; - - &:first-of-type { - border-top-left-radius: 8px; - border-bottom-left-radius: 8px; - padding-left: 2px; - } - - &:last-of-type { - border-top-right-radius: 8px; - border-bottom-right-radius: 8px; - padding-right: 2px; - } - } - span { display: flex; align-items: center; @@ -90,4 +88,4 @@ transition: background-color 160ms linear 0s, color 160ms linear 0s, font-weight 60ms linear 0s; } } -} \ No newline at end of file +} diff --git a/projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-bar/wpcom-admin-bar.scss b/projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-bar/wpcom-admin-bar.scss index 0bfbdd2095c4d..423eee80cc776 100644 --- a/projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-bar/wpcom-admin-bar.scss +++ b/projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-bar/wpcom-admin-bar.scss @@ -167,6 +167,7 @@ /** * Profile section of the admin bar */ +// stylelint-disable-next-line no-duplicate-selectors -- disabling due to the complexity of combining the two selectors #wpadminbar { // Add background color to the right side of the admin bar for the mobile view .quicklinks { diff --git a/projects/packages/jetpack-mu-wpcom/src/features/wpcom-hotfixes/colors/modern/colors.css b/projects/packages/jetpack-mu-wpcom/src/features/wpcom-hotfixes/colors/modern/colors.css index 17cc34e618a6d..305eb60054db9 100644 --- a/projects/packages/jetpack-mu-wpcom/src/features/wpcom-hotfixes/colors/modern/colors.css +++ b/projects/packages/jetpack-mu-wpcom/src/features/wpcom-hotfixes/colors/modern/colors.css @@ -81,7 +81,6 @@ input[type="month"]:focus, input[type="number"]:focus, input[type="search"]:focus, input[type="tel"]:focus, -input[type="text"]:focus, input[type="time"]:focus, input[type="url"]:focus, input[type="week"]:focus, diff --git a/projects/packages/jitm/src/css/jetpack-admin-jitm.scss b/projects/packages/jitm/src/css/jetpack-admin-jitm.scss index 5c113ad3042a5..2db2ca249b3ae 100644 --- a/projects/packages/jitm/src/css/jetpack-admin-jitm.scss +++ b/projects/packages/jitm/src/css/jetpack-admin-jitm.scss @@ -190,11 +190,6 @@ $jp-gray-20: #a7aaad; margin: rem( 40px ) 1.5385em 0 auto; } -// if JITM appears directly below WordPress hello dolly adjust margins -#dolly+.jitm-card { - margin: 3rem 1rem 0 auto; -} - // remove right margin for jitms in the editor .post-php .jitm-card { margin-right: 0; @@ -534,6 +529,7 @@ $jp-gray-20: #a7aaad; margin-left: rem( 10px ); } +// if JITM appears directly below WordPress hello dolly adjust margins #dolly + .jitm-card { margin: 3rem 1rem 0 auto; } diff --git a/projects/packages/masterbar/src/admin-color-schemes/colors/_admin.scss b/projects/packages/masterbar/src/admin-color-schemes/colors/_admin.scss index edd47237c8449..802ef05e027d7 100644 --- a/projects/packages/masterbar/src/admin-color-schemes/colors/_admin.scss +++ b/projects/packages/masterbar/src/admin-color-schemes/colors/_admin.scss @@ -92,7 +92,6 @@ input[type="month"]:focus, input[type="number"]:focus, input[type="search"]:focus, input[type="tel"]:focus, -input[type="text"]:focus, input[type="time"]:focus, input[type="url"]:focus, input[type="week"]:focus, diff --git a/projects/packages/masterbar/src/admin-color-schemes/colors/_overrides.scss b/projects/packages/masterbar/src/admin-color-schemes/colors/_overrides.scss index 46fd678fb676e..498ff99d4adb4 100644 --- a/projects/packages/masterbar/src/admin-color-schemes/colors/_overrides.scss +++ b/projects/packages/masterbar/src/admin-color-schemes/colors/_overrides.scss @@ -15,6 +15,7 @@ #wpadminbar{ background: $masterbar-background !important; + box-shadow: inset 0 -1px 0 $masterbar-background; // Calypso --color-masterbar-background } #wpadminbar:not(.mobile) .ab-top-menu > li:hover > .ab-item, @@ -45,6 +46,24 @@ #wpadminbar #wp-admin-bar-user-info .username { color: $menu-submenu-text; } + + // Nav unification... + + // Masterbar - My Sites active state + #wpadminbar .ab-top-menu > li.my-sites > .ab-item, + #wpadminbar .ab-top-menu > li.my-sites > .ab-item:hover { + background: $masterbar-active-background; + } + + // Masterbar - Notification hover background + #wpadminbar #wp-admin-bar-notes.hover > .ab-item { + background: $masterbar-highlight-background; + } + + // Masterbar - Notification active background + #wpadminbar .ab-top-menu > li.wpnt-show > .ab-item { + background: $masterbar-active-background !important; // important used in masterbar.css + } } // Make current submenu icon color stay the same on hover @@ -73,39 +92,6 @@ } } -// Nav unification -.admin-color-aquatic, -.admin-color-classic-blue, -.admin-color-classic-bright, -.admin-color-classic-dark, -.admin-color-contrast, -.admin-color-nightfall, -.admin-color-powder-snow, -.admin-color-sakura, -.admin-color-sunset { - - // Masterbar - border below the Masterbar - #wpadminbar { - box-shadow: inset 0 -1px 0 $masterbar-background; // Calypso --color-masterbar-background - } - - // Masterbar - My Sites active state - #wpadminbar .ab-top-menu > li.my-sites > .ab-item, - #wpadminbar .ab-top-menu > li.my-sites > .ab-item:hover { - background: $masterbar-active-background; - } - - // Masterbar - Notification hover background - #wpadminbar #wp-admin-bar-notes.hover > .ab-item { - background: $masterbar-highlight-background; - } - - // Masterbar - Notification active background - #wpadminbar .ab-top-menu > li.wpnt-show > .ab-item { - background: $masterbar-active-background !important; // important used in masterbar.css - } -} - // Ensure sidebar is visually separate from the content in the Contrast color scheme .admin-color-contrast #adminmenuback { outline: 1px solid $nav-unification-sidebar-border; diff --git a/projects/packages/masterbar/src/admin-menu/admin-menu.css b/projects/packages/masterbar/src/admin-menu/admin-menu.css index 1002a57f5d056..0e43d5877b8dc 100644 --- a/projects/packages/masterbar/src/admin-menu/admin-menu.css +++ b/projects/packages/masterbar/src/admin-menu/admin-menu.css @@ -1,5 +1,7 @@ #adminmenu { margin: 0; + display: flex; + flex-direction: column; } /** @@ -345,12 +347,6 @@ color:var(--wp-admin-theme-color) } -/** Add new site button **/ -#adminmenu { - display: flex; - flex-direction: column; -} - #adminmenu .menu-top[class*="/start?ref=calypso-sidebar"] { order: 99999; } diff --git a/projects/packages/my-jetpack/_inc/components/onboarding-tour/styles.scss b/projects/packages/my-jetpack/_inc/components/onboarding-tour/styles.scss index 1af235b46f86c..7fcc32f5d38cf 100644 --- a/projects/packages/my-jetpack/_inc/components/onboarding-tour/styles.scss +++ b/projects/packages/my-jetpack/_inc/components/onboarding-tour/styles.scss @@ -42,6 +42,10 @@ $tour-footer-spacing: 16px; height: 14px; } } + + button { + color: var(--jp-gray-0); + } } .components-guide__footer { @@ -101,12 +105,5 @@ $tour-footer-spacing: 16px; } } } - - .components-modal__header { - - button { - color: var(--jp-gray-0); - } - } } } diff --git a/projects/packages/search/src/dashboard/components/notice/style.scss b/projects/packages/search/src/dashboard/components/notice/style.scss index 54cd63d17e361..a3b6b69749e59 100644 --- a/projects/packages/search/src/dashboard/components/notice/style.scss +++ b/projects/packages/search/src/dashboard/components/notice/style.scss @@ -49,6 +49,12 @@ .dops-notice__dismiss { overflow: hidden; + color: $gray-lighten-10; + + &:hover, + &:focus { + color: $white; + } } &.is-success, @@ -164,15 +170,6 @@ height: 24px; } } - - .dops-notice & { - color: $gray-lighten-10; - - &:hover, - &:focus { - color: $white; - } - } } // specificity for general `a` elements within notice is too great diff --git a/projects/packages/search/src/dashboard/components/record-meter/notice-box.scss b/projects/packages/search/src/dashboard/components/record-meter/notice-box.scss index dd616dce2d754..86f0f13003dd6 100644 --- a/projects/packages/search/src/dashboard/components/record-meter/notice-box.scss +++ b/projects/packages/search/src/dashboard/components/record-meter/notice-box.scss @@ -70,7 +70,6 @@ .jp-search-notice-box__important .dops-notice__action, .jp-search-notice-box__important .dops-notice__icon-wrapper, .jp-search-notice-box__important, -.jp-search-notice-box__important .dops-notice__action, .jp-search-notice-box__important .dops-notice__header { color: $studio-red-50; } diff --git a/projects/packages/search/src/instant-search/components/search-result-expanded.scss b/projects/packages/search/src/instant-search/components/search-result-expanded.scss index 5b731bc82c4b6..d6788257c7d6e 100644 --- a/projects/packages/search/src/instant-search/components/search-result-expanded.scss +++ b/projects/packages/search/src/instant-search/components/search-result-expanded.scss @@ -55,11 +55,9 @@ $image-square-size: 128px; .jetpack-instant-search__search-result-expanded--no-image & { display: none; } -} // Aspect ratio box trick // See https://css-tricks.com/aspect-ratio-boxes/ -.jetpack-instant-search__search-result-expanded__image-container { position: relative; &::before { @@ -79,9 +77,6 @@ $image-square-size: 128px; height: 100%; object-fit: cover; width: 100%; -} - -.jetpack-instant-search__search-result-expanded__image { border-radius: 5px; } diff --git a/projects/packages/videopress/src/client/admin/components/video-card/style.module.scss b/projects/packages/videopress/src/client/admin/components/video-card/style.module.scss index c2817ef645824..b195c0e0fb94b 100644 --- a/projects/packages/videopress/src/client/admin/components/video-card/style.module.scss +++ b/projects/packages/videopress/src/client/admin/components/video-card/style.module.scss @@ -10,8 +10,7 @@ } .video-card__quick-actions-section, - .video-card__title-section, - .video-card__quick-actions-section { + .video-card__title-section { visibility: hidden; } } diff --git a/projects/packages/wordads/src/dashboard/components/notice/style.scss b/projects/packages/wordads/src/dashboard/components/notice/style.scss index 54cd63d17e361..a3b6b69749e59 100644 --- a/projects/packages/wordads/src/dashboard/components/notice/style.scss +++ b/projects/packages/wordads/src/dashboard/components/notice/style.scss @@ -49,6 +49,12 @@ .dops-notice__dismiss { overflow: hidden; + color: $gray-lighten-10; + + &:hover, + &:focus { + color: $white; + } } &.is-success, @@ -164,15 +170,6 @@ height: 24px; } } - - .dops-notice & { - color: $gray-lighten-10; - - &:hover, - &:focus { - color: $white; - } - } } // specificity for general `a` elements within notice is too great diff --git a/projects/plugins/automattic-for-agencies-client/src/js/components/connection-card/styles.module.scss b/projects/plugins/automattic-for-agencies-client/src/js/components/connection-card/styles.module.scss index 0988b8bce7a50..798f11a9480f5 100644 --- a/projects/plugins/automattic-for-agencies-client/src/js/components/connection-card/styles.module.scss +++ b/projects/plugins/automattic-for-agencies-client/src/js/components/connection-card/styles.module.scss @@ -41,42 +41,6 @@ padding: 0; list-style-type: none; } - - h1, h2, h3, h4, h5, h6 { - letter-spacing: -1%; - margin: 0; - } - - h1 { - font-size: 36px; - line-height: 40px; - - @media (max-width: 659px) { - font-size: 24px; - line-height: 32px; - } - } - - h2 { - font-size: 32px; - line-height: 35px; - font-weight: 510; - - @media (max-width: 659px) { - font-size: 24px; - line-height: 32px; - } - } - - p { - margin: 0; - } - - ul { - margin: 0; - padding: 0; - list-style-type: none; - } } .card--connection { @@ -184,4 +148,4 @@ margin-top: 1px; } } -} \ No newline at end of file +} diff --git a/projects/plugins/inspect/app-ui/css/style.scss b/projects/plugins/inspect/app-ui/css/style.scss index 520e90eb479eb..119a72d2f39e5 100644 --- a/projects/plugins/inspect/app-ui/css/style.scss +++ b/projects/plugins/inspect/app-ui/css/style.scss @@ -4,9 +4,6 @@ .info code { background-color: hsla(0, 0%, 92%, 100%); border-radius: 3px; -} - -.info code { font-size: 11px; } diff --git a/projects/plugins/jetpack/_inc/client/at-a-glance/style.scss b/projects/plugins/jetpack/_inc/client/at-a-glance/style.scss index c5fba4c30839e..fd9c091648ab5 100644 --- a/projects/plugins/jetpack/_inc/client/at-a-glance/style.scss +++ b/projects/plugins/jetpack/_inc/client/at-a-glance/style.scss @@ -472,10 +472,6 @@ } } -.jp-connection-settings__info { - display: flex; -} - .jp-connection-settings__text { margin-left: rem( 16px ); word-break: break-word; @@ -490,6 +486,7 @@ } .jp-connection-settings__info { + display: flex; .gridicon { opacity: 0.6; diff --git a/projects/plugins/jetpack/_inc/client/components/dash-item/style.scss b/projects/plugins/jetpack/_inc/client/components/dash-item/style.scss index eb445ca363fbf..395483c804ee9 100644 --- a/projects/plugins/jetpack/_inc/client/components/dash-item/style.scss +++ b/projects/plugins/jetpack/_inc/client/components/dash-item/style.scss @@ -19,6 +19,11 @@ a:hover { text-decoration: underline; } + + .dops-notice { + margin-top: rem( -1px ); + margin-bottom: rem( -1px ); + } } } @@ -125,17 +130,6 @@ } } -.jp-dash-item { - - .dops-section-header__actions { - - .dops-notice { - margin-top: rem( -1px ); - margin-bottom: rem( -1px ); - } - } -} - .jp-dash-item__active-label { display: inline-block; color: darken( $gray, 10% ); @@ -149,18 +143,6 @@ .jp-at-a-glance__right { .jp-dash-item__is-inactive { - - .dops-banner__content { - height: 100%; - } - } -} - -// conditional styles for content when items are inactive -.jp-dash-item__is-inactive { - - .jp-at-a-glance__left &, - .jp-at-a-glance__right & { border: 1px solid $gray-5; background: #F9F9F6; box-shadow: none; @@ -172,7 +154,15 @@ background: none; } } + + .dops-banner__content { + height: 100%; + } } +} + +// conditional styles for content when items are inactive +.jp-dash-item__is-inactive { .dops-card.dops-banner { flex-grow: unset; diff --git a/projects/plugins/jetpack/_inc/client/components/notice/style.scss b/projects/plugins/jetpack/_inc/client/components/notice/style.scss index baee210d3cf0f..07c397cc0cca0 100644 --- a/projects/plugins/jetpack/_inc/client/components/notice/style.scss +++ b/projects/plugins/jetpack/_inc/client/components/notice/style.scss @@ -49,6 +49,12 @@ .dops-notice__dismiss { overflow: hidden; + color: $gray-lighten-10; + + &:hover, + &:focus { + color: $white; + } } &.is-success, @@ -168,15 +174,6 @@ height: 24px; } } - - .dops-notice & { - color: $gray-lighten-10; - - &:hover, - &:focus { - color: $white; - } - } } // specificity for general `a` elements within notice is too great diff --git a/projects/plugins/jetpack/_inc/client/components/section-nav/style.scss b/projects/plugins/jetpack/_inc/client/components/section-nav/style.scss index 91e73d473b556..00abbc68c6227 100644 --- a/projects/plugins/jetpack/_inc/client/components/section-nav/style.scss +++ b/projects/plugins/jetpack/_inc/client/components/section-nav/style.scss @@ -49,6 +49,10 @@ @include breakpoint( "<660px" ) { margin-bottom: 9px; + + .dops-search.is-pinned { + height: 46px; + } } } @@ -419,14 +423,3 @@ padding: 3px 16px 5px; } } - -// -------- Search -------- -.dops-section-nav { - - @include breakpoint( "<660px" ) { - - .dops-search.is-pinned { - height: 46px; - } - } -} diff --git a/projects/plugins/jetpack/_inc/client/components/settings-group/style.scss b/projects/plugins/jetpack/_inc/client/components/settings-group/style.scss index 98dcc5a12d835..8045cf65bb5c9 100644 --- a/projects/plugins/jetpack/_inc/client/components/settings-group/style.scss +++ b/projects/plugins/jetpack/_inc/client/components/settings-group/style.scss @@ -25,11 +25,6 @@ margin-bottom: rem( 4px ); } - .form-toggle__switch { - float: left; - margin-top: 2px; - } - .jp-form-setting-explanation { color: $gray-text-min; display: block; @@ -96,4 +91,4 @@ .email-settings__title { margin-bottom: 0.3rem; } -} \ No newline at end of file +} diff --git a/projects/plugins/jetpack/_inc/client/components/text-input/style.scss b/projects/plugins/jetpack/_inc/client/components/text-input/style.scss index e27b69b423f7a..c0c341d15ce6e 100644 --- a/projects/plugins/jetpack/_inc/client/components/text-input/style.scss +++ b/projects/plugins/jetpack/_inc/client/components/text-input/style.scss @@ -18,6 +18,7 @@ background-color: $white; transition: all .15s ease-in-out, box-shadow 0s; box-shadow: none; + -webkit-appearance: none; &::placeholder { color: $gray; @@ -30,6 +31,22 @@ &::-ms-clear { display: none; } + + &.is-valid { + box-shadow: 0 0 0 2px lighten( $alert-green, 35 ); + + &:hover { + box-shadow: 0 0 0 2px lighten( $alert-green, 25 ); + } + } + + &.is-error { + box-shadow: 0 0 0 2px lighten( $alert-red, 35 ); + + &:hover { + box-shadow: 0 0 0 2px lighten( $alert-red, 25 ); + } + } } &:hover, @@ -51,10 +68,6 @@ color: lighten( $gray, 10% ); } } -} - -.dops-text-input.dops-text-input { // input is needed to override the default styles - -webkit-appearance: none; &.is-valid { border-color: $alert-green; @@ -72,23 +85,4 @@ border-color: darken( $alert-red, 10 ); } } - - &:focus { - - &.is-valid { - box-shadow: 0 0 0 2px lighten( $alert-green, 35 ); - - &:hover { - box-shadow: 0 0 0 2px lighten( $alert-green, 25 ); - } - } - - &.is-error { - box-shadow: 0 0 0 2px lighten( $alert-red, 35 ); - - &:hover { - box-shadow: 0 0 0 2px lighten( $alert-red, 25 ); - } - } - } } diff --git a/projects/plugins/jetpack/_inc/client/components/tree-dropdown/style.scss b/projects/plugins/jetpack/_inc/client/components/tree-dropdown/style.scss index 41bc2beede210..acce9b2e48e6e 100644 --- a/projects/plugins/jetpack/_inc/client/components/tree-dropdown/style.scss +++ b/projects/plugins/jetpack/_inc/client/components/tree-dropdown/style.scss @@ -170,9 +170,6 @@ ul.jp-tree-items { overflow-y: hidden; - } - - ul.jp-tree-items { max-height: 370px; } diff --git a/projects/plugins/jetpack/_inc/client/my-plan/style.scss b/projects/plugins/jetpack/_inc/client/my-plan/style.scss index 7424f1c46323c..8e61128c7361d 100644 --- a/projects/plugins/jetpack/_inc/client/my-plan/style.scss +++ b/projects/plugins/jetpack/_inc/client/my-plan/style.scss @@ -105,11 +105,7 @@ } .jp-landing__licensing-actions-item.no-licenses { - justify-content: space-between; flex: 1; - } - - .jp-landing__licensing-actions-item.no-licenses { justify-content: flex-end; @include breakpoint( "<660px" ) { diff --git a/projects/plugins/jetpack/extensions/blocks/goodreads/style.scss b/projects/plugins/jetpack/extensions/blocks/goodreads/style.scss index 7e92fa09e3895..25417a828a3a0 100644 --- a/projects/plugins/jetpack/extensions/blocks/goodreads/style.scss +++ b/projects/plugins/jetpack/extensions/blocks/goodreads/style.scss @@ -25,15 +25,7 @@ } [class^='gr_custom_each_container_'] { - width: 100%; - clear: both; margin: auto; - overflow: auto; - padding-bottom: 4px; - border-bottom: 1px solid #aaa; - } - - [class^='gr_custom_each_container_'] { width: 100%; clear: both; margin-bottom: 10px; diff --git a/projects/plugins/jetpack/extensions/blocks/image-compare/view.scss b/projects/plugins/jetpack/extensions/blocks/image-compare/view.scss index 50eaf18191b1d..7be2338da4418 100644 --- a/projects/plugins/jetpack/extensions/blocks/image-compare/view.scss +++ b/projects/plugins/jetpack/extensions/blocks/image-compare/view.scss @@ -47,6 +47,7 @@ div.jx-control { margin-left: auto; width: 3px; background-color: currentColor; + color: #fff; } .vertical div.jx-control { @@ -65,8 +66,8 @@ div.jx-controller { bottom: 0; height: 60px; width: 9px; - margin-left: -3px; background-color: currentColor; + margin-left: -22.5px; /* 48px / 2 - 3px separator width */ } .vertical div.jx-controller { @@ -76,6 +77,7 @@ div.jx-controller { margin-right: auto; top: -3px; position: relative; + transform: translateY(-19.5px); } div.jx-arrow { @@ -99,17 +101,19 @@ div.jx-arrow { } div.jx-arrow.jx-left { - left: 2px; border-style: solid; border-width: 8px 8px 8px 0; border-color: transparent currentColor transparent transparent; + background-image: url(data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAyNCAyNCI+PHBhdGggZD0iTTEzLjQgMThMOCAxMmw1LjQtNiAxLjIgMS00LjYgNSA0LjYgNXoiLz48L3N2Zz4=); + left: 0; } div.jx-arrow.jx-right { - right: 2px; border-style: solid; border-width: 8px 0 8px 8px; border-color: transparent transparent transparent currentColor; + background-image: url(data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAyNCAyNCI+PHBhdGggZD0iTTEwLjYgNkw5LjQgN2w0LjYgNS00LjYgNSAxLjIgMSA1LjQtNnoiLz48L3N2Zz4=); + right: 0; } .vertical div.jx-arrow.jx-left { @@ -286,10 +290,6 @@ figure.wp-block-jetpack-image-compare figcaption { * Custom styling for handle. */ -div.jx-control { - color: #fff; -} - div.jx-controller, .vertical div.jx-controller { width: 48px; @@ -297,16 +297,6 @@ div.jx-controller, border-radius: 50%; } -div.jx-controller { - margin-left: -22.5px; /* 48px / 2 - 3px separator width */ -} - -.vertical div.jx-controller { - - /*top: -22.5px; */ - transform: translateY(-19.5px); -} - div.jx-arrow.jx-left, div.jx-arrow.jx-right, .vertical div.jx-arrow.jx-left, @@ -319,16 +309,6 @@ div.jx-arrow.jx-right, will-change: transform; } -div.jx-arrow.jx-left { - background-image: url(data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAyNCAyNCI+PHBhdGggZD0iTTEzLjQgMThMOCAxMmw1LjQtNiAxLjIgMS00LjYgNSA0LjYgNXoiLz48L3N2Zz4=); - left: 0; -} - -div.jx-arrow.jx-right { - background-image: url(data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAyNCAyNCI+PHBhdGggZD0iTTEwLjYgNkw5LjQgN2w0LjYgNS00LjYgNSAxLjIgMSA1LjQtNnoiLz48L3N2Zz4=); - right: 0; -} - div.vertical div.jx-arrow.jx-left, div.vertical div.jx-arrow.jx-right { transform: rotate(90deg); diff --git a/projects/plugins/jetpack/extensions/blocks/like/editor.scss b/projects/plugins/jetpack/extensions/blocks/like/editor.scss index 5e9b83477084a..b77821344c177 100644 --- a/projects/plugins/jetpack/extensions/blocks/like/editor.scss +++ b/projects/plugins/jetpack/extensions/blocks/like/editor.scss @@ -14,6 +14,8 @@ /* Fetched below from https://widgets.wp.com/likes/style.css at 2024-06-11T14:41:11.500Z */ .wpl-likebox { container-type:inline-size; + display:flex; + align-items:center; } .wpl-likebox,.wpl-follow a,.wpl-count a { @@ -24,6 +26,7 @@ .wpl-button { min-width:40px; overflow:hidden; + float:left; } .wpl-button a { @@ -129,10 +132,6 @@ font-size:12px!important; } -.wpl-button { - float:left; -} - .rtl .wpl-button { float:right; } @@ -214,11 +213,6 @@ a.comment-like-link.loading::before { opacity:0; } -.wpl-likebox { - display:flex; - align-items:center; -} - .wpl-likebox .wpl-avatars { display:inline-flex; flex-direction:row-reverse; @@ -270,7 +264,7 @@ a.comment-like-link.loading::before { white-space:nowrap; } -/* Overrides to fix CSS conflicts within editor. */ +// stylelint-disable no-duplicate-selectors -- Overrides to fix CSS conflicts within editor. .wpl-likebox { // Prevents color and outline conflict by // .wp-block-post-content a:where(:not(.wp-element-button)) @@ -329,6 +323,7 @@ a.comment-like-link.loading::before { background-image:url("data:image/svg+xml,%3Csvg fill='none' height='16' viewBox='0 0 18 16' width='16' xmlns='http://www.w3.org/2000/svg'%3E%3Cpath d='m9.00081 2 1.95699 4.26814h4.3763l-3.6666 3.39117 1.2473 4.34069-3.91399-2.25-3.914 2.25 1.24734-4.34069-3.66667-3.39117h2.18817 2.18816z' stroke='%232c3338' stroke-linecap='round' stroke-width='1.5'/%3E%3C/svg%3E"); } } +// stylelint-enable no-duplicate-selectors // Format buttons correctly when displayed in columns @container (max-width: 320px) { diff --git a/projects/plugins/jetpack/extensions/blocks/map/editor.scss b/projects/plugins/jetpack/extensions/blocks/map/editor.scss index a3f3a9dd3fdb4..fe0e1b543c20b 100644 --- a/projects/plugins/jetpack/extensions/blocks/map/editor.scss +++ b/projects/plugins/jetpack/extensions/blocks/map/editor.scss @@ -1,5 +1,6 @@ .wp-block-jetpack-map__delete-btn { padding: 0; + margin-top: 10px; svg { margin-right: 0.4em; @@ -67,10 +68,6 @@ margin-top: 10px; } - .wp-block-jetpack-map__delete-btn { - margin-top: 10px; - } - .component__add-point__popover { .components-popover__content { diff --git a/projects/plugins/jetpack/extensions/blocks/rating-star/editor.scss b/projects/plugins/jetpack/extensions/blocks/rating-star/editor.scss index aa6fabb6b8c6d..111fea3c7c87c 100644 --- a/projects/plugins/jetpack/extensions/blocks/rating-star/editor.scss +++ b/projects/plugins/jetpack/extensions/blocks/rating-star/editor.scss @@ -1,11 +1,9 @@ // Editor only styles -.jetpack-ratings-button { - cursor: pointer; -} -// Control symbol outline when focus and hover. .jetpack-ratings-button { + cursor: pointer; + // Control symbol outline when focus and hover. &:focus { border: none; outline: none; diff --git a/projects/plugins/jetpack/extensions/blocks/rating-star/style.scss b/projects/plugins/jetpack/extensions/blocks/rating-star/style.scss index f5921e334a914..c2cbc0531a0f8 100644 --- a/projects/plugins/jetpack/extensions/blocks/rating-star/style.scss +++ b/projects/plugins/jetpack/extensions/blocks/rating-star/style.scss @@ -42,14 +42,12 @@ word-wrap: normal !important; } - // The !important is necessary to override the inline style. + // This immediate span is a whole star. > span { + // The !important is necessary to override the inline style. display: inline-flex !important; - } - // Put the star together. - // This immediate span is a whole star. - > span { // Frontend. + // Put the star together. margin-inline-end: 0.3em; } @@ -87,8 +85,4 @@ fill: transparent; } } - - .jetpack-ratings-button { - margin-inline-end: 0.3em; - } } diff --git a/projects/plugins/jetpack/extensions/blocks/simple-payments/editor.scss b/projects/plugins/jetpack/extensions/blocks/simple-payments/editor.scss index 923a1c557815b..e497fc8bdf1fb 100644 --- a/projects/plugins/jetpack/extensions/blocks/simple-payments/editor.scss +++ b/projects/plugins/jetpack/extensions/blocks/simple-payments/editor.scss @@ -20,9 +20,6 @@ textarea { display: block; } - } - - .simple-payments__field { input, textarea { diff --git a/projects/plugins/jetpack/extensions/shared/components/audio-player/style.scss b/projects/plugins/jetpack/extensions/shared/components/audio-player/style.scss index d49c8079fbea5..202660dfaa7a7 100644 --- a/projects/plugins/jetpack/extensions/shared/components/audio-player/style.scss +++ b/projects/plugins/jetpack/extensions/shared/components/audio-player/style.scss @@ -83,9 +83,6 @@ $gutter-m: 15px !default; .mejs-time-float { color: $jetpack-audio-player-background; color: var( --jetpack-audio-player-background ); - } - - .mejs-time-float { background: $jetpack-audio-player-primary; background: var( --jetpack-audio-player-primary ); border-color: $jetpack-audio-player-primary; diff --git a/projects/plugins/jetpack/modules/carousel/jetpack-carousel.css b/projects/plugins/jetpack/modules/carousel/jetpack-carousel.css index 422871824b011..bae3c9286b417 100644 --- a/projects/plugins/jetpack/modules/carousel/jetpack-carousel.css +++ b/projects/plugins/jetpack/modules/carousel/jetpack-carousel.css @@ -398,9 +398,6 @@ div.jp-carousel-buttons a:hover { font-size: 16px; margin: 25px 0; width: 100%; -} - -.jp-carousel-photo-description { overflow: hidden; overflow-wrap: break-word; } diff --git a/projects/plugins/jetpack/modules/infinite-scroll/infinity.css b/projects/plugins/jetpack/modules/infinite-scroll/infinity.css index bf9ba6e6aacca..b2f1e0a542e5c 100644 --- a/projects/plugins/jetpack/modules/infinite-scroll/infinity.css +++ b/projects/plugins/jetpack/modules/infinite-scroll/infinity.css @@ -38,6 +38,7 @@ height: 12px; border-radius: 3px / 6px; transform-origin: 3px 26px; + box-sizing: content-box; } .infinite-loader .spinner-inner div:nth-child(1) { @@ -129,10 +130,6 @@ transform-origin: 0 0; /* see note above */ } -.infinite-loader .spinner-inner div { - box-sizing: content-box; -} - /** * Using a highly-specific rule to make sure that all button styles * will be reset @@ -225,12 +222,6 @@ width: 40%; } -#infinite-footer .blog-credits { - font-weight: 400; - float: right; - width: 60%; -} - #infinite-footer .blog-info a { color: #111; font-size: 14px; @@ -238,6 +229,9 @@ } #infinite-footer .blog-credits { + font-weight: 400; + float: right; + width: 60%; color: #888; font-size: 12px; text-align: right; diff --git a/projects/plugins/jetpack/modules/sharedaddy/sharing.css b/projects/plugins/jetpack/modules/sharedaddy/sharing.css index cb3e335e7b7c9..167802e8b0b26 100644 --- a/projects/plugins/jetpack/modules/sharedaddy/sharing.css +++ b/projects/plugins/jetpack/modules/sharedaddy/sharing.css @@ -48,6 +48,8 @@ body.highlander-dark h3.sd-title::before { .sd-content ul li { display: inline-block; + margin: 0 8px 12px 0; + padding: 0; } .sd-content ul li.share-deprecated { @@ -217,11 +219,6 @@ body .sd-social-icon .sd-content ul li[class*='share-'] a.sd-button.share-icon.n } } -.sd-content ul li { - margin: 0 8px 12px 0; - padding: 0; -} - /* Add more pading on touch devices */ .jp-sharing-input-touch .sd-content ul li { padding-left: 10px; } @@ -575,9 +572,6 @@ body .sd-social-icon .sd-content ul li[class*='share-'] a.sd-button.share-icon.n body .sd-social-icon .sd-content li.share-custom a span { width: 0; -} - -body .sd-social-icon .sd-content li.share-custom a span { padding-left: 16px !important; } diff --git a/projects/plugins/jetpack/modules/shortcodes/css/style.css b/projects/plugins/jetpack/modules/shortcodes/css/style.css index 0806cf6d7a950..33ffcda40ba18 100644 --- a/projects/plugins/jetpack/modules/shortcodes/css/style.css +++ b/projects/plugins/jetpack/modules/shortcodes/css/style.css @@ -36,6 +36,7 @@ body.presentation-wrapper-fullscreen-parent { .presentation-wrapper-fullscreen .nav-fullscreen-button { z-index: 20002; + background-image: url(../images/collapse.png); } @@ -132,10 +133,6 @@ body.presentation-wrapper-fullscreen-parent { opacity: 0.8; } -.presentation-wrapper-fullscreen .nav-fullscreen-button { - background-image: url(../images/collapse.png); -} - /** * 4. Styles for the autoplay overlay */ diff --git a/projects/plugins/jetpack/modules/theme-tools/compat/twentyfourteen.css b/projects/plugins/jetpack/modules/theme-tools/compat/twentyfourteen.css index f48177b9e16d9..356b9f3f83447 100644 --- a/projects/plugins/jetpack/modules/theme-tools/compat/twentyfourteen.css +++ b/projects/plugins/jetpack/modules/theme-tools/compat/twentyfourteen.css @@ -178,9 +178,6 @@ img[id*="botd"] { .widget_jetpack_display_posts_widget .jetpack-display-remote-posts p { font-size: 14px; line-height: 1.2857142857 !important; -} - -.widget_jetpack_display_posts_widget .jetpack-display-remote-posts p { margin: 9px 0 18px !important; } @@ -315,14 +312,12 @@ img[id*="botd"] { @media screen and (min-width: 1008px) { - .footer-sidebar .widget_jp_blogs_i_follow li, .footer-sidebar .widget_jp_blogs_i_follow li, .footer-sidebar .widget_top-clicks li, .footer-sidebar .widget_top-posts li, .footer-sidebar .top_rated li, .footer-sidebar .widget_upcoming_events_widget .upcoming-events li, .primary-sidebar .widget_jp_blogs_i_follow li, - .primary-sidebar .widget_jp_blogs_i_follow li, .primary-sidebar .widget_top-clicks li, .primary-sidebar .widget_top-posts li, .primary-sidebar .top_rated li { @@ -330,14 +325,12 @@ img[id*="botd"] { padding: 0 0 6px; } - .footer-sidebar .widget_jp_blogs_i_follow li:last-child, .footer-sidebar .widget_jp_blogs_i_follow li:last-child, .footer-sidebar .widget_top-clicks li:last-child, .footer-sidebar .widget_top-posts li:last-child, .footer-sidebar .top_rated li:last-child, .footer-sidebar .widget_upcoming_events_widget .upcoming-events li:last-child, .primary-sidebar .widget_jp_blogs_i_follow li:last-child, - .primary-sidebar .widget_jp_blogs_i_follow li:last-child, .primary-sidebar .widget_top-clicks li:last-child, .primary-sidebar .widget_top-posts li:last-child, .primary-sidebar .top_rated li:last-child { diff --git a/projects/plugins/jetpack/modules/theme-tools/social-menu/social-menu.css b/projects/plugins/jetpack/modules/theme-tools/social-menu/social-menu.css index 7777dbe245829..6f306f7867eb4 100644 --- a/projects/plugins/jetpack/modules/theme-tools/social-menu/social-menu.css +++ b/projects/plugins/jetpack/modules/theme-tools/social-menu/social-menu.css @@ -48,10 +48,8 @@ Genericons text-decoration: inherit; vertical-align: top; width: 1em; -} -/* Default */ -.jetpack-social-navigation-genericons a::before { + /* Default */ content: "\f415"; } diff --git a/projects/plugins/jetpack/modules/widget-visibility/widget-conditions/widget-conditions.css b/projects/plugins/jetpack/modules/widget-visibility/widget-conditions/widget-conditions.css index 2294b46f2c36e..07a3101ea92f7 100644 --- a/projects/plugins/jetpack/modules/widget-visibility/widget-conditions/widget-conditions.css +++ b/projects/plugins/jetpack/modules/widget-visibility/widget-conditions/widget-conditions.css @@ -71,10 +71,6 @@ margin-top: -28px; } -.widget-conditional .condition .actions { - margin-top: -28px; -} - .widget-conditional .condition-control a { text-decoration: none; position: absolute; diff --git a/projects/plugins/jetpack/modules/widgets/milestone/style-admin.css b/projects/plugins/jetpack/modules/widgets/milestone/style-admin.css index 6b1eabcf0196e..ad548c3104b1b 100644 --- a/projects/plugins/jetpack/modules/widgets/milestone/style-admin.css +++ b/projects/plugins/jetpack/modules/widgets/milestone/style-admin.css @@ -8,7 +8,7 @@ .jp-ms-data-time input[type="text"] { text-align: right; - width: 2.1em; + width: 3.2em; } .jp-ms-data-time .month { @@ -18,15 +18,6 @@ .jp-ms-data-time .year[type="text"] { text-align: right; - width: 3.2em; -} - -.jp-ms-data-time input[type="text"] { - text-align: right; - width: 3.2em; -} - -.jp-ms-data-time .year[type="text"] { width: 4.5em; } @@ -69,4 +60,4 @@ .editor-styles-wrapper ul.milestone-type { list-style-type: none; padding-left: 0; -} \ No newline at end of file +} diff --git a/projects/plugins/jetpack/modules/widgets/social-icons/social-icons-admin.css b/projects/plugins/jetpack/modules/widgets/social-icons/social-icons-admin.css index 9ddd00b5e394d..5fd25e1baec24 100644 --- a/projects/plugins/jetpack/modules/widgets/social-icons/social-icons-admin.css +++ b/projects/plugins/jetpack/modules/widgets/social-icons/social-icons-admin.css @@ -22,6 +22,7 @@ html[class*='wordpress_com'] .jetpack-social-icons-widget-item:hover, .jetpack-social-icons-widget-item.ui-sortable-helper { border-color: #999; + box-shadow: 0 1px 2px rgba(0, 0, 0, 0.1); } html[class*='wordpress_com'] .jetpack-social-icons-widget-item.ui-sortable-helper, @@ -29,10 +30,6 @@ html[class*='wordpress_com'] .jetpack-social-icons-widget-item.ui-sortable-helpe border-color: #a8bece; } -.jetpack-social-icons-widget-item.ui-sortable-helper { - box-shadow: 0 1px 2px rgba(0, 0, 0, 0.1); -} - .jetpack-social-icons-widget-item.ui-state-placeholder { border-color: #a7aaad; border-style: dashed; diff --git a/projects/plugins/jetpack/scss/templates/_main.scss b/projects/plugins/jetpack/scss/templates/_main.scss index 2ebf12bedffc1..65939538017ca 100644 --- a/projects/plugins/jetpack/scss/templates/_main.scss +++ b/projects/plugins/jetpack/scss/templates/_main.scss @@ -59,12 +59,6 @@ }; } -.footer nav { - max-width: 550px; - margin: 0 auto; -} - - // ========================================================================== // Main navigation // ========================================================================== @@ -400,6 +394,7 @@ } .footer nav { + margin: 0 auto; max-width: 100%; a, @@ -578,13 +573,6 @@ } } - .squeezer { - - h2 { - font-size: 1em; - } - } - h2 { color: #fff; margin: 0; @@ -614,6 +602,10 @@ top: calc( 50% - 22px ); } + h2 { + font-size: 1em; + } + @include breakpoint(large-phone){ padding: 23px; diff --git a/projects/plugins/jetpack/scss/wordads-ccpa.scss b/projects/plugins/jetpack/scss/wordads-ccpa.scss index 1af71a0ffbf9e..7b46415536559 100644 --- a/projects/plugins/jetpack/scss/wordads-ccpa.scss +++ b/projects/plugins/jetpack/scss/wordads-ccpa.scss @@ -140,21 +140,6 @@ body.admin-bar .cleanslate .components-modal__frame { align-items: center !important; } - .components-button { - display: inline-flex !important; - text-decoration: none !important; - font-size: 13px !important; - margin: 0 !important; - border: 0 !important; - cursor: pointer !important; - -webkit-appearance: none !important; - background: none !important; - - /* Buttons that look like links, for a cross of good semantics with the visual */ - - /* Link buttons that are red to indicate destructive behavior. */ - } - .components-icon-button { display: flex !important; align-items: center !important; @@ -245,6 +230,10 @@ body.admin-bar .cleanslate .components-modal__frame { .components-form-toggle .components-form-toggle__on { left: 8px !important; display: none !important; + outline: 1px solid transparent !important; + outline-offset: -1px !important; + border: 1px solid #000 !important; + filter: invert(100%) contrast(500%) !important; } .components-form-toggle .components-form-toggle__track { @@ -353,13 +342,6 @@ body.admin-bar .cleanslate .components-modal__frame { content: "" !important; } - .components-form-toggle .components-form-toggle__on { - outline: 1px solid transparent !important; - outline-offset: -1px !important; - border: 1px solid #000 !important; - filter: invert(100%) contrast(500%) !important; - } - .components-button { display: inline-flex !important; text-decoration: none !important; diff --git a/projects/plugins/protect/src/js/components/threats-list/styles.module.scss b/projects/plugins/protect/src/js/components/threats-list/styles.module.scss index 461b542a2267f..fcfc29ad681ca 100644 --- a/projects/plugins/protect/src/js/components/threats-list/styles.module.scss +++ b/projects/plugins/protect/src/js/components/threats-list/styles.module.scss @@ -19,11 +19,16 @@ } .threat-footer { + margin-top: calc( var( --spacing-base ) * 3 ); // 24px + width: 100%; display: flex; - justify-content: flex-end; + justify-content: right; + padding-top: calc( var( --spacing-base ) * 4 ); // 32px border-top: 1px solid var( --jp-gray ); - padding-top: calc( var( --spacing-base ) * 3 ); // 24px - margin-top: calc( var( --spacing-base ) * 3 ); // 24px + + > :last-child { + margin-left: calc( var( --spacing-base ) * 2 ); // 16px + } } .threat-item-cta { @@ -46,18 +51,6 @@ gap: calc( var( --spacing-base ) * 2 ); // 16px } -.threat-footer { - width: 100%; - display: flex; - justify-content: right; - padding-top: calc( var( --spacing-base ) * 4 ); // 32px - border-top: 1px solid var( --jp-gray ); - - > :last-child { - margin-left: calc( var( --spacing-base ) * 2 ); // 16px - } -} - .accordion-header { display: grid; grid-template-columns: repeat( 9, 1fr ); diff --git a/projects/plugins/vaultpress/nav-styles.css b/projects/plugins/vaultpress/nav-styles.css index 1cc4ffdce133f..c2f7eda36855e 100644 --- a/projects/plugins/vaultpress/nav-styles.css +++ b/projects/plugins/vaultpress/nav-styles.css @@ -50,6 +50,7 @@ .dops-notice .dops-notice__dismiss { overflow: hidden; + color: #bbb; } .dops-notice.is-success .dops-notice__dismiss, .dops-notice.is-error .dops-notice__dismiss, .dops-notice.is-warning .dops-notice__dismiss, .dops-notice.is-info .dops-notice__dismiss { @@ -158,10 +159,6 @@ } } -.dops-notice .dops-notice__dismiss { - color: #bbb; -} - .dops-notice .dops-notice__dismiss:hover, .dops-notice .dops-notice__dismiss:focus { color: #fff; } diff --git a/projects/plugins/wpcomsh/custom-colors/css/colors-control.css b/projects/plugins/wpcomsh/custom-colors/css/colors-control.css index 642f1336c7911..054acd41fbc87 100644 --- a/projects/plugins/wpcomsh/custom-colors/css/colors-control.css +++ b/projects/plugins/wpcomsh/custom-colors/css/colors-control.css @@ -40,12 +40,13 @@ .color-grid.main li { height: 55px; width: 55px; - background-image: radial-gradient( center top, circle farthest-side, rgba(255, 255, 255, .35), rgba(255, 255, 255, 0) 80% ); background-position: center center; background-size: cover; - border: 2px solid #fff; border-radius: 50%; - box-shadow: inset 0 -1px 4px rgba(0,0,0,0.1); + background-image: none; + border: none; + box-shadow: inset 0 3px 5px rgba(0, 0, 0, 0.2), inset 0 -2px 0 rgba(255, 255, 255, 0.1); + margin: 0 13px 12px; } .disable-background .color-grid.main li, @@ -84,7 +85,6 @@ .color-grid li { background: #f1f1f1; border: 5px solid rgba(0,0,0,0.1); - border-width: 1px 1px 5px; font-size: 0; box-sizing: border-box; display: block; @@ -93,6 +93,7 @@ margin: 0; height: 50px; width: 80px; + border-width: 1px; } .color-grid li a { @@ -130,13 +131,13 @@ color: #fff; content: '\f406'; font-family: Noticons; - font-size: 21px; opacity: 0.4; float: left; position: relative; - left: 15px; - top: 18px; text-shadow: 0 0 2px rgba(0,0,0,0.4); + font-size: 20px; + left: 17px; + top: 20px; } .color-grid.main .selected { @@ -183,9 +184,12 @@ a.revert { display: none; padding: 10px 20px; position: relative; - left: -20px; + left: -20px; width: 260px; z-index: 2; + background-color: transparent; + border-top: 1px solid #333; + margin-top: 40px; } /* override new-customizer.css */ @@ -222,7 +226,7 @@ a.revert { clear: both; color: #646464; font-size: 13px; - margin: 10px 0 10px; + margin: 30px 0 10px; } /* override new-customizer.css */ @@ -317,12 +321,13 @@ a.revert { /* =Color Palettes ----------------------------------------------- */ .colour-lovers { - border-radius: 4px; float: left; margin: 0 18px 18px 0; height: 50px; width: 72px; position: relative; + border-radius: 2px; + overflow: hidden; } .colour-lovers li { @@ -751,16 +756,6 @@ input#iris { } /* Restored CSS from wp.com theme customizer updates */ - -.colour-lovers { - border-radius: 2px; - overflow: hidden; -} - -.color-grid li { - border-width: 1px; -} - .color-grid.main { height: auto; text-align: center; @@ -770,30 +765,6 @@ input#iris { padding-top: 20px } -.color-grid.main li { - background-image: none; - border: none; - box-shadow: inset 0 3px 5px rgba(0, 0, 0, 0.2), inset 0 -2px 0 rgba(255, 255, 255, 0.1); - margin: 0 13px 12px; -} - -.color-grid .unavailable::before { - font-size: 20px; - left: 17px; - top: 20px; -} - -.the-picker { - background-color: transparent; - border-top: 1px solid #333; - margin-top: 40px; - padding-top: 10px; -} - -.the-picker p { - margin-top: 30px; -} - .the-picker p a { font-weight: 700; } diff --git a/projects/plugins/wpcomsh/custom-colors/css/rtl/colors-control-rtl.css b/projects/plugins/wpcomsh/custom-colors/css/rtl/colors-control-rtl.css index fe94a50fa65e5..15e85f5d7a9ad 100644 --- a/projects/plugins/wpcomsh/custom-colors/css/rtl/colors-control-rtl.css +++ b/projects/plugins/wpcomsh/custom-colors/css/rtl/colors-control-rtl.css @@ -42,12 +42,12 @@ .color-grid.main li { height: 55px; width: 55px; - background-image: radial-gradient( center top, circle farthest-side, rgba(255, 255, 255, .35), rgba(255, 255, 255, 0) 80% ); background-position: center center; background-size: cover; - border: 2px solid #fff; border-radius: 50%; - box-shadow: inset 0 -1px 4px rgba(0,0,0,0.1); + background-image: none; + border: none; + box-shadow: inset 0 3px 5px rgba(0, 0, 0, 0.2), inset 0 -2px 0 rgba(255, 255, 255, 0.1); } .disable-background .color-grid.main li, @@ -87,12 +87,13 @@ height: auto; text-align: center; width: 100%; + border-bottom: none; + background-color: transparent; } .color-grid li { background: #f1f1f1; border: 5px solid rgba(0,0,0,0.1); - border-width: 1px 1px 5px; font-size: 0; box-sizing: border-box; display: block; @@ -101,6 +102,7 @@ margin: 0; height: 50px; width: 80px; + border-width: 1px; } .color-grid li a { @@ -138,13 +140,13 @@ color: #fff; content: '\f406'; font-family: Noticons; - font-size: 21px; opacity: 0.4; float: right; position: relative; - right: 15px; - top: 18px; text-shadow: 0 0 2px rgba(0,0,0,0.4); + font-size: 20px; + right: 17px; + top: 20px; } .color-grid.main .selected { @@ -191,9 +193,12 @@ a.revert { display: none; padding: 10px 20px; position: relative; - right: -20px; + right: -20px; width: 260px; z-index: 2; + background-color: transparent; + border-top: 1px solid #333; + margin-top: 40px; } /* override new-customizer.css */ @@ -230,7 +235,7 @@ a.revert { clear: both; color: #646464; font-size: 13px; - margin: 10px 0 10px; + margin: 30px 0 10px; } /* override new-customizer.css */ @@ -325,12 +330,13 @@ a.revert { /* =Color Palettes ----------------------------------------------- */ .colour-lovers { - border-radius: 4px; float: right; margin: 0 0 18px 18px; height: 50px; width: 72px; position: relative; + border-radius: 2px; + overflow: hidden; } .colour-lovers:nth-of-type(3) { @@ -764,43 +770,6 @@ input#iris { /* Restored CSS from wp.com theme customizer updates */ -.colour-lovers { - border-radius: 2px; - overflow: hidden; -} - -.color-grid li { - border-width: 1px; -} - -.color-grid.main { - border-bottom: none; - background-color: transparent; -} - -.color-grid.main li { - background-image: none; - border: none; - box-shadow: inset 0 3px 5px rgba(0, 0, 0, 0.2), inset 0 -2px 0 rgba(255, 255, 255, 0.1); -} - -.color-grid .unavailable::before { - font-size: 20px; - right: 17px; - top: 20px; -} - -.the-picker { - background-color: transparent; - border-top: 1px solid #333; - margin-top: 40px; - padding-top: 10px; -} - -.the-picker p { - margin-top: 30px; -} - .the-picker p a { font-weight: 700; } diff --git a/tools/js-tools/stylelint.config.base.mjs b/tools/js-tools/stylelint.config.base.mjs index 5642354cd0d66..d9451d877298d 100644 --- a/tools/js-tools/stylelint.config.base.mjs +++ b/tools/js-tools/stylelint.config.base.mjs @@ -54,7 +54,6 @@ const baseConfig = { ], // Disable all other rules for now. - 'no-duplicate-selectors': null, 'scss/at-extend-no-missing-placeholder': null, 'scss/no-global-function-names': null, 'scss/selector-no-redundant-nesting-selector': null, From a035858a27eee00064c9b516533bcdf67eb20d4a Mon Sep 17 00:00:00 2001 From: tbradsha <32492176+tbradsha@users.noreply.github.com> Date: Fri, 25 Apr 2025 12:16:19 -0600 Subject: [PATCH 12/25] Undisable scss/at-extend-no-missing-placeholder --- .../media-picker/styles.module.scss | 9 +++++++-- .../app/assets/src/css/main/dashboard.scss | 11 +++++++--- .../js/layout/card-page/card-page.module.scss | 2 +- .../sass/ZeroBSCRM.admin.invoicepreview.scss | 2 +- .../crm/sass/_ZeroBSCRM.customerfilters.scss | 2 +- .../crm/sass/_ZeroBSCRM.prevadmincore.scss | 2 +- .../crm/sass/_ZeroBSCRM.timelines.scss | 4 ++-- .../plugins/crm/sass/jpcrm-admin-tasks.scss | 8 ++++---- .../plugins/inspect/app-ui/css/style.scss | 20 ++++++++++++++----- .../plugins/jetpack/scss/atoms/_buttons.scss | 9 +++++++-- tools/js-tools/stylelint.config.base.mjs | 1 - 11 files changed, 47 insertions(+), 23 deletions(-) diff --git a/projects/js-packages/publicize-components/src/components/media-picker/styles.module.scss b/projects/js-packages/publicize-components/src/components/media-picker/styles.module.scss index 9515d6e105406..bc226d058cece 100644 --- a/projects/js-packages/publicize-components/src/components/media-picker/styles.module.scss +++ b/projects/js-packages/publicize-components/src/components/media-picker/styles.module.scss @@ -72,7 +72,7 @@ cursor: pointer; } -.remove { +%remove { position: absolute; top: -4px; right: -4px; @@ -101,9 +101,14 @@ } } +.remove { + + @extend %remove; +} + .remove-loading { - @extend .remove; + @extend %remove; // This is to make the close button appear in the right place when we are loading the image. // With this it is possible to close/stop loading images if the request takes too long. top: -56px; diff --git a/projects/plugins/boost/app/assets/src/css/main/dashboard.scss b/projects/plugins/boost/app/assets/src/css/main/dashboard.scss index 57028d771d7fe..edd8f070bbf2b 100644 --- a/projects/plugins/boost/app/assets/src/css/main/dashboard.scss +++ b/projects/plugins/boost/app/assets/src/css/main/dashboard.scss @@ -20,7 +20,7 @@ z-index: 15; } -.jb-container { +%jb-container { width: 87.5%; max-width: 1320px; margin-left: auto; @@ -28,7 +28,7 @@ &--narrow { - @extend .jb-container; + @extend %jb-container; max-width: 744px; } @@ -40,9 +40,14 @@ } } +.jb-container { + + @extend %jb-container; +} + .jb-dashboard-footer { - @extend .jb-container; + @extend %jb-container; display: flex; justify-content: space-between; diff --git a/projects/plugins/boost/app/assets/src/js/layout/card-page/card-page.module.scss b/projects/plugins/boost/app/assets/src/js/layout/card-page/card-page.module.scss index 06fe6e3ba12d2..fa6209c65b209 100644 --- a/projects/plugins/boost/app/assets/src/js/layout/card-page/card-page.module.scss +++ b/projects/plugins/boost/app/assets/src/js/layout/card-page/card-page.module.scss @@ -9,7 +9,7 @@ .content { - @extend .p-4; + @extend .p-4; // stylelint-disable-line scss/at-extend-no-missing-placeholder -- This is a generated class from css/main/common.scss. color: $primary-black; ul li { diff --git a/projects/plugins/crm/sass/ZeroBSCRM.admin.invoicepreview.scss b/projects/plugins/crm/sass/ZeroBSCRM.admin.invoicepreview.scss index 2510268012319..dafe713520741 100644 --- a/projects/plugins/crm/sass/ZeroBSCRM.admin.invoicepreview.scss +++ b/projects/plugins/crm/sass/ZeroBSCRM.admin.invoicepreview.scss @@ -5,7 +5,7 @@ */ // The invoice preview CSS -.zbs-admin-label { +%zbs-admin-label { font-weight:800; diff --git a/projects/plugins/crm/sass/_ZeroBSCRM.customerfilters.scss b/projects/plugins/crm/sass/_ZeroBSCRM.customerfilters.scss index be441fdf8b9d0..bf0e34d703e5a 100644 --- a/projects/plugins/crm/sass/_ZeroBSCRM.customerfilters.scss +++ b/projects/plugins/crm/sass/_ZeroBSCRM.customerfilters.scss @@ -58,7 +58,7 @@ label { // use our generic label first - @extend .zbs-admin-label; + @extend %zbs-admin-label; margin: 4px 8px; font-size: 13px; diff --git a/projects/plugins/crm/sass/_ZeroBSCRM.prevadmincore.scss b/projects/plugins/crm/sass/_ZeroBSCRM.prevadmincore.scss index 69b96916f0fa7..cc7d14b0d5181 100644 --- a/projects/plugins/crm/sass/_ZeroBSCRM.prevadmincore.scss +++ b/projects/plugins/crm/sass/_ZeroBSCRM.prevadmincore.scss @@ -4570,7 +4570,7 @@ th.column-ID { -.zbs-admin-label { +%zbs-admin-label { font-weight:800; diff --git a/projects/plugins/crm/sass/_ZeroBSCRM.timelines.scss b/projects/plugins/crm/sass/_ZeroBSCRM.timelines.scss index 54797e298ef4c..0ae4c97f1d8c5 100644 --- a/projects/plugins/crm/sass/_ZeroBSCRM.timelines.scss +++ b/projects/plugins/crm/sass/_ZeroBSCRM.timelines.scss @@ -239,7 +239,7 @@ $primary-color-hover: scale-color($primary-color, $lightness: 32%); MOD: TIMELINE SPLIT ----------------------------------------------*/ - .zbs-timeline-split { + %zbs-timeline-split { @media (min-width: 768px) { @@ -285,7 +285,7 @@ $primary-color-hover: scale-color($primary-color, $lightness: 32%); .zbs-timeline-centered { - @extend .zbs-timeline-split; + @extend %zbs-timeline-split; @media (min-width: 992px) { diff --git a/projects/plugins/crm/sass/jpcrm-admin-tasks.scss b/projects/plugins/crm/sass/jpcrm-admin-tasks.scss index ced9e18cb6ef2..4f4611a6cd5e3 100644 --- a/projects/plugins/crm/sass/jpcrm-admin-tasks.scss +++ b/projects/plugins/crm/sass/jpcrm-admin-tasks.scss @@ -4,7 +4,7 @@ */ // this is extended throughout -.zbs-tasks-field { +%zbs-tasks-field { line-height: 1; border: 1px solid #ccc; @@ -121,7 +121,7 @@ background: #fff; #zbs-task-title{ // take general rounding etc. from this - @extend .zbs-tasks-field; + @extend %zbs-tasks-field; width:80%; float:left; @@ -148,7 +148,7 @@ background: #fff; .no-owner, .no-task-date, .task-reminders, .no-contact, .show-on-calendar, .remind_task{ // take general rounding etc. from this - @extend .zbs-tasks-field; + @extend %zbs-tasks-field; width: 100%; font-size: 14px; @@ -218,7 +218,7 @@ background: #fff; .zbs-task-desc textarea{ // take general rounding etc. from this - @extend .zbs-tasks-field; + @extend %zbs-tasks-field; width: 100%; height:200px; diff --git a/projects/plugins/inspect/app-ui/css/style.scss b/projects/plugins/inspect/app-ui/css/style.scss index 119a72d2f39e5..212077a811c4c 100644 --- a/projects/plugins/inspect/app-ui/css/style.scss +++ b/projects/plugins/inspect/app-ui/css/style.scss @@ -7,7 +7,7 @@ font-size: 11px; } -.button-effects { +%button-effects { &:hover { opacity: 0.8; @@ -21,7 +21,12 @@ } } -.ji-button { +.button-effects { + + @extend %button-effects; +} + +%ji-button { display: inline-block; padding: 9px 21px; font-size: 0.75rem; @@ -32,19 +37,24 @@ font-weight: 400; cursor: pointer; - @extend .button-effects; + @extend %button-effects; +} + +.ji-button { + + @extend %ji-button; } .ji-button--alt { - @extend .ji-button; + @extend %ji-button; background-color: hsl(77, 43%, 90%); color: var(--jetpack_green_40); } .ji-button--altii { - @extend .ji-button; + @extend %ji-button; background-color: hsl(77, 43%, 90%); color: var(--jetpack_green_40); } diff --git a/projects/plugins/jetpack/scss/atoms/_buttons.scss b/projects/plugins/jetpack/scss/atoms/_buttons.scss index 06d14807f64dd..2ce2ff0c1312d 100644 --- a/projects/plugins/jetpack/scss/atoms/_buttons.scss +++ b/projects/plugins/jetpack/scss/atoms/_buttons.scss @@ -7,7 +7,7 @@ transition: all .1s ease-in-out; } -.jp-button { +%jp-button { display: inline-block; position: relative; padding: em(10px, 13px) em(19px, 13px); @@ -35,9 +35,14 @@ } } +.jp-button { + + @extend %jp-button; +} + .jp-button--settings { - @extend .jp-button; + @extend %jp-button; background: #93b45f; color: #e8eedf; diff --git a/tools/js-tools/stylelint.config.base.mjs b/tools/js-tools/stylelint.config.base.mjs index d9451d877298d..de43c84e1dfb8 100644 --- a/tools/js-tools/stylelint.config.base.mjs +++ b/tools/js-tools/stylelint.config.base.mjs @@ -54,7 +54,6 @@ const baseConfig = { ], // Disable all other rules for now. - 'scss/at-extend-no-missing-placeholder': null, 'scss/no-global-function-names': null, 'scss/selector-no-redundant-nesting-selector': null, 'selector-id-pattern': null, From 90c759b21acd9eabbdffc55bc24d94100b81d765 Mon Sep 17 00:00:00 2001 From: tbradsha <32492176+tbradsha@users.noreply.github.com> Date: Fri, 25 Apr 2025 12:19:06 -0600 Subject: [PATCH 13/25] Keep selector-id-pattern disabled --- tools/js-tools/stylelint.config.base.mjs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/js-tools/stylelint.config.base.mjs b/tools/js-tools/stylelint.config.base.mjs index de43c84e1dfb8..951056194c297 100644 --- a/tools/js-tools/stylelint.config.base.mjs +++ b/tools/js-tools/stylelint.config.base.mjs @@ -38,6 +38,9 @@ const baseConfig = { // Disabled until a valid pattern has been decided on: https://github.com/WordPress/gutenberg/issues/28616 'selector-class-pattern': null, + // Disabled due to widespread inconsistent patterns throughout that would require coordinated changes across CSS, JS, and PHP across multiple repos. + 'selector-id-pattern': null, + 'selector-pseudo-class-no-unknown': [ true, { @@ -56,7 +59,6 @@ const baseConfig = { // Disable all other rules for now. 'scss/no-global-function-names': null, 'scss/selector-no-redundant-nesting-selector': null, - 'selector-id-pattern': null, }, }; From da7bf146c73d5e58b17eef5610e4c59908b26513 Mon Sep 17 00:00:00 2001 From: tbradsha <32492176+tbradsha@users.noreply.github.com> Date: Fri, 25 Apr 2025 12:23:13 -0600 Subject: [PATCH 14/25] Add changelogs --- .../ai-client/changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ .../components/changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ .../connection/changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ .../licensing/changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ .../changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ .../changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ .../backup/changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ .../changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ .../packages/forms/changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ .../changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ .../packages/jitm/changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ .../masterbar/changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ .../my-jetpack/changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ .../search/changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ .../videopress/changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ .../wordads/changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ .../changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ .../plugins/boost/changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ .../plugins/crm/changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ .../debug-helper/changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ .../inspect/changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ .../jetpack/changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ .../protect/changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ .../vaultpress/changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ .../wpcomsh/changelog/fix-stylelint-round_x_of_cleanup | 4 ++++ 25 files changed, 100 insertions(+) create mode 100644 projects/js-packages/ai-client/changelog/fix-stylelint-round_x_of_cleanup create mode 100644 projects/js-packages/components/changelog/fix-stylelint-round_x_of_cleanup create mode 100644 projects/js-packages/connection/changelog/fix-stylelint-round_x_of_cleanup create mode 100644 projects/js-packages/licensing/changelog/fix-stylelint-round_x_of_cleanup create mode 100644 projects/js-packages/publicize-components/changelog/fix-stylelint-round_x_of_cleanup create mode 100644 projects/packages/account-protection/changelog/fix-stylelint-round_x_of_cleanup create mode 100644 projects/packages/backup/changelog/fix-stylelint-round_x_of_cleanup create mode 100644 projects/packages/classic-theme-helper/changelog/fix-stylelint-round_x_of_cleanup create mode 100644 projects/packages/forms/changelog/fix-stylelint-round_x_of_cleanup create mode 100644 projects/packages/jetpack-mu-wpcom/changelog/fix-stylelint-round_x_of_cleanup create mode 100644 projects/packages/jitm/changelog/fix-stylelint-round_x_of_cleanup create mode 100644 projects/packages/masterbar/changelog/fix-stylelint-round_x_of_cleanup create mode 100644 projects/packages/my-jetpack/changelog/fix-stylelint-round_x_of_cleanup create mode 100644 projects/packages/search/changelog/fix-stylelint-round_x_of_cleanup create mode 100644 projects/packages/videopress/changelog/fix-stylelint-round_x_of_cleanup create mode 100644 projects/packages/wordads/changelog/fix-stylelint-round_x_of_cleanup create mode 100644 projects/plugins/automattic-for-agencies-client/changelog/fix-stylelint-round_x_of_cleanup create mode 100644 projects/plugins/boost/changelog/fix-stylelint-round_x_of_cleanup create mode 100644 projects/plugins/crm/changelog/fix-stylelint-round_x_of_cleanup create mode 100644 projects/plugins/debug-helper/changelog/fix-stylelint-round_x_of_cleanup create mode 100644 projects/plugins/inspect/changelog/fix-stylelint-round_x_of_cleanup create mode 100644 projects/plugins/jetpack/changelog/fix-stylelint-round_x_of_cleanup create mode 100644 projects/plugins/protect/changelog/fix-stylelint-round_x_of_cleanup create mode 100644 projects/plugins/vaultpress/changelog/fix-stylelint-round_x_of_cleanup create mode 100644 projects/plugins/wpcomsh/changelog/fix-stylelint-round_x_of_cleanup diff --git a/projects/js-packages/ai-client/changelog/fix-stylelint-round_x_of_cleanup b/projects/js-packages/ai-client/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..aa51ece224cc4 --- /dev/null +++ b/projects/js-packages/ai-client/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Linting: Do additional stylesheet cleanup. diff --git a/projects/js-packages/components/changelog/fix-stylelint-round_x_of_cleanup b/projects/js-packages/components/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..aa51ece224cc4 --- /dev/null +++ b/projects/js-packages/components/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Linting: Do additional stylesheet cleanup. diff --git a/projects/js-packages/connection/changelog/fix-stylelint-round_x_of_cleanup b/projects/js-packages/connection/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..aa51ece224cc4 --- /dev/null +++ b/projects/js-packages/connection/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Linting: Do additional stylesheet cleanup. diff --git a/projects/js-packages/licensing/changelog/fix-stylelint-round_x_of_cleanup b/projects/js-packages/licensing/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..aa51ece224cc4 --- /dev/null +++ b/projects/js-packages/licensing/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Linting: Do additional stylesheet cleanup. diff --git a/projects/js-packages/publicize-components/changelog/fix-stylelint-round_x_of_cleanup b/projects/js-packages/publicize-components/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..aa51ece224cc4 --- /dev/null +++ b/projects/js-packages/publicize-components/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Linting: Do additional stylesheet cleanup. diff --git a/projects/packages/account-protection/changelog/fix-stylelint-round_x_of_cleanup b/projects/packages/account-protection/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..aa51ece224cc4 --- /dev/null +++ b/projects/packages/account-protection/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Linting: Do additional stylesheet cleanup. diff --git a/projects/packages/backup/changelog/fix-stylelint-round_x_of_cleanup b/projects/packages/backup/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..aa51ece224cc4 --- /dev/null +++ b/projects/packages/backup/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Linting: Do additional stylesheet cleanup. diff --git a/projects/packages/classic-theme-helper/changelog/fix-stylelint-round_x_of_cleanup b/projects/packages/classic-theme-helper/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..aa51ece224cc4 --- /dev/null +++ b/projects/packages/classic-theme-helper/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Linting: Do additional stylesheet cleanup. diff --git a/projects/packages/forms/changelog/fix-stylelint-round_x_of_cleanup b/projects/packages/forms/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..aa51ece224cc4 --- /dev/null +++ b/projects/packages/forms/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Linting: Do additional stylesheet cleanup. diff --git a/projects/packages/jetpack-mu-wpcom/changelog/fix-stylelint-round_x_of_cleanup b/projects/packages/jetpack-mu-wpcom/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..aa51ece224cc4 --- /dev/null +++ b/projects/packages/jetpack-mu-wpcom/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Linting: Do additional stylesheet cleanup. diff --git a/projects/packages/jitm/changelog/fix-stylelint-round_x_of_cleanup b/projects/packages/jitm/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..aa51ece224cc4 --- /dev/null +++ b/projects/packages/jitm/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Linting: Do additional stylesheet cleanup. diff --git a/projects/packages/masterbar/changelog/fix-stylelint-round_x_of_cleanup b/projects/packages/masterbar/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..aa51ece224cc4 --- /dev/null +++ b/projects/packages/masterbar/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Linting: Do additional stylesheet cleanup. diff --git a/projects/packages/my-jetpack/changelog/fix-stylelint-round_x_of_cleanup b/projects/packages/my-jetpack/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..aa51ece224cc4 --- /dev/null +++ b/projects/packages/my-jetpack/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Linting: Do additional stylesheet cleanup. diff --git a/projects/packages/search/changelog/fix-stylelint-round_x_of_cleanup b/projects/packages/search/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..aa51ece224cc4 --- /dev/null +++ b/projects/packages/search/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Linting: Do additional stylesheet cleanup. diff --git a/projects/packages/videopress/changelog/fix-stylelint-round_x_of_cleanup b/projects/packages/videopress/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..aa51ece224cc4 --- /dev/null +++ b/projects/packages/videopress/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Linting: Do additional stylesheet cleanup. diff --git a/projects/packages/wordads/changelog/fix-stylelint-round_x_of_cleanup b/projects/packages/wordads/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..aa51ece224cc4 --- /dev/null +++ b/projects/packages/wordads/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Linting: Do additional stylesheet cleanup. diff --git a/projects/plugins/automattic-for-agencies-client/changelog/fix-stylelint-round_x_of_cleanup b/projects/plugins/automattic-for-agencies-client/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..aa51ece224cc4 --- /dev/null +++ b/projects/plugins/automattic-for-agencies-client/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Linting: Do additional stylesheet cleanup. diff --git a/projects/plugins/boost/changelog/fix-stylelint-round_x_of_cleanup b/projects/plugins/boost/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..aa51ece224cc4 --- /dev/null +++ b/projects/plugins/boost/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Linting: Do additional stylesheet cleanup. diff --git a/projects/plugins/crm/changelog/fix-stylelint-round_x_of_cleanup b/projects/plugins/crm/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..aa51ece224cc4 --- /dev/null +++ b/projects/plugins/crm/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Linting: Do additional stylesheet cleanup. diff --git a/projects/plugins/debug-helper/changelog/fix-stylelint-round_x_of_cleanup b/projects/plugins/debug-helper/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..aa51ece224cc4 --- /dev/null +++ b/projects/plugins/debug-helper/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Linting: Do additional stylesheet cleanup. diff --git a/projects/plugins/inspect/changelog/fix-stylelint-round_x_of_cleanup b/projects/plugins/inspect/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..aa51ece224cc4 --- /dev/null +++ b/projects/plugins/inspect/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Linting: Do additional stylesheet cleanup. diff --git a/projects/plugins/jetpack/changelog/fix-stylelint-round_x_of_cleanup b/projects/plugins/jetpack/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..0d88b59b16131 --- /dev/null +++ b/projects/plugins/jetpack/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: other + +Linting: Do additional stylesheet cleanup. diff --git a/projects/plugins/protect/changelog/fix-stylelint-round_x_of_cleanup b/projects/plugins/protect/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..aa51ece224cc4 --- /dev/null +++ b/projects/plugins/protect/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Linting: Do additional stylesheet cleanup. diff --git a/projects/plugins/vaultpress/changelog/fix-stylelint-round_x_of_cleanup b/projects/plugins/vaultpress/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..aa51ece224cc4 --- /dev/null +++ b/projects/plugins/vaultpress/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Linting: Do additional stylesheet cleanup. diff --git a/projects/plugins/wpcomsh/changelog/fix-stylelint-round_x_of_cleanup b/projects/plugins/wpcomsh/changelog/fix-stylelint-round_x_of_cleanup new file mode 100644 index 0000000000000..aa51ece224cc4 --- /dev/null +++ b/projects/plugins/wpcomsh/changelog/fix-stylelint-round_x_of_cleanup @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Linting: Do additional stylesheet cleanup. From e0f7bf441aea3219b246816d8079f81dfe37b414 Mon Sep 17 00:00:00 2001 From: tbradsha <32492176+tbradsha@users.noreply.github.com> Date: Mon, 28 Apr 2025 13:31:56 -0600 Subject: [PATCH 15/25] Collapse class + placeholder instances into single selector group --- .../src/components/media-picker/styles.module.scss | 7 +------ .../boost/app/assets/src/css/main/dashboard.scss | 7 +------ projects/plugins/inspect/app-ui/css/style.scss | 14 ++------------ projects/plugins/jetpack/scss/atoms/_buttons.scss | 7 +------ 4 files changed, 5 insertions(+), 30 deletions(-) diff --git a/projects/js-packages/publicize-components/src/components/media-picker/styles.module.scss b/projects/js-packages/publicize-components/src/components/media-picker/styles.module.scss index bc226d058cece..ca5787f9ba375 100644 --- a/projects/js-packages/publicize-components/src/components/media-picker/styles.module.scss +++ b/projects/js-packages/publicize-components/src/components/media-picker/styles.module.scss @@ -72,7 +72,7 @@ cursor: pointer; } -%remove { +.remove, %remove { position: absolute; top: -4px; right: -4px; @@ -101,11 +101,6 @@ } } -.remove { - - @extend %remove; -} - .remove-loading { @extend %remove; diff --git a/projects/plugins/boost/app/assets/src/css/main/dashboard.scss b/projects/plugins/boost/app/assets/src/css/main/dashboard.scss index edd8f070bbf2b..e26fd96c8d459 100644 --- a/projects/plugins/boost/app/assets/src/css/main/dashboard.scss +++ b/projects/plugins/boost/app/assets/src/css/main/dashboard.scss @@ -20,7 +20,7 @@ z-index: 15; } -%jb-container { +.jb-container, %jb-container { width: 87.5%; max-width: 1320px; margin-left: auto; @@ -40,11 +40,6 @@ } } -.jb-container { - - @extend %jb-container; -} - .jb-dashboard-footer { @extend %jb-container; diff --git a/projects/plugins/inspect/app-ui/css/style.scss b/projects/plugins/inspect/app-ui/css/style.scss index 212077a811c4c..5acbf36201260 100644 --- a/projects/plugins/inspect/app-ui/css/style.scss +++ b/projects/plugins/inspect/app-ui/css/style.scss @@ -7,7 +7,7 @@ font-size: 11px; } -%button-effects { +.button-effects, %button-effects { &:hover { opacity: 0.8; @@ -21,12 +21,7 @@ } } -.button-effects { - - @extend %button-effects; -} - -%ji-button { +.ji-button, %ji-button { display: inline-block; padding: 9px 21px; font-size: 0.75rem; @@ -40,11 +35,6 @@ @extend %button-effects; } -.ji-button { - - @extend %ji-button; -} - .ji-button--alt { @extend %ji-button; diff --git a/projects/plugins/jetpack/scss/atoms/_buttons.scss b/projects/plugins/jetpack/scss/atoms/_buttons.scss index 2ce2ff0c1312d..cc259261a9c3a 100644 --- a/projects/plugins/jetpack/scss/atoms/_buttons.scss +++ b/projects/plugins/jetpack/scss/atoms/_buttons.scss @@ -7,7 +7,7 @@ transition: all .1s ease-in-out; } -%jp-button { +.jp-button, %jp-button { display: inline-block; position: relative; padding: em(10px, 13px) em(19px, 13px); @@ -35,11 +35,6 @@ } } -.jp-button { - - @extend %jp-button; -} - .jp-button--settings { @extend %jp-button; From 105c8dd0141480efac4f3d1225b5486fb1d9778c Mon Sep 17 00:00:00 2001 From: tbradsha <32492176+tbradsha@users.noreply.github.com> Date: Mon, 28 Apr 2025 13:34:21 -0600 Subject: [PATCH 16/25] Update projects/packages/my-jetpack/_inc/components/onboarding-tour/styles.scss Co-authored-by: Brad Jorsch --- .../my-jetpack/_inc/components/onboarding-tour/styles.scss | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/projects/packages/my-jetpack/_inc/components/onboarding-tour/styles.scss b/projects/packages/my-jetpack/_inc/components/onboarding-tour/styles.scss index 7fcc32f5d38cf..0f11c243b6bf8 100644 --- a/projects/packages/my-jetpack/_inc/components/onboarding-tour/styles.scss +++ b/projects/packages/my-jetpack/_inc/components/onboarding-tour/styles.scss @@ -43,9 +43,9 @@ $tour-footer-spacing: 16px; } } - button { - color: var(--jp-gray-0); - } + button { + color: var(--jp-gray-0); + } } .components-guide__footer { From 325a1d754ad0381f237c49a442b571d31f98cdc6 Mon Sep 17 00:00:00 2001 From: tbradsha <32492176+tbradsha@users.noreply.github.com> Date: Mon, 28 Apr 2025 13:34:50 -0600 Subject: [PATCH 17/25] Update projects/plugins/boost/app/assets/src/css/admin-banner.scss Co-authored-by: Brad Jorsch --- projects/plugins/boost/app/assets/src/css/admin-banner.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/plugins/boost/app/assets/src/css/admin-banner.scss b/projects/plugins/boost/app/assets/src/css/admin-banner.scss index 57618d63855eb..583fcd354c77d 100644 --- a/projects/plugins/boost/app/assets/src/css/admin-banner.scss +++ b/projects/plugins/boost/app/assets/src/css/admin-banner.scss @@ -53,7 +53,7 @@ &__title { font-size: 1.8rem; margin: 0 0 2rem; - // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 2.1rem; } From ecda0d1a0a7892e42b31588461d3669a126a32ff Mon Sep 17 00:00:00 2001 From: tbradsha <32492176+tbradsha@users.noreply.github.com> Date: Mon, 28 Apr 2025 13:35:23 -0600 Subject: [PATCH 18/25] Update projects/js-packages/components/components/boost-score-graph/style-tooltip.scss Co-authored-by: Brad Jorsch --- .../components/components/boost-score-graph/style-tooltip.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/js-packages/components/components/boost-score-graph/style-tooltip.scss b/projects/js-packages/components/components/boost-score-graph/style-tooltip.scss index c21fad616f377..8ba11761d0f92 100644 --- a/projects/js-packages/components/components/boost-score-graph/style-tooltip.scss +++ b/projects/js-packages/components/components/boost-score-graph/style-tooltip.scss @@ -43,7 +43,7 @@ $white: #fff; &__date { font-size: 1em; font-weight: 600; - // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values + // stylelint-disable-next-line declaration-property-unit-allowed-list -- this should be changed to a unitless value: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/#values line-height: 1.6em; } From a71986d4752ef3c40231b8f338e55c36dd25b860 Mon Sep 17 00:00:00 2001 From: tbradsha <32492176+tbradsha@users.noreply.github.com> Date: Mon, 28 Apr 2025 13:36:33 -0600 Subject: [PATCH 19/25] Update projects/packages/masterbar/src/admin-color-schemes/colors/_overrides.scss Co-authored-by: Brad Jorsch --- .../masterbar/src/admin-color-schemes/colors/_overrides.scss | 2 ++ 1 file changed, 2 insertions(+) diff --git a/projects/packages/masterbar/src/admin-color-schemes/colors/_overrides.scss b/projects/packages/masterbar/src/admin-color-schemes/colors/_overrides.scss index 498ff99d4adb4..f1194709fa065 100644 --- a/projects/packages/masterbar/src/admin-color-schemes/colors/_overrides.scss +++ b/projects/packages/masterbar/src/admin-color-schemes/colors/_overrides.scss @@ -15,6 +15,8 @@ #wpadminbar{ background: $masterbar-background !important; + + // Nav Unification - Masterbar - border below the Masterbar box-shadow: inset 0 -1px 0 $masterbar-background; // Calypso --color-masterbar-background } From 77bc6893f9f8635398006ffb4441a598f56a5259 Mon Sep 17 00:00:00 2001 From: tbradsha <32492176+tbradsha@users.noreply.github.com> Date: Mon, 28 Apr 2025 13:37:14 -0600 Subject: [PATCH 20/25] Update projects/packages/search/src/customberg/lib/wordpress-interface.scss Co-authored-by: Brad Jorsch --- .../search/src/customberg/lib/wordpress-interface.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/projects/packages/search/src/customberg/lib/wordpress-interface.scss b/projects/packages/search/src/customberg/lib/wordpress-interface.scss index 28db81c89e100..43bde8da6c996 100644 --- a/projects/packages/search/src/customberg/lib/wordpress-interface.scss +++ b/projects/packages/search/src/customberg/lib/wordpress-interface.scss @@ -3,9 +3,9 @@ * in order to remove our dependency on this experimental package. * * TODO: Replace these styles with our own styles. - * - * complementary-area-header */ + +// complementary-area-header .components-panel__header.interface-complementary-area-header__small { background: $white; padding-right: $grid-unit-05; From 907288bcebc7fe15aae48ddc1f4988349cdaacf8 Mon Sep 17 00:00:00 2001 From: tbradsha <32492176+tbradsha@users.noreply.github.com> Date: Mon, 28 Apr 2025 13:49:51 -0600 Subject: [PATCH 21/25] Update projects/packages/search/src/instant-search/components/search-result-expanded.scss Co-authored-by: Brad Jorsch --- .../src/instant-search/components/search-result-expanded.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/projects/packages/search/src/instant-search/components/search-result-expanded.scss b/projects/packages/search/src/instant-search/components/search-result-expanded.scss index d6788257c7d6e..32f90395588c5 100644 --- a/projects/packages/search/src/instant-search/components/search-result-expanded.scss +++ b/projects/packages/search/src/instant-search/components/search-result-expanded.scss @@ -56,8 +56,8 @@ $image-square-size: 128px; display: none; } -// Aspect ratio box trick -// See https://css-tricks.com/aspect-ratio-boxes/ + // Aspect ratio box trick + // See https://css-tricks.com/aspect-ratio-boxes/ position: relative; &::before { From 10d80e046119b9ac413fb374b9cc43f6b837290d Mon Sep 17 00:00:00 2001 From: tbradsha <32492176+tbradsha@users.noreply.github.com> Date: Mon, 28 Apr 2025 13:59:33 -0600 Subject: [PATCH 22/25] Preserve sectioning --- .../packages/masterbar/src/admin-menu/admin-menu.css | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/projects/packages/masterbar/src/admin-menu/admin-menu.css b/projects/packages/masterbar/src/admin-menu/admin-menu.css index 0e43d5877b8dc..0a9bcd3c09841 100644 --- a/projects/packages/masterbar/src/admin-menu/admin-menu.css +++ b/projects/packages/masterbar/src/admin-menu/admin-menu.css @@ -1,7 +1,5 @@ #adminmenu { margin: 0; - display: flex; - flex-direction: column; } /** @@ -347,6 +345,14 @@ color:var(--wp-admin-theme-color) } +/** Add new site button **/ + +/* stylelint-disable-next-line no-duplicate-selectors -- This is part of a larger section of changes. */ +#adminmenu { + display: flex; + flex-direction: column; +} + #adminmenu .menu-top[class*="/start?ref=calypso-sidebar"] { order: 99999; } From 846a27a0ea00096f7e3673396b368a88435ec29e Mon Sep 17 00:00:00 2001 From: tbradsha <32492176+tbradsha@users.noreply.github.com> Date: Mon, 28 Apr 2025 14:01:24 -0600 Subject: [PATCH 23/25] Condense selector further --- .../_inc/client/components/dash-item/style.scss | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/projects/plugins/jetpack/_inc/client/components/dash-item/style.scss b/projects/plugins/jetpack/_inc/client/components/dash-item/style.scss index 395483c804ee9..7958328def2f5 100644 --- a/projects/plugins/jetpack/_inc/client/components/dash-item/style.scss +++ b/projects/plugins/jetpack/_inc/client/components/dash-item/style.scss @@ -139,10 +139,11 @@ text-transform: uppercase; } -.jp-at-a-glance__left, -.jp-at-a-glance__right { +// conditional styles for content when items are inactive +.jp-dash-item__is-inactive { - .jp-dash-item__is-inactive { + .jp-at-a-glance__left &, + .jp-at-a-glance__right & { border: 1px solid $gray-5; background: #F9F9F6; box-shadow: none; @@ -159,10 +160,6 @@ height: 100%; } } -} - -// conditional styles for content when items are inactive -.jp-dash-item__is-inactive { .dops-card.dops-banner { flex-grow: unset; From 64aae5ad0366d435614e960bdc31c6a0dd6faa19 Mon Sep 17 00:00:00 2001 From: tbradsha <32492176+tbradsha@users.noreply.github.com> Date: Mon, 28 Apr 2025 14:16:01 -0600 Subject: [PATCH 24/25] Sectioning --- .../dashboard/components/notice/style.scss | 20 +++++++++---------- .../dashboard/components/notice/style.scss | 20 +++++++++---------- .../_inc/client/components/notice/style.scss | 20 +++++++++---------- 3 files changed, 30 insertions(+), 30 deletions(-) diff --git a/projects/packages/search/src/dashboard/components/notice/style.scss b/projects/packages/search/src/dashboard/components/notice/style.scss index a3b6b69749e59..ea7e82a3687ea 100644 --- a/projects/packages/search/src/dashboard/components/notice/style.scss +++ b/projects/packages/search/src/dashboard/components/notice/style.scss @@ -47,16 +47,6 @@ } } - .dops-notice__dismiss { - overflow: hidden; - color: $gray-lighten-10; - - &:hover, - &:focus { - color: $white; - } - } - &.is-success, &.is-error, &.is-warning, @@ -170,6 +160,16 @@ height: 24px; } } + + .dops-notice & { + overflow: hidden; + color: $gray-lighten-10; + + &:hover, + &:focus { + color: $white; + } + } } // specificity for general `a` elements within notice is too great diff --git a/projects/packages/wordads/src/dashboard/components/notice/style.scss b/projects/packages/wordads/src/dashboard/components/notice/style.scss index a3b6b69749e59..ea7e82a3687ea 100644 --- a/projects/packages/wordads/src/dashboard/components/notice/style.scss +++ b/projects/packages/wordads/src/dashboard/components/notice/style.scss @@ -47,16 +47,6 @@ } } - .dops-notice__dismiss { - overflow: hidden; - color: $gray-lighten-10; - - &:hover, - &:focus { - color: $white; - } - } - &.is-success, &.is-error, &.is-warning, @@ -170,6 +160,16 @@ height: 24px; } } + + .dops-notice & { + overflow: hidden; + color: $gray-lighten-10; + + &:hover, + &:focus { + color: $white; + } + } } // specificity for general `a` elements within notice is too great diff --git a/projects/plugins/jetpack/_inc/client/components/notice/style.scss b/projects/plugins/jetpack/_inc/client/components/notice/style.scss index 07c397cc0cca0..2f6cecb6fffd3 100644 --- a/projects/plugins/jetpack/_inc/client/components/notice/style.scss +++ b/projects/plugins/jetpack/_inc/client/components/notice/style.scss @@ -47,16 +47,6 @@ } } - .dops-notice__dismiss { - overflow: hidden; - color: $gray-lighten-10; - - &:hover, - &:focus { - color: $white; - } - } - &.is-success, &.is-error, &.is-warning, @@ -174,6 +164,16 @@ height: 24px; } } + + .dops-notice & { + overflow: hidden; + color: $gray-lighten-10; + + &:hover, + &:focus { + color: $white; + } + } } // specificity for general `a` elements within notice is too great From d4eae44d0a90165dbba7e734cc8fc40bf093b17e Mon Sep 17 00:00:00 2001 From: tbradsha <32492176+tbradsha@users.noreply.github.com> Date: Mon, 28 Apr 2025 14:29:18 -0600 Subject: [PATCH 25/25] Preserve more sectioning --- .../client/components/section-nav/style.scss | 16 +++-- .../extensions/blocks/image-compare/view.scss | 35 ++++++++--- .../jetpack/modules/shortcodes/css/style.css | 6 +- .../plugins/jetpack/scss/templates/_main.scss | 8 ++- .../custom-colors/css/colors-control.css | 61 ++++++++++++++----- 5 files changed, 98 insertions(+), 28 deletions(-) diff --git a/projects/plugins/jetpack/_inc/client/components/section-nav/style.scss b/projects/plugins/jetpack/_inc/client/components/section-nav/style.scss index 00abbc68c6227..942b41226ab67 100644 --- a/projects/plugins/jetpack/_inc/client/components/section-nav/style.scss +++ b/projects/plugins/jetpack/_inc/client/components/section-nav/style.scss @@ -49,10 +49,6 @@ @include breakpoint( "<660px" ) { margin-bottom: 9px; - - .dops-search.is-pinned { - height: 46px; - } } } @@ -423,3 +419,15 @@ padding: 3px 16px 5px; } } + +// -------- Search -------- +// stylelint-disable-next-line no-duplicate-selectors -- This is a styling section for a distinct purpose. +.dops-section-nav { + + @include breakpoint( "<660px" ) { + + .dops-search.is-pinned { + height: 46px; + } + } +} diff --git a/projects/plugins/jetpack/extensions/blocks/image-compare/view.scss b/projects/plugins/jetpack/extensions/blocks/image-compare/view.scss index 7be2338da4418..838f5623d551d 100644 --- a/projects/plugins/jetpack/extensions/blocks/image-compare/view.scss +++ b/projects/plugins/jetpack/extensions/blocks/image-compare/view.scss @@ -47,7 +47,6 @@ div.jx-control { margin-left: auto; width: 3px; background-color: currentColor; - color: #fff; } .vertical div.jx-control { @@ -66,8 +65,8 @@ div.jx-controller { bottom: 0; height: 60px; width: 9px; + margin-left: -3px; background-color: currentColor; - margin-left: -22.5px; /* 48px / 2 - 3px separator width */ } .vertical div.jx-controller { @@ -77,7 +76,6 @@ div.jx-controller { margin-right: auto; top: -3px; position: relative; - transform: translateY(-19.5px); } div.jx-arrow { @@ -101,19 +99,17 @@ div.jx-arrow { } div.jx-arrow.jx-left { + left: 2px; border-style: solid; border-width: 8px 8px 8px 0; border-color: transparent currentColor transparent transparent; - background-image: url(data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAyNCAyNCI+PHBhdGggZD0iTTEzLjQgMThMOCAxMmw1LjQtNiAxLjIgMS00LjYgNSA0LjYgNXoiLz48L3N2Zz4=); - left: 0; } div.jx-arrow.jx-right { + right: 2px; border-style: solid; border-width: 8px 0 8px 8px; border-color: transparent transparent transparent currentColor; - background-image: url(data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAyNCAyNCI+PHBhdGggZD0iTTEwLjYgNkw5LjQgN2w0LjYgNS00LjYgNSAxLjIgMSA1LjQtNnoiLz48L3N2Zz4=); - right: 0; } .vertical div.jx-arrow.jx-left { @@ -289,6 +285,10 @@ figure.wp-block-jetpack-image-compare figcaption { /** * Custom styling for handle. */ +// stylelint-disable no-duplicate-selectors -- This is part of a larger section of changes. +div.jx-control { + color: #fff; +} div.jx-controller, .vertical div.jx-controller { @@ -297,6 +297,16 @@ div.jx-controller, border-radius: 50%; } +div.jx-controller { + margin-left: -22.5px; /* 48px / 2 - 3px separator width */ +} + +.vertical div.jx-controller { + + /*top: -22.5px; */ + transform: translateY(-19.5px); +} + div.jx-arrow.jx-left, div.jx-arrow.jx-right, .vertical div.jx-arrow.jx-left, @@ -309,7 +319,18 @@ div.jx-arrow.jx-right, will-change: transform; } +div.jx-arrow.jx-left { + background-image: url(data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAyNCAyNCI+PHBhdGggZD0iTTEzLjQgMThMOCAxMmw1LjQtNiAxLjIgMS00LjYgNSA0LjYgNXoiLz48L3N2Zz4=); + left: 0; +} + +div.jx-arrow.jx-right { + background-image: url(data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAyNCAyNCI+PHBhdGggZD0iTTEwLjYgNkw5LjQgN2w0LjYgNS00LjYgNSAxLjIgMSA1LjQtNnoiLz48L3N2Zz4=); + right: 0; +} + div.vertical div.jx-arrow.jx-left, div.vertical div.jx-arrow.jx-right { transform: rotate(90deg); } +// stylelint-enable no-duplicate-selectors diff --git a/projects/plugins/jetpack/modules/shortcodes/css/style.css b/projects/plugins/jetpack/modules/shortcodes/css/style.css index 33ffcda40ba18..6d449f7213d02 100644 --- a/projects/plugins/jetpack/modules/shortcodes/css/style.css +++ b/projects/plugins/jetpack/modules/shortcodes/css/style.css @@ -36,7 +36,6 @@ body.presentation-wrapper-fullscreen-parent { .presentation-wrapper-fullscreen .nav-fullscreen-button { z-index: 20002; - background-image: url(../images/collapse.png); } @@ -133,6 +132,11 @@ body.presentation-wrapper-fullscreen-parent { opacity: 0.8; } +/* stylelint-disable-next-line no-duplicate-selectors -- This is part of the larger nav arrows section. */ +.presentation-wrapper-fullscreen .nav-fullscreen-button { + background-image: url(../images/collapse.png); +} + /** * 4. Styles for the autoplay overlay */ diff --git a/projects/plugins/jetpack/scss/templates/_main.scss b/projects/plugins/jetpack/scss/templates/_main.scss index 65939538017ca..64994bcfe62f3 100644 --- a/projects/plugins/jetpack/scss/templates/_main.scss +++ b/projects/plugins/jetpack/scss/templates/_main.scss @@ -59,6 +59,12 @@ }; } +.footer nav { + max-width: 550px; + margin: 0 auto; +} + + // ========================================================================== // Main navigation // ========================================================================== @@ -393,8 +399,8 @@ }; } +// stylelint-disable-next-line no-duplicate-selectors -- This is part of the larger footer nav section. .footer nav { - margin: 0 auto; max-width: 100%; a, diff --git a/projects/plugins/wpcomsh/custom-colors/css/colors-control.css b/projects/plugins/wpcomsh/custom-colors/css/colors-control.css index 054acd41fbc87..e6b69284f82ef 100644 --- a/projects/plugins/wpcomsh/custom-colors/css/colors-control.css +++ b/projects/plugins/wpcomsh/custom-colors/css/colors-control.css @@ -40,13 +40,12 @@ .color-grid.main li { height: 55px; width: 55px; + background-image: radial-gradient( center top, circle farthest-side, rgba(255, 255, 255, .35), rgba(255, 255, 255, 0) 80% ); background-position: center center; background-size: cover; + border: 2px solid #fff; border-radius: 50%; - background-image: none; - border: none; - box-shadow: inset 0 3px 5px rgba(0, 0, 0, 0.2), inset 0 -2px 0 rgba(255, 255, 255, 0.1); - margin: 0 13px 12px; + box-shadow: inset 0 -1px 4px rgba(0,0,0,0.1); } .disable-background .color-grid.main li, @@ -85,6 +84,7 @@ .color-grid li { background: #f1f1f1; border: 5px solid rgba(0,0,0,0.1); + border-width: 1px 1px 5px; font-size: 0; box-sizing: border-box; display: block; @@ -93,7 +93,6 @@ margin: 0; height: 50px; width: 80px; - border-width: 1px; } .color-grid li a { @@ -131,13 +130,13 @@ color: #fff; content: '\f406'; font-family: Noticons; + font-size: 21px; opacity: 0.4; float: left; position: relative; + left: 15px; + top: 18px; text-shadow: 0 0 2px rgba(0,0,0,0.4); - font-size: 20px; - left: 17px; - top: 20px; } .color-grid.main .selected { @@ -184,12 +183,9 @@ a.revert { display: none; padding: 10px 20px; position: relative; - left: -20px; + left: -20px; width: 260px; z-index: 2; - background-color: transparent; - border-top: 1px solid #333; - margin-top: 40px; } /* override new-customizer.css */ @@ -226,7 +222,7 @@ a.revert { clear: both; color: #646464; font-size: 13px; - margin: 30px 0 10px; + margin: 10px 0 10px; } /* override new-customizer.css */ @@ -321,13 +317,12 @@ a.revert { /* =Color Palettes ----------------------------------------------- */ .colour-lovers { + border-radius: 4px; float: left; margin: 0 18px 18px 0; height: 50px; width: 72px; position: relative; - border-radius: 2px; - overflow: hidden; } .colour-lovers li { @@ -756,6 +751,17 @@ input#iris { } /* Restored CSS from wp.com theme customizer updates */ + +/* stylelint-disable no-duplicate-selectors -- Preserving sectioning. */ +.colour-lovers { + border-radius: 2px; + overflow: hidden; +} + +.color-grid li { + border-width: 1px; +} + .color-grid.main { height: auto; text-align: center; @@ -765,6 +771,31 @@ input#iris { padding-top: 20px } +.color-grid.main li { + background-image: none; + border: none; + box-shadow: inset 0 3px 5px rgba(0, 0, 0, 0.2), inset 0 -2px 0 rgba(255, 255, 255, 0.1); + margin: 0 13px 12px; +} + +.color-grid .unavailable::before { + font-size: 20px; + left: 17px; + top: 20px; +} + +.the-picker { + background-color: transparent; + border-top: 1px solid #333; + margin-top: 40px; + padding-top: 10px; +} + +.the-picker p { + margin-top: 30px; +} +/* stylelint-enable no-duplicate-selectors */ + .the-picker p a { font-weight: 700; }