From 69e284a72d7e528a1f2502c3dcd4a124ac66262e Mon Sep 17 00:00:00 2001
From: Gio Lodi <gio@mokacoding.com>
Date: Wed, 5 Mar 2025 15:35:56 +1100
Subject: [PATCH] Use `env` node for all `IS_DEV_BUILD` CI assignments

In https://github.com/Automattic/studio/pull/998#discussion_r1978739613
I got confirmation that it's okay to use this approach for the env var
setting.

Given it's already in use, because it would not work otherwise, in the
Windows steps, this commit updates all the other steps so we have a
consistent setup.
---
 .buildkite/pipeline.yml | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml
index f21c71085..4f8e7cbe6 100644
--- a/.buildkite/pipeline.yml
+++ b/.buildkite/pipeline.yml
@@ -54,7 +54,6 @@ steps:
     command: |
       # call with bash explicitly because we run this on Windows, too
       bash .buildkite/commands/install-node-dependencies.sh
-      export IS_DEV_BUILD=true
       echo '--- :package: Package app for testing'
       npm run package
       echo '--- :playwright: Run End To End Tests'
@@ -67,6 +66,7 @@ steps:
     env:
       # See https://playwright.dev/docs/ci#debugging-browser-launches
       DEBUG: "pw:browser"
+      IS_DEV_BUILD: true
     matrix:
       - mac
       #- windows
@@ -87,8 +87,6 @@ steps:
 
           node ./scripts/prepare-dev-build-version.mjs
 
-          export IS_DEV_BUILD=true
-
           echo "--- :node: Building Binary"
           npm run make:macos-{{matrix}}
 
@@ -113,6 +111,8 @@ steps:
 
           echo "--- 📃 Notarizing Binary"
           bundle exec fastlane notarize_binary
+        env:
+          IS_DEV_BUILD: true
         plugins: [$CI_TOOLKIT_PLUGIN, $NVM_PLUGIN]
         artifact_paths:
           - out/**/*.app.zip
@@ -158,8 +158,6 @@ steps:
 
       .buildkite/commands/install-node-dependencies.sh
 
-      export IS_DEV_BUILD=true
-
       echo "--- :node: Generating Release Manifest"
       node ./scripts/prepare-dev-build-version.mjs
       node ./scripts/generate-releases-manifest.mjs
@@ -167,6 +165,8 @@ steps:
       echo "--- :fastlane: Distributing Dev Builds"
       install_gems
       bundle exec fastlane distribute_dev_build
+    env:
+      IS_DEV_BUILD: true
     artifact_paths:
       - out/releases.json
     agents: