Skip to content

Commit 09fa557

Browse files
author
Joshua Grosso
committed
Fix spawnHelper tests (post-rebase)
1 parent d1e1bcf commit 09fa557

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

src/utils/spawnHelper.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@ const buildSocketPath = () => tmp.dir()
3131
* (
3232
* spawnedProcess: ChildProcess,
3333
* callback: (
34-
* passwordOnly: boolean,
35-
* callback: (usernamePrompt: boolean) =>
34+
* output: string,
35+
* callback: (promptType: string) =>
3636
* (username: string, password: ?string, cancel: boolean) =>
3737
* void
38-
* )
38+
* ) => void
3939
* ),
4040
* reject: Error => Promise<void>
4141
* ) =>
@@ -220,7 +220,7 @@ const spawn = (command, opts = {}, callback) => new Promise(
220220

221221
resolve({
222222
code,
223-
stdout,
223+
stdout
224224
});
225225
});
226226
});

test/tests/utils/spawnHelper.spec.js

-4
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,6 @@ describe('spawnHelper', () => {
5858
it('resolves with the correct data on a successful exit', todo);
5959

6060
it('rejects on spawn error', todo);
61-
62-
it('rejects on non-0 exit code', todo);
6361
});
6462

6563
describe('winSpawn', () => {
@@ -111,8 +109,6 @@ describe('spawnHelper', () => {
111109
describe('buildSocket', () => {
112110
it('resolves the calling `Promise` with the correct data on a successful exit', todo);
113111

114-
it('only runs the successful close logic once', todo);
115-
116112
it('calls the close callback when the socket ends', todo);
117113

118114
it('calls the close callback when the socket closes', todo);

0 commit comments

Comments
 (0)