Skip to content

Commit 52b2a86

Browse files
authored
Moving to Microsoft.App API (#1)
1 parent 0525c52 commit 52b2a86

File tree

6 files changed

+13
-23
lines changed

6 files changed

+13
-23
lines changed

.github/workflows/with-dapr-build.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ jobs:
7979
- name: Deploy bicep
8080
uses: azure/CLI@v1
8181
with:
82-
azcliversion: 2.29.2
8382
inlineScript: |
8483
az group create -g ${{ secrets.RESOURCE_GROUP }} -l canadacentral
8584
az deployment group create -g ${{ secrets.RESOURCE_GROUP }} -f ./with-dapr/deploy/main.bicep \

.github/workflows/with-fqdn-build.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ jobs:
8080
- name: Deploy bicep
8181
uses: azure/CLI@v1
8282
with:
83-
azcliversion: 2.29.2
8483
inlineScript: |
8584
az group create -g ${{ secrets.RESOURCE_GROUP }} -l canadacentral
8685
az deployment group create -g ${{ secrets.RESOURCE_GROUP }} -f ./with-fqdn/deploy/main.bicep \

with-dapr/deploy/container-app.bicep

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,18 @@ param environmentVars array = []
1212
@secure()
1313
param containerRegistryPassword string
1414

15-
resource containerApp 'Microsoft.Web/containerApps@2021-03-01' = {
15+
resource containerApp 'Microsoft.App/containerApps@2022-01-01-preview' = {
1616
name: containerAppName
17-
kind: 'containerapp'
1817
location: location
1918
properties: {
20-
kubeEnvironmentId: environmentId
19+
managedEnvironmentId: environmentId
2120
configuration: {
2221
secrets: [
2322
{
2423
name: 'registry-password'
2524
value: containerRegistryPassword
2625
}
27-
]
26+
]
2827
registries: [
2928
{
3029
server: containerRegistry
@@ -36,6 +35,11 @@ resource containerApp 'Microsoft.Web/containerApps@2021-03-01' = {
3635
external: isExternalIngress
3736
targetPort: containerPort
3837
}
38+
dapr: {
39+
enabled: true
40+
appPort: containerPort
41+
appId: containerAppName
42+
}
3943
}
4044
template: {
4145
containers: [
@@ -48,11 +52,6 @@ resource containerApp 'Microsoft.Web/containerApps@2021-03-01' = {
4852
scale: {
4953
minReplicas: 0
5054
}
51-
dapr: {
52-
enabled: true
53-
appPort: containerPort
54-
appId: containerAppName
55-
}
5655
}
5756
}
5857
}

with-dapr/deploy/environment.bicep

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ param location string
22
param environmentName string
33
param logAnalyticsWorkspaceName string = 'logs-${environmentName}'
44

5-
65
resource logAnalyticsWorkspace 'Microsoft.OperationalInsights/workspaces@2020-03-01-preview' = {
76
name: logAnalyticsWorkspaceName
87
location: location
@@ -17,12 +16,10 @@ resource logAnalyticsWorkspace 'Microsoft.OperationalInsights/workspaces@2020-03
1716
})
1817
}
1918

20-
resource environment 'Microsoft.Web/kubeEnvironments@2021-02-01' = {
19+
resource environment 'Microsoft.App/managedEnvironments@2022-01-01-preview' = {
2120
name: environmentName
2221
location: location
2322
properties: {
24-
type: 'managed'
25-
internalLoadBalancerEnabled: false
2623
appLogsConfiguration: {
2724
destination: 'log-analytics'
2825
logAnalyticsConfiguration: {

with-fqdn/deploy/container-app.bicep

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,18 @@ param environmentVars array = []
1212
@secure()
1313
param containerRegistryPassword string
1414

15-
resource containerApp 'Microsoft.Web/containerApps@2021-03-01' = {
15+
resource containerApp 'Microsoft.App/containerApps@2022-01-01-preview' = {
1616
name: containerAppName
17-
kind: 'containerapp'
1817
location: location
1918
properties: {
20-
kubeEnvironmentId: environmentId
19+
managedEnvironmentId: environmentId
2120
configuration: {
2221
secrets: [
2322
{
2423
name: 'registry-password'
2524
value: containerRegistryPassword
2625
}
27-
]
26+
]
2827
registries: [
2928
{
3029
server: containerRegistry

with-fqdn/deploy/environment.bicep

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ param location string
22
param environmentName string
33
param logAnalyticsWorkspaceName string = 'logs-${environmentName}'
44

5-
65
resource logAnalyticsWorkspace 'Microsoft.OperationalInsights/workspaces@2020-03-01-preview' = {
76
name: logAnalyticsWorkspaceName
87
location: location
@@ -17,12 +16,10 @@ resource logAnalyticsWorkspace 'Microsoft.OperationalInsights/workspaces@2020-03
1716
})
1817
}
1918

20-
resource environment 'Microsoft.Web/kubeEnvironments@2021-02-01' = {
19+
resource environment 'Microsoft.App/managedEnvironments@2022-01-01-preview' = {
2120
name: environmentName
2221
location: location
2322
properties: {
24-
type: 'managed'
25-
internalLoadBalancerEnabled: false
2623
appLogsConfiguration: {
2724
destination: 'log-analytics'
2825
logAnalyticsConfiguration: {

0 commit comments

Comments
 (0)