Resolve PR feedback

Author: heaths

.gitignore

@@ -1,4 +1,4 @@
-target
+target/
 Cargo.lock
 *.rs.bk
 .vscode/
@@ -9,6 +9,7 @@ sample/
 \#*\#
 \.#*
 *~
+*.code-workspace
 *.swp
 *.swo
 *.vim

sdk/core/src/macros.rs

@@ -26,7 +26,7 @@
 #[macro_export]
 macro_rules! setters {
     (@single $name:ident : $typ:ty => $transform:expr) => {
-        // TODO: Declare with_$name when https://github.com/rust-lang/rust/issues/29599 is fixed.
+        // TODO: Declare using idiomatic with_$name when https://github.com/Azure/azure-sdk-for-rust/issues/292 is resolved.
         pub fn $name<T: ::std::convert::Into<$typ>>(self, $name: T) -> Self {
             let $name: $typ = $name.into();
             Self  {
@@ -186,10 +186,7 @@ mod test {
 
     impl Default for Options {
         fn default() -> Self {
-            Options {
-                a: None,
-                b: 1,
-            }
+            Options { a: None, b: 1 }
         }
     }
 
@@ -213,8 +210,7 @@ mod test {
 
     #[test]
     fn test_setters() {
-        let options = Options::default()
-            .a("test".to_owned());
+        let options = Options::default().a("test".to_owned());
 
         assert_eq!(Some("test".to_owned()), options.a);
         assert_eq!(1, options.b);

sdk/core/src/options.rs

@@ -4,6 +4,17 @@ use std::sync::Arc;
 use std::time::Duration;
 
 /// Client options allow customization of policies, retry options, and more.
+///
+/// # Examples
+///
+/// You can override default options and even add your own per-call or per-retry policies:
+///
+/// ```
+/// use azure_core::{ClientOptions, RetryOptions, TelemetryOptions};
+/// let options = ClientOptions::default()
+///     .retry(RetryOptions::default().max_retries(10u32))
+///     .telemetry(TelemetryOptions::default().application_id("my-application"));
+/// ```
 #[derive(Clone, Debug, Default)]
 pub struct ClientOptions {
     // TODO: Expose transport override.
@@ -24,6 +35,16 @@ pub struct ClientOptions {
 }
 
 impl ClientOptions {
+    /// A mutable reference to per-call policies.
+    pub fn mut_per_call_policies(&mut self) -> &mut Vec<Arc<dyn Policy>> {
+        &mut self.per_call_policies
+    }
+
+    /// A mutable reference to per-retry policies.
+    pub fn mut_per_retry_policies(&mut self) -> &mut Vec<Arc<dyn Policy>> {
+        &mut self.per_retry_policies
+    }
+
     setters! {
         per_call_policies: Vec<Arc<dyn Policy>> => per_call_policies,
         per_retry_policies: Vec<Arc<dyn Policy>> => per_retry_policies,
@@ -144,7 +165,7 @@ impl TransportOptions {
 }
 
 impl Default for TransportOptions {
-    /// Creates an instance of the ```TransportOptions``` using the enabled HTTP client.
+    /// Creates an instance of the `TransportOptions` using the enabled HTTP client.
     fn default() -> Self {
         TransportOptions {
             http_client: new_http_client(),

sdk/core/src/pipeline.rs

@@ -50,11 +50,8 @@ impl Pipeline {
         pipeline.extend_from_slice(&per_call_policies);
         pipeline.extend_from_slice(&options.per_call_policies);
 
-        pipeline.push(Arc::new(TelemetryPolicy::new(
-            crate_name,
-            crate_version,
-            &options.telemetry,
-        )));
+        let telemetry_policy = TelemetryPolicy::new(crate_name, crate_version, &options.telemetry);
+        pipeline.push(Arc::new(telemetry_policy));
 
         let retry_policy = options.retry.to_policy();
         pipeline.push(retry_policy);

sdk/core/src/policies/retry_policies/exponential_retry.rs

@@ -21,9 +21,9 @@ pub struct ExponentialRetryPolicy {
 impl ExponentialRetryPolicy {
     pub(crate) fn new(delay: Duration, max_retries: u32, max_delay: Duration) -> Self {
         ExponentialRetryPolicy {
-            delay: delay,
-            max_retries: max_retries,
-            max_delay: max_delay,
+            delay,
+            max_retries,
+            max_delay,
         }
     }
 

sdk/core/src/policies/retry_policies/fixed_retry.rs

@@ -20,9 +20,9 @@ pub struct FixedRetryPolicy {
 impl FixedRetryPolicy {
     pub(crate) fn new(delay: Duration, max_retries: u32, max_delay: Duration) -> Self {
         FixedRetryPolicy {
-            delay: delay,
-            max_retries: max_retries,
-            max_delay: max_delay,
+            delay,
+            max_retries,
+            max_delay,
         }
     }
 

sdk/cosmos/src/clients/cosmos_client.rs

@@ -5,11 +5,11 @@ use crate::resources::permission::AuthorizationToken;
 use crate::resources::ResourceType;
 use crate::{requests, ReadonlyString};
 
-use azure_core::*;
 use azure_core::pipeline::Pipeline;
 use azure_core::Context;
 use azure_core::HttpClient;
 use azure_core::Request;
+use azure_core::*;
 use http::request::Builder as RequestBuilder;
 use http::{header, HeaderValue};
 use ring::hmac;
@@ -42,8 +42,7 @@ impl CosmosOptions {
     pub fn with_client(client: Arc<dyn HttpClient>) -> Self {
         Self {
             options: ClientOptions::default()
-                .retry(RetryOptions::default()
-                    .mode(RetryMode::Fixed))
+                .retry(RetryOptions::default().mode(RetryMode::Fixed))
                 .transport(TransportOptions::new(client)),
         }
     }