check clippy as part of the build (#485)

* check clippy as part of the build

* fix path to manifest

Co-authored-by: Brian Caswell <[email protected]>

Author: bmc-msft

.github/workflows/build.yml

@@ -19,13 +19,16 @@ jobs:
           toolchain: stable
           profile: minimal
           override: true
-          components: rustfmt
+          components: rustfmt, clippy
 
       - uses: Swatinem/rust-cache@v1
 
       - name: cargo fmt sdk
         run: cargo fmt --all -- --check
 
+      - name: cargo clippy sdk
+        run: cargo clippy --all
+
       - name: cargo fmt services
         run: |
           ./eng/scripts/check_json_format.sh
@@ -80,13 +83,19 @@ jobs:
         toolchain: stable
         profile: minimal
         override: true
-        components: rustfmt
+        components: rustfmt, clippy
 
     - uses: Swatinem/rust-cache@v1
 
     - name: services check
       run: cargo check --manifest-path services/Cargo.toml --all
 
+    - name: services clippy
+      run: cargo clippy --manifest-path services/Cargo.toml --all
+
+    - name: services fmt
+      run: cargo fmt --manifest-path services/Cargo.toml --all -- --check
+
     - name: display free disk space
       run: df -h /
       if: ${{ always() }}
@@ -156,15 +165,13 @@ jobs:
         toolchain: stable
         profile: minimal
         override: true
-        components: rustfmt
+        components: rustfmt, clippy
     - name: fmt check
-      run: |
-        cd azure-sdk-for-rust/services/autorust
-        cargo fmt --all -- --check
+      run: cargo fmt --all --manifest-path azure-sdk-for-rust/services/autorust/Cargo.toml -- --check
+    - name: clippy check
+      run: cargo clippy --all --manifest-path azure-sdk-for-rust/services/autorust/Cargo.toml
     - name: unit tests
-      run:  |
-        cd azure-sdk-for-rust/services/autorust
-        cargo test --lib
+      run: cargo test --lib --manifest-path azure-sdk-for-rust/services/autorust/Cargo.toml
     - name: git clone Azure/azure-rest-api-specs
       uses: actions/checkout@v2
       with:

sdk/core/src/policies/retry_policies/exponential_retry.rs

@@ -31,7 +31,7 @@ impl super::RetryPolicy for ExponentialRetryPolicy {
             return true;
         }
 
-        let first_retry_time = first_retry_time.get_or_insert_with(|| Local::now());
+        let first_retry_time = first_retry_time.get_or_insert_with(Local::now);
         let max_delay = chrono::Duration::from_std(self.max_delay)
             .unwrap_or_else(|_| chrono::Duration::max_value());
 

sdk/cosmos/src/lib.rs

@@ -1,3 +1,7 @@
+#![allow(clippy::enum_variant_names)]
+#![allow(clippy::new_without_default)]
+#![allow(clippy::module_inception)]
+
 /*!
 # The Cosmos DB crate.
 

sdk/iot_hub/src/service/mod.rs

@@ -233,8 +233,7 @@ impl ServiceClient {
             }
         }
 
-        let iot_hub_name =
-            iot_hub_name.ok_or_else(|| FromConnectionStringError::FailedToGetHostname)?;
+        let iot_hub_name = iot_hub_name.ok_or(FromConnectionStringError::FailedToGetHostname)?;
 
         let key_name = key_name.ok_or(FromConnectionStringError::FailedToGetSharedAccessKey)?;
 

sdk/storage/src/core/shared_access_signature/service_sas.rs

@@ -128,8 +128,7 @@ impl BlobSharedAccessSignature {
             "".to_string(), // rsct
         ];
 
-        let signed = sign(&self.key, &content.join("\n"));
-        signed
+        sign(&self.key, &content.join("\n"))
     }
 }
 

sdk/storage/src/data_lake/clients/data_lake_client.rs

@@ -112,7 +112,7 @@ impl DataLakeClient {
 
         let per_call_policies = Vec::new();
         let auth_policy: Arc<dyn azure_core::Policy<DataLakeContext>> =
-            Arc::new(AuthorizationPolicy::new(bearer_token.clone()));
+            Arc::new(AuthorizationPolicy::new(bearer_token));
 
         // take care of adding the AuthorizationPolicy as **last** retry policy.
         // Policies can change the url and/or the headers and the AuthorizationPolicy

sdk/storage/src/data_lake/clients/file_system_client.rs

@@ -69,7 +69,7 @@ impl FileSystemClient {
         path_name: &str,
         options: CreatePathOptions<'_>,
     ) -> Result<CreatePathResponse, crate::Error> {
-        let mut request = self.prepare_request_pipeline(&path_name, http::Method::PUT);
+        let mut request = self.prepare_request_pipeline(path_name, http::Method::PUT);
         let contents = DataLakeContext {};
         let mut pipeline_context = PipelineContext::new(ctx, contents);
 
@@ -117,6 +117,6 @@ impl FileSystemClient {
     }
 
     pub(crate) fn pipeline(&self) -> &Pipeline<DataLakeContext> {
-        &self.data_lake_client.pipeline()
+        self.data_lake_client.pipeline()
     }
 }

sdk/storage/src/lib.rs

@@ -1,6 +1,8 @@
 //! Azure storage crate for the unofficial Microsoft Azure SDK for Rust. This crate is part of a collection of crates: for more information please refer to [https://github.com/azure/azure-sdk-for-rust](https://github.com/azure/azure-sdk-for-rust).
 #![recursion_limit = "256"]
 #![allow(clippy::needless_lifetimes)]
+#![allow(clippy::enum_variant_names)]
+#![allow(clippy::new_without_default)]
 
 #[macro_use]
 extern crate log;

services/autorust/codegen/src/codegen.rs

@@ -54,7 +54,7 @@ impl CodeGen {
             .into_iter()
             .filter(|x| x.starts_with("application/json"))
             .map(|x| x.to_string())
-            .nth(0)
+            .next()
             .unwrap_or_else(|| "application/json".to_string())
     }
 }

services/autorust/codegen/src/spec.rs

@@ -95,14 +95,14 @@ impl Spec {
     }
 
     pub fn consumes(&self) -> Vec<&String> {
-        let versions: Vec<_> = self
+        let mut versions: Vec<_> = self
             .docs()
             .values()
             .filter(|doc| !doc.paths().is_empty())
             .map(|api| &api.consumes)
+            .flatten()
             .collect();
 
-        let mut versions: Vec<_> = versions.into_iter().flatten().collect();
         versions.sort_unstable();
         versions
     }

services/autorust/openapi/src/schema.rs

@@ -53,6 +53,7 @@ pub struct Response {
     pub x_ms_error_response: Option<bool>,
 }
 
+#[allow(clippy::large_enum_variant)]
 #[derive(Serialize, Deserialize, Clone, Debug, PartialEq)]
 #[serde(untagged)]
 pub enum AdditionalProperties {