Skip to content

generate Clients for services #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ctaggart opened this issue Oct 20, 2020 · 3 comments · Fixed by #527
Closed

generate Clients for services #50

ctaggart opened this issue Oct 20, 2020 · 3 comments · Fixed by #527
Assignees
@cataggar
Labels
CodeGen Issues that relate to code generation

Comments

@ctaggart
Copy link
Contributor

The generated code for each operation currently takes a Configuration. This is how opening-generator currently does it. The other Azure SDKs generate Clients instead. It may be possible to do it that way instead. We will need to evaluate the trade-offs.
@ctaggart ctaggart mentioned this issue Oct 20, 2020
Merged
2 tasks
@ctaggart
Copy link
Contributor Author

I'm leaving it as OperationConfig for now.

@cataggar
Copy link
Member

In #417, @bmc-msft provides examples for other Azure SDK languages, which pass the configuration into clients. I is time to reevaluate this in combination with moving to the pipeline architecture #294.

@cataggar cataggar reopened this Oct 19, 2021
@cataggar cataggar changed the title for services, generate a Client or pass in a config to each operation generate Clients for services Oct 19, 2021
@cataggar cataggar added the CodeGen Issues that relate to code generation label Oct 19, 2021
@cataggar cataggar self-assigned this Oct 19, 2021
@bmc-msft
Copy link
Contributor

Note, I was primarily concerned about the API version being user configurable. They almost all have some sort of configuration that's passed in on init. Just api-version isn't configurable.

@cataggar cataggar mentioned this issue Nov 19, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cataggar cataggar

Labels
CodeGen Issues that relate to code generation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

into_future for services cataggar/azure-sdk-for-rust
3 participants
@ctaggart @bmc-msft @cataggar