Skip to content

CertificateClient::new does not allow for optional api-versions #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Billy-Sheppard opened this issue Nov 15, 2021 · 1 comment
Closed

CertificateClient::new does not allow for optional api-versions #516

Billy-Sheppard opened this issue Nov 15, 2021 · 1 comment

Comments

@Billy-Sheppard
Copy link
Contributor

Billy-Sheppard commented Nov 15, 2021 •
edited
Loading

Tracking for point brought up in PR#334

How do they specify an optional api-version? If leaving for later, please open a tracking issue. IIRC, we were going to have a new_with_options or something like that which took options which allow that, among other things like user-defined policies. We have that in some clients now, like cosmos and/or storage.

Originally posted by @heaths in #334 (comment)
@Billy-Sheppard Billy-Sheppard mentioned this issue Nov 15, 2021
Merged
@cataggar cataggar added the KeyVault Key Vault label Nov 15, 2021
@heaths heaths removed the KeyVault Key Vault label Nov 15, 2021
@heaths
Copy link
Member

heaths commented Nov 15, 2021

@cataggar this is needed for all clients, per Azure SDK guidelines. We are currently tracking this as part of #466.

@heaths heaths closed this as completed Nov 15, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@heaths @Billy-Sheppard @cataggar