Skip to content

generated crates need to support x-ms-pageable #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bmc-msft opened this issue May 2, 2022 · 2 comments
Closed

generated crates need to support x-ms-pageable #736

bmc-msft opened this issue May 2, 2022 · 2 comments
Labels
CodeGen Issues that relate to code generation

Comments

@bmc-msft
Copy link
Contributor

bmc-msft commented May 2, 2022

In the specs, the way to support pageable is to provide the field x-ms-pageable in the operation. This is described in the autorest specification here:

https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-pageable

We should probably use azure_core::Pageable and generate an into_stream automatically if the x-ms-pageable is provided.
@cataggar cataggar added the CodeGen Issues that relate to code generation label May 2, 2022
@cataggar
Copy link
Member

cataggar commented May 2, 2022

This is very much needed. This duplicates #218, but has a better description. I think we may be able to close #341.

@cataggar
Copy link
Member

cataggar commented Jun 6, 2022

Fixed by #742.

@cataggar cataggar closed this as completed Jun 6, 2022
@bmc-msft bmc-msft linked a pull request Jul 20, 2022 that will close this issue
specify additional conditional headers for blob & container operations #951
Merged
@bmc-msft bmc-msft removed a link to a pull request Jul 20, 2022
specify additional conditional headers for blob & container operations #951
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CodeGen Issues that relate to code generation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bmc-msft @cataggar