From 2d998d170deb90363a2a3adaa4c52f742d0a34d1 Mon Sep 17 00:00:00 2001 From: Brian Caswell Date: Thu, 21 Sep 2023 11:19:29 -0400 Subject: [PATCH] remove lifetime workaround now that this is fixed The underlying issue was fixed in rust 1.69.0. Our minimum supported rust is now 1.70.0 (set in azure_core), which means this workaround is no longer needed. Ref: https://github.com/rust-lang/rust/issues/63033 --- sdk/identity/Cargo.toml | 2 -- sdk/identity/src/client_credentials_flow/mod.rs | 2 -- sdk/identity/src/federated_credentials_flow/mod.rs | 2 -- sdk/identity/src/refresh_token.rs | 2 -- 4 files changed, 8 deletions(-) diff --git a/sdk/identity/Cargo.toml b/sdk/identity/Cargo.toml index 277d1ea1eb..accb4aa891 100644 --- a/sdk/identity/Cargo.toml +++ b/sdk/identity/Cargo.toml @@ -25,8 +25,6 @@ log = "0.4" async-trait = "0.1" openssl = { version = "0.10.46", optional=true } uuid = { version = "1.0", features = ["v4"] } -# work around https://github.com/rust-lang/rust/issues/63033 -fix-hidden-lifetime-bug = "0.2" pin-project = "1.0" [dev-dependencies] diff --git a/sdk/identity/src/client_credentials_flow/mod.rs b/sdk/identity/src/client_credentials_flow/mod.rs index ec9f42ad04..cec21ed573 100644 --- a/sdk/identity/src/client_credentials_flow/mod.rs +++ b/sdk/identity/src/client_credentials_flow/mod.rs @@ -48,8 +48,6 @@ use std::sync::Arc; use url::{form_urlencoded, Url}; /// Perform the client credentials flow -#[allow(clippy::manual_async_fn)] -#[fix_hidden_lifetime_bug::fix_hidden_lifetime_bug] pub async fn perform( http_client: Arc, client_id: &str, diff --git a/sdk/identity/src/federated_credentials_flow/mod.rs b/sdk/identity/src/federated_credentials_flow/mod.rs index 3e3292aa5f..16f8e36d73 100644 --- a/sdk/identity/src/federated_credentials_flow/mod.rs +++ b/sdk/identity/src/federated_credentials_flow/mod.rs @@ -48,8 +48,6 @@ use std::sync::Arc; use url::{form_urlencoded, Url}; /// Perform the client credentials flow -#[allow(clippy::manual_async_fn)] -#[fix_hidden_lifetime_bug::fix_hidden_lifetime_bug] pub async fn perform( http_client: Arc, client_id: &str, diff --git a/sdk/identity/src/refresh_token.rs b/sdk/identity/src/refresh_token.rs index 519326f527..a84c7dacf0 100644 --- a/sdk/identity/src/refresh_token.rs +++ b/sdk/identity/src/refresh_token.rs @@ -13,8 +13,6 @@ use std::sync::Arc; use url::{form_urlencoded, Url}; /// Exchange a refresh token for a new access token and refresh token -#[allow(clippy::manual_async_fn)] -#[fix_hidden_lifetime_bug::fix_hidden_lifetime_bug] pub async fn exchange( http_client: Arc, tenant_id: &str,