[ENG-4673] Add search by ORCID functionality to admin (#11129)

## Purpose
Add search by ORCID field to users search admin page

## Ticket
https://openscience.atlassian.net/browse/ENG-4673

Author: antkryt

admin/users/forms.py

@@ -14,6 +14,7 @@ class UserSearchForm(forms.Form):
     guid = forms.CharField(label='guid', min_length=5, max_length=5, required=False)  # TODO: Move max to 6 when needed
     name = forms.CharField(label='name', required=False)
     email = forms.EmailField(label='email', required=False)
+    orcid = forms.CharField(label='orcid', required=False)
 
 
 class MergeUserForm(forms.Form):

admin/users/views.py

@@ -25,6 +25,7 @@
 from framework.auth.core import generate_verification_key
 
 from website import search
+from website.settings import EXTERNAL_IDENTITY_PROFILE
 
 from osf.models.admin_log_entry import (
     update_admin_log,
@@ -126,6 +127,7 @@ def form_valid(self, form):
         guid = form.cleaned_data['guid']
         name = form.cleaned_data['name']
         email = form.cleaned_data['email']
+        orcid = form.cleaned_data['orcid']
         if name:
             return redirect(reverse('users:search-list', kwargs={'name': name}))
 
@@ -148,6 +150,18 @@ def form_valid(self, form):
 
             return redirect(reverse('users:user', kwargs={'guid': guid}))
 
+        if orcid:
+            external_id_provider = EXTERNAL_IDENTITY_PROFILE.get('OrcidProfile')
+            user = get_user(external_id_provider=external_id_provider, external_id=orcid)
+
+            if not user:
+                return page_not_found(
+                    self.request,
+                    AttributeError(f'resource with id "{orcid}" not found.')
+                )
+
+            return redirect(reverse('users:user', kwargs={'guid': user._id}))
+
         return super().form_valid(form)
 
 

admin_tests/users/test_views.py

@@ -402,7 +402,14 @@ def test_correct_view_permissions(self):
 class TestUserSearchView(AdminTestCase):
 
     def setUp(self):
-        self.user_1 = AuthUserFactory(fullname='Broken Matt Hardy')
+        self.user_1 = AuthUserFactory(
+            fullname='Broken Matt Hardy',
+            external_identity={
+                settings.EXTERNAL_IDENTITY_PROFILE.get('OrcidProfile'): {
+                    '1234-5678': 'VERIFIED'
+                }
+            }
+        )
         self.user_2 = AuthUserFactory(fullname='Jeff Hardy')
         self.user_3 = AuthUserFactory(fullname='Reby Sky')
         self.user_4 = AuthUserFactory(fullname='King Maxel Hardy')
@@ -425,6 +432,14 @@ def test_search_user_by_guid(self):
         assert response.status_code == 302
         assert response.headers['location'] == f'/users/{self.user_1.guids.first()._id}/'
 
+        form_data = {
+            'guid': 'wrong'
+        }
+        form = UserSearchForm(data=form_data)
+        assert form.is_valid()
+        response = self.view.form_valid(form)
+        assert response.status_code == 404
+
     def test_search_user_by_name(self):
         form_data = {
             'name': 'Hardy'
@@ -455,6 +470,14 @@ def test_search_user_by_username(self):
         assert response.status_code == 302
         assert response.headers['location'] == f'/users/{self.user_1.guids.first()._id}/'
 
+        form_data = {
+            'email': '[email protected]'
+        }
+        form = UserSearchForm(data=form_data)
+        assert form.is_valid()
+        response = self.view.form_valid(form)
+        assert response.status_code == 404
+
     def test_search_user_by_alternate_email(self):
         form_data = {
             'email': self.user_2_alternate_email
@@ -487,6 +510,24 @@ def test_search_user_list_case_insensitive(self):
         for user in results:
             assert 'Hardy' in user.fullname
 
+    def test_search_user_by_orcid(self):
+        form_data = {
+            'orcid': '1234-5678'
+        }
+        form = UserSearchForm(data=form_data)
+        assert form.is_valid()
+        response = self.view.form_valid(form)
+        assert response.status_code == 302
+        assert response.headers['location'] == f'/users/{self.user_1.guids.first()._id}/'
+
+        form_data = {
+            'orcid': '1234-5678-90'
+        }
+        form = UserSearchForm(data=form_data)
+        assert form.is_valid()
+        response = self.view.form_valid(form)
+        assert response.status_code == 404
+
 
 class TestGetLinkView(AdminTestCase):