Skip to content

Commit 361959b

Browse files
Adam RaineDevtools-frontend LUCI CQ
Adam Raine
authored and
Devtools-frontend LUCI CQ
committedJan 6, 2025·
[Lantern] Ignore document requests that failed
Github issue: GoogleChrome/lighthouse#16289 Bug: None Change-Id: I5cc4743de112c8b6fe2bec9d1a094ce331ca8cf8 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6112617 Reviewed-by: Connor Clark <cjamcl@chromium.org> Commit-Queue: Adam Raine <asraine@chromium.org>
1 parent 585254f commit 361959b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎front_end/models/trace/lantern/core/NetworkAnalyzer.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -598,7 +598,7 @@ class NetworkAnalyzer {
598598
static findLastDocumentForUrl<T extends Lantern.NetworkRequest>(records: Array<T>, resourceUrl: string): T|undefined {
599599
// equalWithExcludedFragments is expensive, so check that the resourceUrl starts with the request url first
600600
const matchingRequests = records.filter(
601-
request => request.resourceType === 'Document' &&
601+
request => request.resourceType === 'Document' && !request.failed &&
602602
// Note: `request.url` should never have a fragment, else this optimization gives wrong results.
603603
resourceUrl.startsWith(request.url) && UrlUtils.equalWithExcludedFragments(request.url, resourceUrl),
604604
);

0 commit comments

Comments
 (0)
Please sign in to comment.