Break up Fields unit tests

Author: charleskawczynski

.buildkite/pipeline.yml

@@ -486,18 +486,18 @@ steps:
         key: unit_field
         command:
           - "julia --color=yes --check-bounds=yes --project=.buildkite test/Fields/unit_field.jl"
-          - "julia --color=yes --check-bounds=yes --project=.buildkite test/Fields/benchmark_field_multi_broadcast_fusion.jl"
+          - "julia --color=yes --check-bounds=yes --project=.buildkite test/Fields/unit_fieldvector.jl"
+          - "julia --color=yes --check-bounds=yes --project=.buildkite test/Fields/unit_field_multi_broadcast_fusion.jl"
           - "julia --color=yes --check-bounds=yes --project=.buildkite test/Fields/convergence_field_integrals.jl"
-          - "julia --color=yes --check-bounds=yes --project=.buildkite test/Fields/inference_repro.jl"
 
       - label: "Unit: field cuda"
         key: unit_field_cuda
         command:
           - "julia --project=.buildkite -e 'using CUDA; CUDA.versioninfo()'"
           - "julia --color=yes --check-bounds=yes --project=.buildkite test/Fields/unit_field.jl"
-          - "julia --color=yes --check-bounds=yes --project=.buildkite test/Fields/benchmark_field_multi_broadcast_fusion.jl"
+          - "julia --color=yes --check-bounds=yes --project=.buildkite test/Fields/unit_fieldvector.jl"
+          - "julia --color=yes --check-bounds=yes --project=.buildkite test/Fields/unit_field_multi_broadcast_fusion.jl"
           - "julia --color=yes --check-bounds=yes --project=.buildkite test/Fields/convergence_field_integrals.jl"
-          - "julia --color=yes --check-bounds=yes --project=.buildkite test/Fields/inference_repro.jl"
         env:
           CLIMACOMMS_DEVICE: "CUDA"
         agents:
@@ -1257,9 +1257,26 @@ steps:
   - group: "Perf: Fields"
     steps:
 
-      - label: "Perf: Field broadcast"
-        key: "cpu_field_perf"
-        command: "julia --color=yes --project=.buildkite test/Fields/field_opt.jl"
+      - label: "Perf: Field"
+        key: cpu_field_perf
+        command:
+          - "julia --color=yes --project=.buildkite test/Fields/field_opt.jl"
+          - "julia --color=yes --project=.buildkite test/Fields/benchmark_field_multi_broadcast_fusion.jl"
+          - "julia --color=yes --project=.buildkite test/Fields/inference_repro.jl"
+        agents:
+          slurm_mem: 20GB
+
+      - label: "GPU Perf: Field"
+        key: gpu_field_perf
+        command:
+          - "julia --color=yes --project=.buildkite test/Fields/field_opt.jl"
+          - "julia --color=yes --project=.buildkite test/Fields/benchmark_field_multi_broadcast_fusion.jl"
+          - "julia --color=yes --project=.buildkite test/Fields/inference_repro.jl"
+        env:
+          CLIMACOMMS_DEVICE: "CUDA"
+        agents:
+          slurm_mem: 20GB
+          slurm_gpus: 1
 
   - group: "Perf: Benchmark scripts"
     steps:

test/Fields/field_opt.jl

@@ -393,49 +393,4 @@ using JET
     @test_opt ifelsekernel!(S, ρ)
 end
 
-@testset "dss of FieldVectors" begin
-    function field_vec(center_space, face_space)
-        Y = Fields.FieldVector(
-            c = map(Fields.coordinate_field(center_space)) do coord
-                FT = Spaces.undertype(center_space)
-                (;
-                    ρ = FT(coord.lat + coord.long),
-                    uₕ = Geometry.Covariant12Vector(
-                        FT(coord.lat),
-                        FT(coord.long),
-                    ),
-                )
-            end,
-            f = map(Fields.coordinate_field(face_space)) do coord
-                FT = Spaces.undertype(face_space)
-                (; w = Geometry.Covariant3Vector(FT(coord.lat + coord.long)))
-            end,
-        )
-        return Y
-    end
-
-    fv = field_vec(toy_sphere(Float64)...)
-
-    c_copy = copy(getproperty(fv, :c))
-    f_copy = copy(getproperty(fv, :f))
-
-    # Test that dss_buffer is created and has the correct keys
-    dss_buffer = Spaces.create_dss_buffer(fv)
-    @test haskey(dss_buffer, :c)
-    @test haskey(dss_buffer, :f)
-
-    # Test weighted_dss! with and without preallocated buffer
-    Spaces.weighted_dss!(fv, dss_buffer)
-    @test getproperty(fv, :c) ≈ Spaces.weighted_dss!(c_copy)
-    @test getproperty(fv, :f) ≈ Spaces.weighted_dss!(f_copy)
-
-    fv = field_vec(toy_sphere(Float64)...)
-    c_copy = copy(getproperty(fv, :c))
-    f_copy = copy(getproperty(fv, :f))
-
-    Spaces.weighted_dss!(fv)
-    @test getproperty(fv, :c) ≈ Spaces.weighted_dss!(c_copy)
-    @test getproperty(fv, :f) ≈ Spaces.weighted_dss!(f_copy)
-end
-
 nothing