Skip to content

Commit 2e8b6c5

Browse files
build(deps): bump react and react-dom from 18.3.1 to 19.1.0 (#1532)
* build(deps): bump react from 18.3.1 to 19.1.0 Bumps [react](https://github.com/facebook/react/tree/HEAD/packages/react) from 18.3.1 to 19.1.0. - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.1.0/packages/react) --- updated-dependencies: - dependency-name: react dependency-version: 19.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: david-yz-liu <[email protected]>
1 parent 652dbef commit 2e8b6c5

15 files changed

+85
-98
lines changed

.github/dependabot.yml

+4
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@ updates:
1313
ag-grid:
1414
patterns:
1515
- "ag-grid-*"
16+
react:
17+
patterns:
18+
- "react"
19+
- "react-dom"
1620
stylelint:
1721
patterns:
1822
- "stylelint*"

.pnp.cjs

+37-47
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@
5858
- Added Haskell Language Server (HLS) Guide
5959
- Upgraded to Stackage lts-23.18
6060
- Added `stylish-haskell` dependency and ran it on `.hs` source files
61+
- Upgraded to React v19
62+
- Added dependabot group for `react` and `react-dom`
6163

6264
## [0.6.0] - 2024-06-24
6365

js/components/common/__tests__/TimetableLoading.test.js

+12-12
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { Description } from "../react_modal.js.jsx"
55
describe("Displays correct content based on timetable availability", () => {
66
beforeEach(() => cleanup())
77

8-
it("displays a timetable when there is only one session", () => {
8+
it("displays a timetable when there is only one session", async () => {
99
const courseInfo = {
1010
course: {
1111
name: "CSC108H1",
@@ -31,13 +31,13 @@ describe("Displays correct content based on timetable availability", () => {
3131
}
3232

3333
render(<Description course={courseInfo.course} sessions={courseInfo.sessions} />)
34-
expect(screen.getByText(/CSC108H1/)).not.toBeNull()
35-
expect(screen.getByText(/LEC0101/)).not.toBeNull()
36-
expect(screen.getByText("sample description")).not.toBeNull()
37-
expect(screen.getByText("Beyonce")).not.toBeNull()
34+
await screen.findByText(/CSC108H1/)
35+
await screen.findByText(/LEC0101/)
36+
await screen.findByText("sample description")
37+
await screen.findByText("Beyonce")
3838
})
3939

40-
it("displays a timetable when there is more than one session", () => {
40+
it("displays a timetable when there is more than one session", async () => {
4141
const courseInfo = {
4242
course: {
4343
name: "CSC108H1",
@@ -72,13 +72,13 @@ describe("Displays correct content based on timetable availability", () => {
7272
}
7373

7474
render(<Description course={courseInfo.course} sessions={courseInfo.sessions} />)
75-
expect(screen.getAllByText(/CSC108H1/)).not.toBeNull()
76-
expect(screen.getByText(/LEC0101/)).not.toBeNull()
77-
expect(screen.getByText(/LEC0202/)).not.toBeNull()
78-
expect(screen.getByText("David. Liu")).not.toBeNull()
75+
await screen.findAllByText(/CSC108H1/)
76+
await screen.findByText(/LEC0101/)
77+
await screen.findByText(/LEC0202/)
78+
await screen.findByText("David. Liu")
7979
})
8080

81-
it("displays reminder when there's no timetable information", () => {
81+
it("displays reminder when there's no timetable information", async () => {
8282
const courseInfo = {
8383
course: {
8484
name: "CSC108H1",
@@ -95,6 +95,6 @@ describe("Displays correct content based on timetable availability", () => {
9595
}
9696

9797
render(<Description course={courseInfo.course} sessions={courseInfo.sessions} />)
98-
expect(screen.getByText("No timetable information available")).not.toBeNull()
98+
await screen.findByText("No timetable information available")
9999
})
100100
})

package.json

+6-3
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@
3838
"jquery": "^3.7.1",
3939
"leaflet": "^1.9.3",
4040
"lodash": "^4.17.21",
41-
"react": "^18.3.1",
42-
"react-dom": "^18.3.1",
41+
"react": "^19.1.0",
42+
"react-dom": "19.1.0",
4343
"react-leaflet": "^4.2.1",
4444
"react-modal": "^3.16.1",
4545
"react-tooltip": "^5.28.0"
@@ -83,5 +83,8 @@
8383
"webpack-dev-server": "^5.1.0",
8484
"webpack-merge": "^6.0.1"
8585
},
86-
"packageManager": "[email protected]"
86+
"packageManager": "[email protected]",
87+
"resolutions": {
88+
"pretty-format/react-is": "19.1.0"
89+
}
8790
}

0 commit comments

Comments
 (0)