Updating to use better locators and variable names

Author: Max Saperstone

selenified/src/test/java/CoverosIT.java

@@ -19,13 +19,14 @@ public void seleniumSearch() {
         // use this object to manipulate the app
         App app = this.apps.get();
         // identify our elements
-        Element search = app.newElement(Locator.ID, "s");
+        Element searchBox = app.newElement(Locator.ID, "s");
         // perform the search
-        search.type("selenium");
-        search.submit();
-        // wait for the search to run
-        app.waitFor().titleEquals("You searched for selenium - Coveros");
-        app.azzert().titleEquals("You searched for selenium - Coveros");
+        searchBox.type("selenified");
+        searchBox.submit();
+        // wait for some search results to come back
+        app.newElement(Locator.CLASSNAME, "header-blog").waitForState().displayed();
+        // ensure the title shows what we expect
+        app.azzert().titleEquals("You searched for selenified - Coveros");
         // close out the test
         finish();
     }

selenium/src/test/java/CoverosIT.java

@@ -1,52 +1,46 @@
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.WebElement;
-import org.openqa.selenium.firefox.FirefoxDriver;
-import org.openqa.selenium.support.ui.ExpectedCondition;
-import org.openqa.selenium.support.ui.WebDriverWait;
+import org.openqa.selenium.chrome.ChromeDriver;
+import org.openqa.selenium.support.ui.*;
 import org.testng.annotations.Test;
 
+import static org.testng.AssertJUnit.assertEquals;
+
 public class CoverosIT {
 
     @Test
     public void seleniumSearch() {
         //for linux/mac installations
-//        System.setProperty("webdriver.gecko.driver", "lib/geckodriver");
+//        System.setProperty("webdriver.chrome.driver", "lib/chromedriver");
         //for windows installations
-//        System.setProperty("webdriver.gecko.driver", "lib/geckodriver.exe");
-        // Create a new instance of the Firefox driver
+//        System.setProperty("webdriver.gecko.driver", "lib/chromedriver.exe");
+        // Create a new instance of the Chrome driver
         // Notice that the remainder of the code relies on the interface,
         // not the implementation.
-        WebDriver driver = new FirefoxDriver();
+        WebDriver driver = new ChromeDriver();
 
         // And now use this to visit Google
         driver.get("https://www.coveros.com");
         // Alternatively the same thing can be done like this
         // driver.navigate().to("https://www.coveros.com");
 
         // Find the text input element by its name
-        WebElement element = driver.findElement(By.id("s"));
+        WebElement searchBox = driver.findElement(By.id("s"));
 
         // Enter something to search for
-        element.sendKeys("selenium");
+        searchBox.sendKeys("selenium");
 
         // Now submit the form. WebDriver will find the form for us from the element
-        element.submit();
-
-        // Check the title of the page
-        System.out.println("Page title is: " + driver.getTitle());
+        searchBox.submit();
 
         // Coveros's search is rendered dynamically with JavaScript.
         // Wait for the page to load, timeout after 10 seconds
-        (new WebDriverWait(driver, 10)).until(new ExpectedCondition<Boolean>() {
-            public Boolean apply(WebDriver d) {
-                return d.getTitle().startsWith("You searched for");
-            }
-        });
-
-        // Should see: "cheese! - Google Search"
-        System.out.println("Page title is: " + driver.getTitle());
+        new WebDriverWait(driver, 10)
+                .until(ExpectedConditions.visibilityOfElementLocated(By.className("header-blog")));
 
+        // Should see: "You searched for selenified - Coveros"
+        assertEquals(driver.getTitle(), "You searched for selenium - Coveros");
 
         //Close the browser
         driver.quit();