Skip to content

[FEATURE] Abstracting FilterItem class #7706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sashafiesta opened this issue Mar 4, 2025 · 0 comments · May be fixed by #8132
Open

[FEATURE] Abstracting FilterItem class #7706

sashafiesta opened this issue Mar 4, 2025 · 0 comments · May be fixed by #8132
Labels
area: api Issue or PR is related to API

Comments

@sashafiesta
Copy link

sashafiesta commented Mar 4, 2025 •
edited
Loading

Right now all types of filters are hardcoded.

Create/src/main/java/com/simibubi/create/content/logistics/filter/FilterItem.java

Line 52 in 9e67360

REGULAR, ATTRIBUTE, PACKAGE;

It might be great to allow addon developers to add their own filter types! (I'm currently experiencing a problem adding my own kind of filter :<)
@sashafiesta sashafiesta changed the title [FEATURE] Abstracting filter creation [FEATURE] Abstracting FilterItem class Mar 4, 2025
@IThundxr IThundxr added the area: api Issue or PR is related to API label Mar 4, 2025
@ChiefArug ChiefArug linked a pull request Mar 27, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: api Issue or PR is related to API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apify filters ChiefArug/Create
2 participants
@sashafiesta @IThundxr