Skip to content

Track edges sometimes have no edge group #8425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vap0r1ze opened this issue May 5, 2025 · 1 comment · May be fixed by #8428
Open

Track edges sometimes have no edge group #8425

Vap0r1ze opened this issue May 5, 2025 · 1 comment · May be fixed by #8428

Comments

@Vap0r1ze
Copy link
Contributor

Vap0r1ze commented May 5, 2025

It seems to happen to random edges every time a player joins, as a result of the first received TrackGraphSyncPacket saying they are part of the NULL_GROUP group type. It also seems to only happen to edges that have a signal on them.

This is very hard for me to debug because I'm unsure what the purpose of the "null" edge group and "passive" edge group are. @simibubi If you have the time I'd appreciate if you could help me out with understanding that part of the graph code whenever u have the time, since you've written most of it.

Tested on the latest mc1.20.1/dev with the following: create_tracks.dat.

Screenshots of an example because my video uploads are failing
@Vap0r1ze
Copy link
Contributor Author

Vap0r1ze commented May 6, 2025

After more debugging I think I actually understand the purpose of the null group type, and I think I've figured out the actual issue:

If TrackGraphSync::sendFullGraphTo sends the client a TrackEdge but it's points do not exist in the same packet, the client will throw away those points since it has no instance of them yet.

It seems like this would happen pretty reliably on any server with a graph over 500 nodes and a healthy amount of signals. Although I only noticed it because of #8345

@Vap0r1ze Vap0r1ze linked a pull request May 6, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant