Skip to content

[Bug] performZeropadding leads to incorrect results in 2-D #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Vandermode opened this issue Apr 4, 2025 · 2 comments
Closed

[Bug] performZeropadding leads to incorrect results in 2-D #201

Vandermode opened this issue Apr 4, 2025 · 2 comments

Comments

@Vandermode
Copy link

As the title suggested, I compare the results of vkFFT and numpy/scipy FFT under C2C convolution with zero padding setting (Note I used the normal FFT + elementwise multiplication + IFFT, rather than performConvolution mode)

The results are shown below, it can be seen vkFFT works as expectation in 1D but fails completely in 2-D case.

Image

Image

Likely a potential bug, since it works in 1-D case, though I am not sure if my application in 2-D is set correctly.

My test code is available in
https://github.com/Vandermode/pyvkfft/blob/3d054f27272c2529a8d45798709a2ae544bdfb8c/examples/test_fft_conv.py

(need to install my adapted version of pyvkfft to support performZeropadding mode in python

DTolm added a commit that referenced this issue Apr 16, 2025
-Fixed incorrect zero padding check
-added check for null locale in strcpy
@DTolm
Copy link
Owner

DTolm commented Apr 16, 2025

Hello,

I have identified the issue with the 2D zeropadding, your test now passes on my local machine.

Thank you for reporting it!

Best regards,
Dmitrii

@Vandermode
Copy link
Author

Hi, I tested it again, and it works, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants