Skip to content

Failing CI tests #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ltfschoen opened this issue Feb 21, 2020 · 2 comments
Closed

Failing CI tests #32

ltfschoen opened this issue Feb 21, 2020 · 2 comments
Labels
-size-m Task of medium size +P1 Highest priority, address as soon as possible [tests]

Comments

@ltfschoen
Copy link
Collaborator

When the CI Test build runs cargo test in here https://github.com/DataHighway-DHX/node/runs/459859012, it's generating the following error:

   Compiling js-sys v0.3.35
error[E0603]: struct `Memory` is private
    --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/js-sys-0.3.35/src/lib.rs:4873:60
     |
4873 |                 let mem = buf.unchecked_ref::<WebAssembly::Memory>();
     |                                                            ^^^^^^ this struct is private
     |
note: the struct `Memory` is defined here
    --> /home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/js-sys-0.3.35/src/lib.rs:3516:5
     |
3516 |     #[wasm_bindgen]
     |     ^^^^^^^^^^^^^^^
     = note: this error originates in an attribute macro (in Nightly builds, run with -Z macro-backtrace for more info)

@ltfschoen
Copy link
Collaborator Author

This could be because we're not installing the latest Rust versions in the CI Test section https://github.com/DataHighway-DHX/node/blob/master/.github/workflows/rust.yml#L55, only in the CI Linting section https://github.com/DataHighway-DHX/node/blob/master/.github/workflows/rust.yml#L86

@ltfschoen
Copy link
Collaborator Author

This is caused by rust-lang/rust#69334, we've made changes here to try and fix it by using older versions of Rust Nightly that are known to work #29

@ltfschoen ltfschoen added +P1 Highest priority, address as soon as possible -size-m Task of medium size [tests] labels Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-size-m Task of medium size +P1 Highest priority, address as soon as possible [tests]
Projects
None yet
Development

No branches or pull requests

1 participant