Skip to content

Commit b05aba1

Browse files
carlbennettDavnit
authored andcommitted
Fix incorrect BNLS_SERVERLOGONCHALLENGE/PROOF responses (#8)
* Demote disclaimer to header level 2 * Fix incorrect BNLS_SERVERLOGONCHALLENGE response * Fix incorrect BNLS_SERVERLOGONPROOF response
1 parent b2e0ba0 commit b05aba1

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

BNLSProtocol/BNLSParse.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -954,7 +954,7 @@ private OutPacketBuffer onServerLogonChallenge(InPacketBuffer in){
954954
for (int Y = 0; Y < SRP.BIGINT_SIZE; Y++)
955955
reply.addByte(salt[Y]);
956956
for (int Y = 0; Y < SRP.BIGINT_SIZE; Y++)
957-
reply.addDWord(B[Y]);
957+
reply.addByte(B[Y]);
958958
return reply;
959959
}
960960
private OutPacketBuffer onServerLogonProof(InPacketBuffer in){
@@ -992,7 +992,6 @@ private OutPacketBuffer onServerLogonProof(InPacketBuffer in){
992992
byte[] M2 = reservedSRPs[slot].getM2(reservedSRPs[slot].get_A(), reservedSRPs[slot].get_B());
993993
OutPacketBuffer reply = new OutPacketBuffer(BNLS_SERVERLOGONPROOF);
994994
reply.addDWord(slot);
995-
if (equal(M1, M2))
996995
reply.addDWord((equal(M1, M2) ? 0x01 : 0x00));
997996
for(int Y = 0; Y < 5; Y++)
998997
reply.addDWord(M1[Y]);
@@ -1112,4 +1111,4 @@ private OutPacketBuffer onUnknown(InPacketBuffer in){
11121111
return null;
11131112
}
11141113

1115-
}// end of BNLS Parse class
1114+
}// end of BNLS Parse class

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# JBLS
22
Java Battle.net Logon Server- Java implementation of ValhallaLegend's BNLS protocol for interacting with Battle.net classic servers.
33

4-
# Disclaimer
4+
## Disclaimer
55
You hereby acknowledge that JBLS is offered as-is and without warranty,
66
expressed or implied. JBLS is not sponsored by Blizzard Entertainment or its
77
subsidiaries in absolutely any way. Battle.net&trade; is a registered trademark

0 commit comments

Comments
 (0)