Skip to content

Commit 7383509

Browse files
committed
SOF-7010: chore ==> rename orbitalList to orbitalListByStability
1 parent 44196fb commit 7383509

File tree

3 files changed

+18
-6
lines changed

3 files changed

+18
-6
lines changed

src/context/providers/HubbardJContextProvider.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,10 @@ export class HubbardJContextProvider extends HubbardUContextProvider {
8181
enum: [elementWithLabel],
8282
},
8383
atomicOrbital: {
84-
enum: orbitals.length > 0 ? orbitals : this.orbitalList,
84+
enum:
85+
orbitals.length > 0
86+
? orbitals
87+
: this.orbitalListByStability,
8588
default:
8689
orbitals.length > 0
8790
? orbitals[orbitals.length - 1]

src/context/providers/HubbardUContextProvider.js

+6-3
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export class HubbardUContextProvider extends mix(JSONSchemaFormDataProvider).wit
2424
super(config);
2525
this.uniqueElements = this.material?.Basis?.uniqueElements || [];
2626
// orbitals are sorted according to stability (Madelung's rule)
27-
this.orbitalList = [
27+
this.orbitalListByStability = [
2828
"1s",
2929
"2s",
3030
"2p",
@@ -91,7 +91,7 @@ export class HubbardUContextProvider extends mix(JSONSchemaFormDataProvider).wit
9191
return data.element !== element; // break when first match is found
9292
});
9393
const valenceOrbitals = valenceConfig.map((item) => item.orbitalName.toLowerCase());
94-
return sortArrayByOrder(valenceOrbitals, this.orbitalList);
94+
return sortArrayByOrder(valenceOrbitals, this.orbitalListByStability);
9595
};
9696

9797
getElementSymbol = (elementWithLabel) => {
@@ -139,7 +139,10 @@ export class HubbardUContextProvider extends mix(JSONSchemaFormDataProvider).wit
139139
enum: [elementWithLabel],
140140
},
141141
atomicOrbital: {
142-
enum: orbitals.length > 0 ? orbitals : this.orbitalList,
142+
enum:
143+
orbitals.length > 0
144+
? orbitals
145+
: this.orbitalListByStability,
143146
default:
144147
orbitals.length > 0
145148
? orbitals[orbitals.length - 1]

src/context/providers/HubbardVContextProvider.js

+8-2
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,10 @@ export class HubbardVContextProvider extends HubbardUContextProvider {
122122
enum: [elementWithLabel],
123123
},
124124
atomicOrbital: {
125-
enum: orbitals.length > 0 ? orbitals : this.orbitalList,
125+
enum:
126+
orbitals.length > 0
127+
? orbitals
128+
: this.orbitalListByStability,
126129
default:
127130
orbitals.length > 0
128131
? orbitals[orbitals.length - 1]
@@ -143,7 +146,10 @@ export class HubbardVContextProvider extends HubbardUContextProvider {
143146
enum: [elementWithLabel],
144147
},
145148
atomicOrbital2: {
146-
enum: orbitals.length > 0 ? orbitals : this.orbitalList,
149+
enum:
150+
orbitals.length > 0
151+
? orbitals
152+
: this.orbitalListByStability,
147153
default:
148154
orbitals.length > 0
149155
? orbitals[orbitals.length - 1]

0 commit comments

Comments
 (0)