SOF-7449: break cutoffFromPseudo into two smaller functions

Author: pranabdas

src/context/providers/PlanewaveCutoffsContextProvider.js

@@ -40,23 +40,38 @@ export class PlanewaveCutoffsContextProvider extends mix(ContextProvider).with(
         return cutoffConfig[this.application.name];
     }
 
+    /**
+     * @summary Find cutoff values corresponding to wavefunction or charge
+     * density with accuracy level in the pseudo method data
+     * @param data {Object}: the data object from pseudo method data
+     * @param cutoffEntity {String}: "wavefunction", or "density"
+     * @param accuracyLevel {String}: "standard", "high", or "low"
+     * @return {number}: if cutoff value present returns value else return 0
+     */
+    _cutoffFromPseudoData = (data, cutoffEntity, accuracyLevel = "standard") => {
+        const cutoff = data?.cutoffs?.[cutoffEntity] || [];
+        return cutoff.find((obj) => obj.accuracy_level === accuracyLevel)?.value ?? 0;
+    };
+
+    /**
+     * @summary Set highest cutoff of all elements present, in case wavefunction
+     * cutoff is present but no charge density cutoff, set charge density cutoff
+     * to 4 or 8 times that of wavefunction cutoff
+     * @return {Array<number>}: tuple of wavefunction and density cutoffs
+     */
     get _cutoffsFromPseudos() {
-        const pseudos = this.methodData?.pseudo || [];
         let ecutwfc = 0;
         let ecutrho = 0;
+        const pseudos = this.methodData?.pseudo || [];
 
         pseudos.forEach((data) => {
-            const wfcCutoff = data?.cutoffs?.wavefunction || [];
-            const wfcCutoffStandardAccuracy =
-                wfcCutoff.find((obj) => obj.accuracy_level === "standard")?.value ?? 0;
+            const ecutwfcStandard = this._cutoffFromPseudoData(data, "wavefunction");
+            const ecutrhoStandard = this._cutoffFromPseudoData(data, "density");
             // set the highest cutoff of all elements
-            ecutwfc = Math.max(ecutwfc, wfcCutoffStandardAccuracy);
+            ecutwfc = Math.max(ecutwfc, ecutwfcStandard);
 
-            const rhoCutoff = data?.cutoffs?.density || [];
-            const rhoCutoffStandardAccuracy =
-                rhoCutoff.find((obj) => obj.accuracy_level === "standard")?.value ?? 0;
-            if (rhoCutoffStandardAccuracy > ecutrho) {
-                ecutrho = rhoCutoffStandardAccuracy;
+            if (ecutrhoStandard > ecutrho) {
+                ecutrho = ecutrhoStandard;
             } else {
                 // if rho cutoff is not present, set it based on wfc cutoff
                 // if it is ultrasoft pseudopotential set rho cutoff 8 times