Skip to content

Commit b8eab86

Browse files
committed
update jumpto center
1 parent d243b39 commit b8eab86

File tree

3 files changed

+14
-16
lines changed

3 files changed

+14
-16
lines changed

android-pdf-viewer/build.gradle

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ ext {
1010

1111
libraryDescription = 'Android view for displaying PDFs rendered with PdfiumAndroid'
1212

13-
siteUrl = 'https://github.com/barteksc/AndroidPdfViewer'
14-
gitUrl = 'https://github.com/barteksc/AndroidPdfViewer.git'
13+
siteUrl = 'https://github.com/FIT-16CLC-InteractionBook/AndroidPdfViewer'
14+
gitUrl = 'https://github.com/FIT-16CLC-InteractionBook/AndroidPdfViewer.git'
1515

16-
libraryVersion = '3.2.0-beta.1'
16+
libraryVersion = '3.3.0-beta.1'
1717

1818
developerId = 'barteksc'
1919
developerName = 'Bartosz Schiller'
@@ -31,7 +31,7 @@ android {
3131
minSdkVersion 14
3232
targetSdkVersion 28
3333
versionCode 1
34-
versionName "3.2.0-beta.1"
34+
versionName "3.3.0-beta.1"
3535
}
3636

3737
}

android-pdf-viewer/src/main/java/com/github/barteksc/pdfviewer/PDFView.java

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -290,21 +290,18 @@ public void jumpTo(int page, boolean withAnimation) {
290290
return;
291291
}
292292

293+
// assumes swiping horizontal and snapping centre
294+
293295
page = pdfFile.determineValidPageNumberFrom(page);
294-
float offset = page == 0 ? 0 : -pdfFile.getPageOffset(page, zoom);
295-
if (swipeVertical) {
296-
if (withAnimation) {
297-
animationManager.startYAnimation(currentYOffset, offset);
298-
} else {
299-
moveTo(currentXOffset, offset);
300-
}
296+
float offset = page == 0 ? 0 : -pdfFile.getPageOffset(page, getZoom());
297+
offset += pdfFile.getPageSpacing(page, getZoom()) / 2f;
298+
299+
if (withAnimation) {
300+
animationManager.startXAnimation(getCurrentXOffset(), offset);
301301
} else {
302-
if (withAnimation) {
303-
animationManager.startXAnimation(currentXOffset, offset);
304-
} else {
305-
moveTo(offset, currentYOffset);
306-
}
302+
moveTo(offset, getCurrentYOffset());
307303
}
304+
308305
showPage(page);
309306
}
310307

build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ buildscript {
33
repositories {
44
google()
55
jcenter()
6+
maven { url 'https://jitpack.io' }
67
}
78
dependencies {
89
classpath 'com.android.tools.build:gradle:3.4.2'

0 commit comments

Comments
 (0)