Fix #4603 (Keep stacktrace when re-throwing exception with JsonMappingException) (#5054)

Author: JooHyukKim

release-notes/VERSION

@@ -7,6 +7,9 @@ Versions: 3.x (for earlier see VERSION-2.x)
 
 3.0.0-rc3 (not yet released)
 
+#4603: Keep full stacktrace when re-throwing exception with
+  `DatabindException` during deserialization
+ (fixed by Joo-Hyuk K)
 #5065: Change default for `DateTimeFeature.ONE_BASED_MONTHS` to `true` in 3.0
 #5066: Move date/time `SerializationFeature`s into `DateTimeFeature` (3.0)
 #5067: Move date/time `DeserializationFeature`s into `DateTimeFeature` (3.0)

src/main/java/tools/jackson/databind/deser/SettableAnyProperty.java

@@ -251,7 +251,8 @@ public void set(DeserializationContext ctxt, Object instance, Object propName, O
         }
     }
 
-    protected abstract void _set(DeserializationContext ctxt, Object instance, Object propName, Object value) throws Exception;
+    protected abstract void _set(DeserializationContext ctxt, Object instance, Object propName, Object value)
+        throws Exception;
 
     /*
     /**********************************************************************

src/main/java/tools/jackson/databind/deser/SettableBeanProperty.java

@@ -1,6 +1,7 @@
 package tools.jackson.databind.deser;
 
 import java.lang.annotation.Annotation;
+import java.lang.reflect.InvocationTargetException;
 
 import tools.jackson.core.*;
 import tools.jackson.core.util.InternCache;
@@ -636,9 +637,18 @@ protected void _throwAsJacksonE(JsonParser p, Exception e) throws JacksonExcepti
     {
         ClassUtil.throwIfRTE(e);
         ClassUtil.throwIfJacksonE(e);
-        // let's wrap the innermost problem
-        Throwable th = ClassUtil.getRootCause(e);
-        throw DatabindException.from(p, ClassUtil.exceptionMessage(th), th);
+
+        // 10-Apr-2025: [databind#4603] no more unwrapping, retain exception
+        // Throwable th = ClassUtil.getRootCause(e);
+        // ... except for InvocationTargetException which we still unwrap as it
+        // adds no value
+        if (e instanceof InvocationTargetException ite) {
+            Throwable t = ite.getTargetException();
+            ClassUtil.throwIfRTE(t);
+            ClassUtil.throwIfJacksonE(t);
+            throw DatabindException.from(p, ClassUtil.exceptionMessage(t), t);
+        }
+        throw DatabindException.from(p, ClassUtil.exceptionMessage(e), e);
     }
 
     // 10-Oct-2015, tatu: _Should_ be deprecated, too, but its remaining

src/test/java/tools/jackson/databind/exc/UnwrapRootCause4603Test.java

@@ -0,0 +1,90 @@
+package tools.jackson.databind.exc;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import org.junit.jupiter.api.Test;
+
+import tools.jackson.core.JacksonException;
+import tools.jackson.databind.*;
+import tools.jackson.databind.testutil.DatabindTestUtil;
+
+import com.fasterxml.jackson.annotation.*;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+// [databind#4603]: Stop unwrapping root cause
+public class UnwrapRootCause4603Test
+    extends DatabindTestUtil
+{
+    @SuppressWarnings("serial")
+    static class CustomException extends RuntimeException {
+        public CustomException(String message) {
+            super(message);
+        }
+    }
+
+    static class Feature1347DeserBean
+    {
+        int value;
+
+        public void setValue(int x) {
+            throw new CustomException("setValue, fail on purpose");
+        }
+    }
+
+    static class AnySetterBean
+    {
+        protected Map<String, Integer> props = new HashMap<String, Integer>();
+
+        @JsonAnySetter
+        public void prop(String name, Integer value) {
+            throw new CustomException("@JsonAnySetter, fail on purpose");
+        }
+    }
+
+    static class Baz {
+        private String qux;
+
+        @JsonCreator
+        public Baz(@JsonProperty("qux") String qux) {
+            this.qux = qux;
+        }
+
+        public String getQux() {
+            return qux;
+        }
+    }
+
+    private static final String JSON = a2q("{'value':3}");
+
+    private final ObjectMapper MAPPER = newJsonMapper();
+
+    // Whether disabled or enabled, should get ArithmeticException
+    @Test
+    public void testExceptionWrappingConfiguration()
+        throws Exception
+    {
+        JacksonException disabledResult = _tryDeserializeWith(MAPPER);
+        // !!! TODO: ought to be DatabindException
+        assertInstanceOf(JacksonException.class, disabledResult);
+        // We are throwing exception inside a setter, but InvocationTargetException
+        // will still be unwrapped
+        assertInstanceOf(CustomException.class, disabledResult.getCause());
+    }
+
+    private JacksonException _tryDeserializeWith(ObjectMapper mapper) {
+        return assertThrows(JacksonException.class,
+                () -> mapper.readValue(JSON, Feature1347DeserBean.class)
+        );
+    }
+
+    @Test
+    public void testWithAnySetter()
+            throws Exception
+    {
+        DatabindException result = assertThrows(DatabindException.class,
+                () -> MAPPER.readValue(a2q("{'a':3}"), AnySetterBean.class));
+        assertInstanceOf(CustomException.class, result.getCause());
+    }
+}

src/test/java/tools/jackson/databind/introspect/TestAutoDetect.java

@@ -182,7 +182,7 @@ public void testVisibilityConfigOverridesForDeser() throws Exception
             /*Feature1347DeserBean bean =*/
             MAPPER.readValue(JSON, Feature1347DeserBean.class);
             fail("Should not pass");
-        } catch (DatabindException e) { // should probably be something more specific but...
+        } catch (JacksonException e) { // should probably be something more specific but...
             verifyException(e, "Should NOT get called");
         }