Fix #4771: Support OBJECT shape for QNAME serialization and deserialization. #4968
Conversation
mcvayc
changed the title
mcvayc
changed the title
|
I'm sorry about the whitespace changes. I'll see if I can fix those without another round of approvals. |
|
Great! I'll hope to review this soon, maybe tomorrow. And since we have CLA already, can proceed with merge if all goes well! Thank you in advance. |
This commit fixes FasterXML#4771 by supporting the JsonFormat OBJECT shape during serialization and deserialization.
mcvayc
force-pushed
the
feature/4771-add-feature-for-qnames
branch
from
8f4b220 to
f0c2f60
Compare
|
I just rebased and fixed some of the unnecessary whitespace formatting changes. Is there a checkstyle config (or something similar) for this project? |
src/main/java/com/fasterxml/jackson/databind/ext/CoreXMLDeserializers.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public void acceptJsonFormatVisitor(JsonFormatVisitorWrapper visitor, JavaType typeHint) throws JsonMappingException { | ||
| visitor.expectBooleanFormat(typeHint); |
There was a problem hiding this comment.
Not boolean, object, will change.
|
Thanks, @cowtowncoder. I'm sorry you had to make so many changes but I'm grateful for your fixes and for merging this. I will learn from this so subsequent PRs will be more polished. |
|
@mcvayc Not at all -- you had a pretty clean PR & figured out all the pieces very well. And thank you for providing the improvement! That's how things improve. |
This commit fixes #4771 by supporting the JsonFormat OBJECT shape during serialization and deserialization.