Skip to content

Change default for DateTimeFeature.ONE_BASED_MONTHS to true in 3.0 #5065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cowtowncoder opened this issue Apr 5, 2025 · 0 comments
Closed

Change default for DateTimeFeature.ONE_BASED_MONTHS to true in 3.0 #5065

cowtowncoder opened this issue Apr 5, 2025 · 0 comments
Labels
3.0-release-notes Issues relevant for 3.0 release notes. 3.0 Issue planned for initial 3.0 release date-time-config Work related to possible larger DateTimeConfig feature
Milestone
3.0.0-rc3

Comments

@cowtowncoder
Copy link
Member

cowtowncoder commented Apr 5, 2025 •
edited
Loading

Feature known as JavaTimeFeature.ONE_BASED_MONTHS in 2.x defaults to false for backwards-compatibility reasons. With #5032 this module was merged in jackson-databind for Jackson 3.0.0 (rc3) and feature became DateTimeFeature.ONE_BASED_MONTHS.

It makes more sense to have this feature enabled for 3.0, so let's change that. Change will probably fail a few unit test so most work is likely just changing tests to work appropriately again.

We also need to update MapperBuilder.configureForJackson2() to set that back to false if requested.
@cowtowncoder cowtowncoder added 3.0 Issue planned for initial 3.0 release date-time-config Work related to possible larger DateTimeConfig feature labels Apr 5, 2025
@cowtowncoder cowtowncoder changed the title Change defaulat for DateTimeFeature.ONE_BASED_MONTHS to true in 3.0 Change default for DateTimeFeature.ONE_BASED_MONTHS to true in 3.0 Apr 5, 2025
@pjfanning pjfanning added the 3.0-release-notes Issues relevant for 3.0 release notes. label Apr 5, 2025
cowtowncoder added a commit that referenced this issue Apr 9, 2025
@cowtowncoder
Fixes #5065: default change for DateTimeFeature.ONE_BASED_MONTHS
a0b8634
cowtowncoder added a commit that referenced this issue Apr 9, 2025
@cowtowncoder
Fixes #5065: default change for DateTimeFeature.ONE_BASED_MONTHS (#…
53a7477 
…5077)
@cowtowncoder cowtowncoder added this to the 3.0.0-rc3 milestone Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.0-release-notes Issues relevant for 3.0 release notes. 3.0 Issue planned for initial 3.0 release date-time-config Work related to possible larger DateTimeConfig feature
Projects
None yet
Milestone
3.0.0-rc3
Development

No branches or pull requests
2 participants
@cowtowncoder @pjfanning