Merge pull request #3535 from Flow-Launcher/temp_file_delete

Fix exception when deleting temp files

Author: Jack251970

Plugins/Flow.Launcher.Plugin.BrowserBookmark/ChromiumBookmarkLoader.cs

@@ -131,7 +131,17 @@ private void LoadFaviconsFromDb(string dbPath, List<Bookmark> bookmarks)
         }
         catch (Exception ex)
         {
-            File.Delete(tempDbPath);
+            try
+            {
+                if (File.Exists(tempDbPath))
+                {
+                    File.Delete(tempDbPath);
+                }
+            }
+            catch (Exception ex1)
+            {
+                Main._context.API.LogException(ClassName, $"Failed to delete temporary favicon DB: {tempDbPath}", ex1);
+            }
             Main._context.API.LogException(ClassName, $"Failed to copy favicon DB: {dbPath}", ex);
             return;
         }

Plugins/Flow.Launcher.Plugin.BrowserBookmark/Main.cs

@@ -37,8 +37,6 @@ public void Init(PluginInitContext context)
             context.CurrentPluginMetadata.PluginCacheDirectoryPath,
             "FaviconCache");
 
-        FilesFolders.ValidateDirectory(_faviconCacheDir);
-
         LoadBookmarksIfEnabled();
     }
 
@@ -50,6 +48,9 @@ private static void LoadBookmarksIfEnabled()
             return;
         }
 
+        // Validate the cache directory before loading all bookmarks because Flow needs this directory to storage favicons
+        FilesFolders.ValidateDirectory(_faviconCacheDir);
+
         _cachedBookmarks = BookmarkLoader.LoadAllBookmarks(_settings);
         _ = MonitorRefreshQueueAsync();
         _initialized = true;