Skip to content

BUG: Mouse side buttons navigation in Settings causes an unhandled exception #3546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
vzabrodin opened this issue May 15, 2025 · 10 comments · Fixed by #3311 or #3547
Closed
2 tasks done

BUG: Mouse side buttons navigation in Settings causes an unhandled exception #3546

vzabrodin opened this issue May 15, 2025 · 10 comments · Fixed by #3311 or #3547
Labels
bug Something isn't working

Comments

@vzabrodin
Copy link

vzabrodin commented May 15, 2025

Checks

  • I have checked that this issue has not already been reported.

  • I am using the latest version of Flow Launcher.

Problem Description

My mouse has side buttons. They can be used to navigate (back, forward) in some apps, like browsers.
When I navigate to Plugin Store, then navigate back and forward using side buttons, the app throws an exception.

To Reproduce

  1. Open Flow Launcher's Settings
  2. Navigate to Plugin Store (by clicking on it)
  3. Use Tab to focus element on navigation view (by pressing Tab for many times until it does not focus on page elements) Or Put mouse cursor must be hovering navigation bar's content
  4. Navigate back using mouse side button.
  5. Navigate forward using mouse side button.

Screenshots

I noticed that selected page in sidebar is not updated when I navigate using side buttons.

On screenshot below Plugin Store page is selected but General page is displayed.
Image

Flow Launcher Version

1.19.5

Windows Build Number

10.0.26100.4061

Error Log

2025-05-15.txt

@vzabrodin vzabrodin added the bug Something isn't working label May 15, 2025
@Jack251970
Copy link
Contributor

The exception should be resolved in #3311 already.

@Jack251970
Copy link
Contributor

Jack251970 commented May 15, 2025

@vzabrodin Thanks for your report! Could you please check if it is fixed in #3547?

https://ci.appveyor.com/project/JohnTheGr8/flow-launcher/builds/52061356/artifacts

@vzabrodin
Copy link
Author

vzabrodin commented May 15, 2025

No exceptions now. But it doesn't work as expected.

I have to press back twice to navigate to previous page. And forward doesn't work at all.

(I compiled the app manually from setting_window_navigation_issue branch)

@Jack251970
Copy link
Contributor

Jack251970 commented May 15, 2025

No exceptions now. But it doesn't work as expected.

I have to press back twice to navigate to previous page. And forward doesn't work at all.

(I compiled the app manually from setting_window_navigation_issue branch)

Could you please check default behaviour in dev branch?

@vzabrodin
Copy link
Author

vzabrodin commented May 15, 2025

dev branch:

System.NullReferenceException
  HResult=0x80004003
  Message=Object reference not set to an instance of an object.
  Source=Flow.Launcher
  StackTrace:
   at Flow.Launcher.SettingPages.Views.SettingsPanePluginStore.OnNavigatedTo(NavigationEventArgs e) in C:\Projects\Flow.Launcher\Flow.Launcher\SettingPages\Views\SettingsPanePluginStore.xaml.cs:line 23

@Jack251970
Copy link
Contributor

Jack251970 commented May 15, 2025

Sorry, I mean the navigation behaviour in dev branch. I think I have not changed the navigation behaviour in that PR. But you found back twice issue & forward issue.

@vzabrodin
Copy link
Author

Navigation in dev branch throws an exception, like in published version (1.19.5). And it doesn't have back twice issue & forward issue.

@Jack251970
Copy link
Contributor

Navigation in dev branch throws an exception, like in published version (1.19.5). And it doesn't have back twice issue & forward issue.

Thanks, I will check it.

@Jack251970
Copy link
Contributor

@vzabrodin Hello, navigation issue now is fixed. Could you please check if this works?

@vzabrodin
Copy link
Author

Yes, it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants