Don't toggle lines' patch status when selecting text

simonwiles · simonwiles · commit 133d391fab73 · 2020-10-02T23:06:10.000-07:00
This isn't perfect, but it's better than it was before.
diff --git a/components/textdiff/textdiff.js b/components/textdiff/textdiff.js
@@ -202,6 +202,9 @@ class TextDiffViewModel {
   }
 
   togglePatchLine(index) {
+    // Selecting text, not toggling the line's patch status
+    if (window.getSelection().toString().length !== 0) return true;
+
     this.patchLineList()[index] = !this.patchLineList()[index];
 
     if (this.patchLineList().filter(Boolean).length === 0) {

Original file line number	Diff line number	Diff line change
`@@ -202,6 +202,9 @@ class TextDiffViewModel {`
`202`	`202`	`}`
`203`	`203`
`204`	`204`	`togglePatchLine(index) {`
	`205`	`+ // Selecting text, not toggling the line's patch status`
	`206`	`+ if (window.getSelection().toString().length !== 0) return true;`
	`207`	`+`
`205`	`208`	`this.patchLineList()[index] = !this.patchLineList()[index];`
`206`	`209`
`207`	`210`	`if (this.patchLineList().filter(Boolean).length === 0) {`