thanks clippy

Author: Byron

gitoxide-core/src/hours/util.rs

@@ -14,8 +14,8 @@ pub struct WorkByPerson {
     pub lines: LineStats,
 }
 
-impl<'a> WorkByPerson {
-    pub fn merge(&mut self, other: &'a WorkByEmail) {
+impl WorkByPerson {
+    pub fn merge(&mut self, other: &WorkByEmail) {
         if !self.name.contains(&other.name) {
             self.name.push(other.name);
         }

gitoxide-core/src/query/engine/update.rs

@@ -369,7 +369,7 @@ pub fn update(
             }
         }
 
-        impl<'a, Find> gix::prelude::Find for Db<'a, Find>
+        impl<Find> gix::prelude::Find for Db<'_, Find>
         where
             Find: gix::prelude::Find + Clone,
         {

gitoxide-core/src/repository/revision/explain.rs

@@ -55,7 +55,7 @@ impl<'a> Explain<'a> {
     }
 }
 
-impl<'a> delegate::Revision for Explain<'a> {
+impl delegate::Revision for Explain<'_> {
     fn find_ref(&mut self, name: &BStr) -> Option<()> {
         self.prefix()?;
         self.ref_name = Some(name.into());
@@ -121,7 +121,7 @@ impl<'a> delegate::Revision for Explain<'a> {
     }
 }
 
-impl<'a> delegate::Navigate for Explain<'a> {
+impl delegate::Navigate for Explain<'_> {
     fn traverse(&mut self, kind: Traversal) -> Option<()> {
         self.prefix()?;
         let name = self.revision_name();
@@ -194,7 +194,7 @@ impl<'a> delegate::Navigate for Explain<'a> {
     }
 }
 
-impl<'a> delegate::Kind for Explain<'a> {
+impl delegate::Kind for Explain<'_> {
     fn kind(&mut self, kind: spec::Kind) -> Option<()> {
         self.prefix()?;
         self.call = 0;
@@ -215,7 +215,7 @@ impl<'a> delegate::Kind for Explain<'a> {
     }
 }
 
-impl<'a> Delegate for Explain<'a> {
+impl Delegate for Explain<'_> {
     fn done(&mut self) {
         if !self.has_implicit_anchor && self.ref_name.is_none() && self.oid_prefix.is_none() {
             self.err = Some("Incomplete specification lacks its anchor, like a reference or object name".into());

gitoxide-core/src/repository/tree.rs

@@ -65,7 +65,7 @@ mod entries {
         }
     }
 
-    impl<'repo, 'a> gix::traverse::tree::Visit for Traverse<'repo, 'a> {
+    impl gix::traverse::tree::Visit for Traverse<'_, '_> {
         fn pop_front_tracked_path_and_set_current(&mut self) {
             self.path = self.path_deque.pop_front().expect("every parent is set only once");
         }

gix-actor/src/identity.rs

@@ -40,7 +40,7 @@ mod write {
         }
     }
 
-    impl<'a> IdentityRef<'a> {
+    impl IdentityRef<'_> {
         /// Serialize this instance to `out` in the git serialization format for signatures (but without timestamp).
         pub fn write_to(&self, out: &mut dyn std::io::Write) -> std::io::Result<()> {
             out.write_all(validated_token(self.name)?)?;

gix-actor/src/signature/mod.rs

@@ -104,7 +104,7 @@ pub(crate) mod write {
         }
     }
 
-    impl<'a> SignatureRef<'a> {
+    impl SignatureRef<'_> {
         /// Serialize this instance to `out` in the git serialization format for actors.
         pub fn write_to(&self, out: &mut dyn std::io::Write) -> std::io::Result<()> {
             out.write_all(validated_token(self.name)?)?;

gix-attributes/src/name.rs

@@ -2,7 +2,7 @@ use crate::{Name, NameRef};
 use bstr::{BStr, BString, ByteSlice};
 use kstring::KStringRef;
 
-impl<'a> NameRef<'a> {
+impl NameRef<'_> {
     /// Turn this ref into its owned counterpart.
     pub fn to_owned(self) -> Name {
         Name(self.0.into())

gix-attributes/src/state.rs

@@ -96,7 +96,7 @@ impl<'a> StateRef<'a> {
 }
 
 /// Access
-impl<'a> StateRef<'a> {
+impl StateRef<'_> {
     /// Turn ourselves into our owned counterpart.
     pub fn to_owned(self) -> State {
         self.into()

gix-commitgraph/src/file/commit.rs

@@ -106,7 +106,7 @@ impl<'a> Commit<'a> {
     }
 }
 
-impl<'a> Debug for Commit<'a> {
+impl Debug for Commit<'_> {
     fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
         write!(
             f,
@@ -121,9 +121,9 @@ impl<'a> Debug for Commit<'a> {
     }
 }
 
-impl<'a> Eq for Commit<'a> {}
+impl Eq for Commit<'_> {}
 
-impl<'a> PartialEq for Commit<'a> {
+impl PartialEq for Commit<'_> {
     fn eq(&self, other: &Self) -> bool {
         std::ptr::eq(self.file, other.file) && self.pos == other.pos
     }
@@ -135,7 +135,7 @@ pub struct Parents<'a> {
     state: ParentIteratorState<'a>,
 }
 
-impl<'a> Iterator for Parents<'a> {
+impl Iterator for Parents<'_> {
     type Item = Result<Position, Error>;
 
     fn next(&mut self) -> Option<Self::Item> {

gix-config-value/src/path.rs

@@ -86,21 +86,21 @@ pub mod interpolate {
     }
 }
 
-impl<'a> std::ops::Deref for Path<'a> {
+impl std::ops::Deref for Path<'_> {
     type Target = BStr;
 
     fn deref(&self) -> &Self::Target {
         self.value.as_ref()
     }
 }
 
-impl<'a> AsRef<[u8]> for Path<'a> {
+impl AsRef<[u8]> for Path<'_> {
     fn as_ref(&self) -> &[u8] {
         self.value.as_ref()
     }
 }
 
-impl<'a> AsRef<BStr> for Path<'a> {
+impl AsRef<BStr> for Path<'_> {
     fn as_ref(&self) -> &BStr {
         self.value.as_ref()
     }

gix-config/src/file/access/comfort.rs

@@ -5,7 +5,7 @@ use bstr::BStr;
 use crate::{file::MetadataFilter, value, AsKey, File};
 
 /// Comfortable API for accessing values
-impl<'event> File<'event> {
+impl File<'_> {
     /// Like [`string_by()`](File::string_by()), but suitable for statically known `key`s like `remote.origin.url`.
     pub fn string(&self, key: impl AsKey) -> Option<Cow<'_, BStr>> {
         self.string_filter(key, &mut |_| true)

gix-config/src/file/mutable/multi_value.rs

@@ -35,7 +35,7 @@ pub struct MultiValueMut<'borrow, 'lookup, 'event> {
     pub(crate) offsets: HashMap<SectionId, Vec<usize>>,
 }
 
-impl<'borrow, 'lookup, 'event> MultiValueMut<'borrow, 'lookup, 'event> {
+impl<'lookup, 'event> MultiValueMut<'_, 'lookup, 'event> {
     /// Returns the actual values.
     pub fn get(&self) -> Result<Vec<Cow<'_, BStr>>, lookup::existing::Error> {
         let mut expect_value = false;

gix-config/src/file/mutable/section.rs

@@ -27,7 +27,7 @@ pub struct SectionMut<'a, 'event> {
 }
 
 /// Mutating methods.
-impl<'a, 'event> SectionMut<'a, 'event> {
+impl<'event> SectionMut<'_, 'event> {
     /// Adds an entry to the end of this section name `value_name` and `value`. If `value` is `None`, no equal sign will be written leaving
     /// just the key. This is useful for boolean values which are true if merely the key exists.
     pub fn push<'b>(&mut self, value_name: ValueName<'event>, value: Option<&'b BStr>) -> &mut Self {

gix-config/src/file/mutable/value.rs

@@ -18,7 +18,7 @@ pub struct ValueMut<'borrow, 'lookup, 'event> {
     pub(crate) size: Size,
 }
 
-impl<'borrow, 'lookup, 'event> ValueMut<'borrow, 'lookup, 'event> {
+impl<'borrow, 'event> ValueMut<'borrow, '_, 'event> {
     /// Returns the actual value. This is computed each time this is called
     /// requiring an allocation for multi-line values.
     pub fn get(&self) -> Result<Cow<'_, BStr>, lookup::existing::Error> {

gix-config/src/file/section/body.rs

@@ -120,7 +120,7 @@ impl<'event> Body<'event> {
     }
 }
 
-impl<'event> Body<'event> {
+impl Body<'_> {
     pub(crate) fn as_ref(&self) -> &[Event<'_>] {
         &self.0
     }

gix-diff/src/rewrites/tracker.rs

@@ -641,7 +641,7 @@ mod diff {
         pub input: &'a crate::blob::intern::InternedInput<&'data [u8]>,
     }
 
-    impl<'a, 'data> crate::blob::Sink for Statistics<'a, 'data> {
+    impl crate::blob::Sink for Statistics<'_, '_> {
         type Out = usize;
 
         fn process_change(&mut self, before: Range<u32>, _after: Range<u32>) {

gix-diff/src/tree/changes.rs

@@ -20,7 +20,7 @@ pub enum Error {
     EntriesDecode(#[from] gix_object::decode::Error),
 }
 
-impl<'a> tree::Changes<'a> {
+impl tree::Changes<'_> {
     /// Calculate the changes that would need to be applied to `self` to get `other` using `objects` to obtain objects as needed for traversal.
     ///
     /// * The `state` maybe owned or mutably borrowed to allow reuses allocated data structures through multiple runs.

gix-dir/tests/walk_utils/mod.rs

@@ -374,7 +374,7 @@ impl<'a> Options<'a> {
     }
 }
 
-impl<'a> Default for Options<'a> {
+impl Default for Options<'_> {
     fn default() -> Self {
         Options {
             fresh_index: true,

gix-features/src/interrupt.rs

@@ -29,7 +29,7 @@ where
     }
 }
 
-impl<'a, I> Iterator for Iter<'a, I>
+impl<I> Iterator for Iter<'_, I>
 where
     I: Iterator,
 {
@@ -67,7 +67,7 @@ where
     }
 }
 
-impl<'a, I, EFN, E> Iterator for IterWithErr<'a, I, EFN>
+impl<I, EFN, E> Iterator for IterWithErr<'_, I, EFN>
 where
     I: Iterator,
     EFN: FnOnce() -> E,
@@ -99,7 +99,7 @@ pub struct Read<'a, R> {
     pub should_interrupt: &'a AtomicBool,
 }
 
-impl<'a, R> io::Read for Read<'a, R>
+impl<R> io::Read for Read<'_, R>
 where
     R: io::Read,
 {
@@ -111,7 +111,7 @@ where
     }
 }
 
-impl<'a, R> io::BufRead for Read<'a, R>
+impl<R> io::BufRead for Read<'_, R>
 where
     R: io::BufRead,
 {

gix-filter/src/driver/process/client.rs

@@ -256,7 +256,7 @@ struct ReadProcessOutputAndStatus<'a> {
     inner: PacketlineReader<'a>,
 }
 
-impl<'a> std::io::Read for ReadProcessOutputAndStatus<'a> {
+impl std::io::Read for ReadProcessOutputAndStatus<'_> {
     fn read(&mut self, buf: &mut [u8]) -> std::io::Result<usize> {
         let num_read = self.inner.read(buf)?;
         if num_read == 0 {

gix-filter/src/pipeline/convert.rs

@@ -260,7 +260,7 @@ pub enum ToWorktreeOutcome<'input, 'pipeline> {
     Process(driver::apply::MaybeDelayed<'pipeline>),
 }
 
-impl<'input, 'pipeline> ToWorktreeOutcome<'input, 'pipeline> {
+impl ToWorktreeOutcome<'_, '_> {
     /// Return true if this outcome is delayed. In that case, one isn't allowed to use [`Read`] or cause a panic.
     pub fn is_delayed(&self) -> bool {
         matches!(
@@ -297,7 +297,7 @@ impl<'input, 'pipeline> ToWorktreeOutcome<'input, 'pipeline> {
     }
 }
 
-impl<'input, 'pipeline> std::io::Read for ToWorktreeOutcome<'input, 'pipeline> {
+impl std::io::Read for ToWorktreeOutcome<'_, '_> {
     fn read(&mut self, buf: &mut [u8]) -> std::io::Result<usize> {
         match self {
             ToWorktreeOutcome::Unchanged(b) => b.read(buf),
@@ -310,7 +310,7 @@ impl<'input, 'pipeline> std::io::Read for ToWorktreeOutcome<'input, 'pipeline> {
     }
 }
 
-impl<'pipeline, R> std::io::Read for ToGitOutcome<'pipeline, R>
+impl<R> std::io::Read for ToGitOutcome<'_, R>
 where
     R: std::io::Read,
 {

gix-fs/src/dir/create.rs

@@ -47,7 +47,7 @@ mod error {
         },
     }
 
-    impl<'a> fmt::Display for Error<'a> {
+    impl fmt::Display for Error<'_> {
         fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
             match self {
                 Error::Intermediate { dir, kind } => write!(
@@ -69,7 +69,7 @@ mod error {
         }
     }
 
-    impl<'a> std::error::Error for Error<'a> {
+    impl std::error::Error for Error<'_> {
         fn source(&self) -> Option<&(dyn std::error::Error + 'static)> {
             match self {
                 Error::Permanent { err, .. } => Some(err),

gix-hash/src/oid.rs

@@ -41,7 +41,7 @@ pub struct HexDisplay<'a> {
     hex_len: usize,
 }
 
-impl<'a> std::fmt::Display for HexDisplay<'a> {
+impl std::fmt::Display for HexDisplay<'_> {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         let mut hex = Kind::hex_buf();
         let max_len = self.inner.hex_to_buf(hex.as_mut());

gix-ignore/src/parse.rs

@@ -17,7 +17,7 @@ impl<'a> Lines<'a> {
     }
 }
 
-impl<'a> Iterator for Lines<'a> {
+impl Iterator for Lines<'_> {
     type Item = (gix_glob::Pattern, usize, crate::Kind);
 
     fn next(&mut self) -> Option<Self::Item> {

gix-index/src/access/mod.rs

@@ -389,7 +389,7 @@ impl State {
     }
 }
 
-impl<'a> AccelerateLookup<'a> {
+impl AccelerateLookup<'_> {
     fn with_capacity(cap: usize) -> Self {
         let ratio_of_entries_to_dirs_in_webkit = 20; // 400k entries and 20k dirs
         Self {

gix-negotiate/tests/baseline/mod.rs

@@ -154,7 +154,7 @@ impl<'a> ParseRounds<'a> {
     }
 }
 
-impl<'a> Iterator for ParseRounds<'a> {
+impl Iterator for ParseRounds<'_> {
     type Item = Round;
 
     fn next(&mut self) -> Option<Self::Item> {

gix-object/src/blob.rs

@@ -2,7 +2,7 @@ use std::{convert::Infallible, io};
 
 use crate::{Blob, BlobRef, Kind};
 
-impl<'a> crate::WriteTo for BlobRef<'a> {
+impl crate::WriteTo for BlobRef<'_> {
     /// Write the blobs data to `out` verbatim.
     fn write_to(&self, out: &mut dyn io::Write) -> io::Result<()> {
         out.write_all(self.data)
@@ -39,7 +39,7 @@ impl Blob {
     }
 }
 
-impl<'a> BlobRef<'a> {
+impl BlobRef<'_> {
     /// Instantiate a `Blob` from the given `data`, which is used as-is.
     pub fn from_bytes(data: &[u8]) -> Result<BlobRef<'_>, Infallible> {
         Ok(BlobRef { data })

gix-object/src/commit/message/body.rs

@@ -101,13 +101,13 @@ impl<'a> BodyRef<'a> {
     }
 }
 
-impl<'a> AsRef<BStr> for BodyRef<'a> {
+impl AsRef<BStr> for BodyRef<'_> {
     fn as_ref(&self) -> &BStr {
         self.body_without_trailer
     }
 }
 
-impl<'a> Deref for BodyRef<'a> {
+impl Deref for BodyRef<'_> {
     type Target = BStr;
 
     fn deref(&self) -> &Self::Target {