Skip to content

Commit c5d3793

Browse files
committed
Use runner-provided Git for Windows now that it's 2.49.0
Because #1849 (git-for-windows/git#5436) caused some incorrect test failures in `test-fixtures-windows`, we have been upgrading Git for Windows on the runner for that job: - We starting doing that in of 4237e5a (#1870). At that time, we upgraded it to the most recent tag, to select the latest release even though it was a release candiate, because Git for Windows 2.49.0 had not yet had a stable release. - Then Git for Windows 2.49.0 got a stable release, and starting in ddef6d3 (#1892) we have upgraded to the release marked "latest" (which in Git for Windows is always the latest stable release). More recently, the Windows Server 2022 runner image (which the `windows-latest` label we use currently selects) has upgraded its Git for Windows installation from 2.48.1 to 2.49.0: https://github.com/actions/runner-images/releases/tag/win22%2F20250330.1 It is therefore no longer necessary for the `test-fixtures-windows` job to upgrade Git for Windows on the runner. This removes the step that did that. (Either version of the step could be brought back from the history if ever needed again.) This closes #1849, per the plan in: #1849 (comment)
1 parent 420e730 commit c5d3793

File tree

1 file changed

+0
-29
lines changed

1 file changed

+0
-29
lines changed

.github/workflows/ci.yml

-29
Original file line numberDiff line numberDiff line change
@@ -191,35 +191,6 @@ jobs:
191191
runs-on: windows-latest
192192

193193
steps:
194-
- name: Upgrade Git for Windows to latest stable release
195-
# This upgrades Git to work around https://github.com/GitoxideLabs/gitoxide/issues/1849.
196-
# TODO: Remove this step once the runner image has Git 2.49.0 or higher.
197-
env:
198-
GH_TOKEN: ${{ github.token }}
199-
run: |
200-
$workingDir = '~/git-dl'
201-
$repo = 'git-for-windows/git'
202-
$pattern = 'Git-*-64-bit.exe'
203-
$log = 'setup-log.txt'
204-
# Inno Setup args reference: https://jrsoftware.org/ishelp/index.php?topic=setupcmdline
205-
$arguments = @(
206-
'/VERYSILENT',
207-
'/SUPPRESSMSGBOXES',
208-
'/ALLUSERS',
209-
"/LOG=$log",
210-
'/NORESTART',
211-
'/CLOSEAPPLICATIONS',
212-
'/FORCECLOSEAPPLICATIONS'
213-
)
214-
215-
mkdir $workingDir | Out-Null
216-
cd $workingDir
217-
gh release download --repo $repo --pattern $pattern
218-
$installer = Get-Item $pattern
219-
Start-Process -FilePath $installer -ArgumentList $arguments -NoNewWindow -Wait
220-
221-
Get-Content -Path $log -Tail 50
222-
git version
223194
- uses: actions/checkout@v4
224195
- uses: dtolnay/rust-toolchain@stable
225196
- uses: Swatinem/rust-cache@v2

0 commit comments

Comments
 (0)