-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Withhold origin trial features from API Reference generation #42
Comments
cc: @dotproto @ali-spivak |
cc: @rdcronin |
Just chatted with Devlin about this. At the moment, I think it makes sense for documentation to reflect that certain capabilities related to origin trials are exposed, but we shouldn't completely omit them. There are a couple of relevant factors here:
At the moment I think the most practical course is to add a callout about (and link to) the origin trial to the API docs in Chromium source as appropriate and give ourselves follow-up issues for future milestones to check if the callout is still necessary/accurate. We should keep an eye on how frequently we encounter origin trial-related extension doc concerns and the related maintenance cost of these efforts. If the maintenance burden gets high enough (or the engineering cost gets low enough), we can revisit this approach and discuss automating the process. |
Simeon,
Thank you for following up. This all sounds good except for one thing.
"If the maintenance burden gets high enough (or the engineering cost gets
low enough), we can revisit this approach and discuss automating the
process."
The cost of putting something ephemeral in stable documentation is low, but
that's not the cost we should be concerned about. The chances of
remembering to remove ephemeral bits of information are low and when teams
do remember to remove them, the chances of finding everything that needs to
be removed are also low. Over time, this results in the build up of
irrelevant and outdated cruft that gives the impression we're neglecting
documentation.
I am investigating other approaches to this problem. I would like to keep
automation on the backlog until we can at least figure out if it is easy or
difficult to implement.
Joe Medley | Technical Writer, Chrome DevRel | ***@***.*** |
816-678-7195
*If an API's not documented it doesn't exist.*
…On Thu, Dec 1, 2022 at 6:19 PM Simeon Vincent ***@***.***> wrote:
Just chatted with Devlin about this. At the moment, I think it makes sense
for documentation to reflect that certain capabilities related to origin
trials are exposed, but we shouldn't completely omit them. There are a
couple of relevant factors here:
*Lower level brower concepts* – Extensions can integrate very deeply with
browser implementation details in order to do what they do. Not all
extensions will need to handle features like the "fenced_frame"
FrameType, but the ones that do do.
*Trials for thee but not for me* – If a website opts into a trial that
overlaps with extensions APIs, that opt-in only affects their website and
no others. But extensions span all websites a user visits. That overlapping
trial can lead to buggy behavior in the extension and that could be a
critical problem for the extension.
*Overlap is (relatively) uncommon* – Origin trials and extensions
capabilities don't often overlap. In the past 5 years the only 2 cases I
can think of right now are MPArch
<https://blogs.igalia.com/gyuyoung/2022/10/13/mparchmultiple-page-architecture-project-in-chromium/>
(bfcache <https://web.dev/bfcache/> & related work) and fenced frames.
That said, fenced frames are related to Google's Privacy Sandbox effort and
due to how closely that effort ties into web platform primitives there may
be more overlap in the future.
At the moment I think the most practical course is to add a callout about
(and link to) the origin trial to the API docs in Chromium source as
appropriate and give ourselves follow-up issues for future milestones to
check if the callout is still necessary/accurate.
We should keep an eye on how frequently we encounter origin trial-related
extension doc concerns and the related maintenance cost of these efforts.
If the maintenance burden gets high enough (or the engineering cost gets
low enough), we can revisit this approach and discuss automating the
process.
—
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB6S7C2T33L46IPWOEMK7W3WLFMBLANCNFSM6AAAAAASO26E7E>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
The API reference displays items that are in origin trials without indicating them as such. This has a number of problems.
For example, so that extensions can handle Back/Forward (sic) caching a few things have been added to extension APIs. One of them is called
FrameType
. One of the values ofFrameType
is"fenced_frame"
. But Fenced Frame is in an origin trial that finished by the time Chrome shipped 108 on November 29.This issue is a request to either hide or correctly label items that are in origin trials. I favor hiding since labeling such items requires additional documentation and publicity that may or may not be useful to our developers.
Regardless of which option we chose, the first step will be making the conversion process aware of origin trials.
The text was updated successfully, but these errors were encountered: