Bug Fix: handle non existent data field in paginated data (#1359)

* Bug Fix: handle non existent data in page

The new list user saved searches returns no data field in the page if there is none.

A logged in user will get this error in the console:

```
TypeError: a.data is not iterable (cannot read property undefined)
```

This solves that

* remove console assertion

Author: jcscottiii

e2e/tests/overview-page.spec.ts

@@ -15,7 +15,11 @@
  */
 
 import {test, expect, Request} from '@playwright/test';
-import {gotoOverviewPageUrl, getOverviewPageFeatureCount} from './utils';
+import {
+  gotoOverviewPageUrl,
+  getOverviewPageFeatureCount,
+  loginAsUser,
+} from './utils';
 
 test('matches the screenshot', async ({page}) => {
   await gotoOverviewPageUrl(page, 'http://localhost:5555/');
@@ -258,6 +262,12 @@ test('Typing slash focuses on searchbox', async ({page}) => {
   await expect(searchbox).toHaveAttribute('value', 'def/ghi');
 });
 
+test('newly logged in user should see no errors (toasts)', async ({page}) => {
+  await loginAsUser(page, 'fresh user');
+  await gotoOverviewPageUrl(page, 'http://localhost:5555/');
+  await expect(page.locator('.toast')).toHaveCount(0);
+});
+
 test.describe('saved searches', () => {
   test('unauthenticated user can load a public saved search and navigate pages', async ({
     page,

frontend/src/static/js/api/client.ts

@@ -269,7 +269,7 @@ export class APIClient {
       );
 
       nextPageToken = page?.metadata?.next_page_token;
-      allData.push(...page.data);
+      allData.push(...(page.data ?? []));
       offset += (page.data || []).length;
     } while (nextPageToken !== undefined);
 

util/cmd/load_test_users/main.go

@@ -116,9 +116,10 @@ func getUsers() []User {
 			EmailVerified: true,
 			UserID:        "abcdedf1234567892",
 		},
+		// This user should have no data and should be used to replicate the experience of a newly logged in user.
 		{
-			Name:          "test user 3",
-			Email:         "test.user.3@example.com",
+			Name:          "fresh user",
+			Email:         "fresh[email protected]",
 			EmailVerified: true,
 			UserID:        "abcdedf1234567893",
 		},