Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round the usage percentage to 1 decimal point #1044

Open
past opened this issue Jan 9, 2025 · 8 comments
Open

Round the usage percentage to 1 decimal point #1044

past opened this issue Jan 9, 2025 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@past
Copy link
Collaborator

past commented Jan 9, 2025

Currently the usage percentage has a large and not very useful number of decimal points. Rounding it to 1 decimal point should be sufficient for all use cases that we currently know of.

@past past added the enhancement New feature or request label Jan 9, 2025
@jcscottiii
Copy link
Collaborator

FYI: This is about the usage chart

Image

@jcscottiii jcscottiii added the good first issue Good for newcomers label Mar 4, 2025
@suprith-hub
Copy link
Contributor

@jcscottiii how do I get the percentage chart. All I could see now is subtest count chart.

@Andrea-Ozuem
Copy link

@jcscottiii I believe this PR is about the chromium usage column on the Overview page?

If so, then I believe this feature has already been implemented. I just confirmed now.

@jcscottiii
Copy link
Collaborator

@suprith-hub @Andrea-Ozuem

Thank you both for looking into this issue. To clarify, the chart functionality you're interested in is not yet live on the site. However, the current implementation exists in the following file:

valueExtractor: (dataPoint: ChromiumUsageStat): number =>
dataPoint.usage ? dataPoint.usage * 100 : 0,
tooltipExtractor: (dataPoint: ChromiumUsageStat): string =>
`Chrome: ${dataPoint.usage ? dataPoint.usage * 100 : 0}%`,

If either of you plan to work on implementing this feature, please let me know along with an estimated ETA. This will help us avoid duplicate effort and ensure a fair opportunity for all contributors.

@Andrea-Ozuem
Copy link

@jcscottiii

I'd like to work on implementing this feature. However, I've been trying to setup the dev container for webstatus.dev, but I keep on running into an error when connecting to the dev container. I'm working on resolving it now though. After I'm able to setup my Dev container, my expected ETA would be 24 hours.

@Andrea-Ozuem
Copy link

Andrea-Ozuem commented Mar 26, 2025

@jcscottiii

I get this error from the log when trying to connect to the dev container

#0 547.7 ERROR: Feature "Docker (Docker-in-Docker)" (ghcr.io/devcontainers/features/docker-in-docker) failed to install! Look at the documentation at https://github.com/devcontainers/features/tree/main/src/docker-in-docker for help troubleshooting this error.

Any pointers on how to move on from here will be greatly appreciated!

Note:

  • MacOS version: 15.3.2
  • Chip: Apple M1

@suprith-hub
Copy link
Contributor

@suprith-hub @Andrea-Ozuem

Thank you both for looking into this issue. To clarify, the chart functionality you're interested in is not yet live on the site. However, the current implementation exists in the following file:

webstatus.dev/frontend/src/static/js/components/webstatus-feature-usage-chart-panel.ts

Lines 57 to 60 in ecbd307

valueExtractor: (dataPoint: ChromiumUsageStat): number =>
dataPoint.usage ? dataPoint.usage * 100 : 0,
tooltipExtractor: (dataPoint: ChromiumUsageStat): string =>
Chrome: ${dataPoint.usage ? dataPoint.usage * 100 : 0}%,
If either of you plan to work on implementing this feature, please let me know along with an estimated ETA. This will help us avoid duplicate effort and ensure a fair opportunity for all contributors.

Thanks for the clarification, @jcscottiii!
I'd like to work on this feature and can start around April 9th — right now I’m focusing on finalizing my GSoC proposal.
If the issue is time-sensitive or someone else wants to take it up earlier, that’s totally fine too. Otherwise, I’d love to contribute once I’m available.

@r3yc0n1c
Copy link

r3yc0n1c commented Apr 1, 2025

Hi @jcscottiii , I'd like to work on this and can complete it by 3rd April or sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

5 participants