Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepending a minus sign to a part of a query can change it radically through autocomplete #1085

Open
foolip opened this issue Jan 22, 2025 · 2 comments
Labels
good first issue Good for newcomers typescript Pull requests that update Typescript code

Comments

@foolip
Copy link
Member

foolip commented Jan 22, 2025

Steps to reproduce:

What happens instead is this, after typing "-":

Image

When hitting enter, that commits the autocomplete suggestion, and I end up with the query "-available_date:chrome:2023-01-01..2024-01-01 available_on:firefox available_on:safari" instead, which isn't at all what I was trying to do.

cc @jcscottiii who I demo'd this to in a video call just now.

@jcscottiii jcscottiii added good first issue Good for newcomers typescript Pull requests that update Typescript code labels Mar 4, 2025
@suprith-hub
Copy link
Contributor

Hi @foolip @jcscottiii for this issue I think the solution would either:

  1. the focus should stay on search box initially or
  2. include searched query in the results too like in google search.

Image
Please tell me what is suggested, I am waiting. Thank you

@r3yc0n1c
Copy link

r3yc0n1c commented Apr 1, 2025

Hi, I tried to reproduce the issue. It seems like the issue only occurs when you click on the tag, as the search box auto-suggests the tag based on your cursor. However, If you directly click at the beginning of your query string and add '-', then it works fine.

bug-webstatus.mp4

I think, we should allow the user to focus entirely on the search box when they click on it, and show the suggestions if they 1) type or 2) select the whole tag to get similar suggestions

@jcscottiii @foolip Please let me know what works best for this case. I'd like to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers typescript Pull requests that update Typescript code
Projects
Status: No status
Development

No branches or pull requests

4 participants