diff --git a/e2e/tests/overview-page.spec.ts b/e2e/tests/overview-page.spec.ts index 4252b9e98..e181581fb 100644 --- a/e2e/tests/overview-page.spec.ts +++ b/e2e/tests/overview-page.spec.ts @@ -15,7 +15,11 @@ */ import {test, expect, Request} from '@playwright/test'; -import {gotoOverviewPageUrl, getOverviewPageFeatureCount} from './utils'; +import { + gotoOverviewPageUrl, + getOverviewPageFeatureCount, + loginAsUser, +} from './utils'; test('matches the screenshot', async ({page}) => { await gotoOverviewPageUrl(page, 'http://localhost:5555/'); @@ -258,6 +262,12 @@ test('Typing slash focuses on searchbox', async ({page}) => { await expect(searchbox).toHaveAttribute('value', 'def/ghi'); }); +test('newly logged in user should see no errors (toasts)', async ({page}) => { + await loginAsUser(page, 'fresh user'); + await gotoOverviewPageUrl(page, 'http://localhost:5555/'); + await expect(page.locator('.toast')).toHaveCount(0); +}); + test.describe('saved searches', () => { test('unauthenticated user can load a public saved search and navigate pages', async ({ page, diff --git a/frontend/src/static/js/api/client.ts b/frontend/src/static/js/api/client.ts index 46aa6d016..9243beb3c 100644 --- a/frontend/src/static/js/api/client.ts +++ b/frontend/src/static/js/api/client.ts @@ -269,7 +269,7 @@ export class APIClient { ); nextPageToken = page?.metadata?.next_page_token; - allData.push(...page.data); + allData.push(...(page.data ?? [])); offset += (page.data || []).length; } while (nextPageToken !== undefined); diff --git a/util/cmd/load_test_users/main.go b/util/cmd/load_test_users/main.go index 86ead871d..a03202734 100644 --- a/util/cmd/load_test_users/main.go +++ b/util/cmd/load_test_users/main.go @@ -116,9 +116,10 @@ func getUsers() []User { EmailVerified: true, UserID: "abcdedf1234567892", }, + // This user should have no data and should be used to replicate the experience of a newly logged in user. { - Name: "test user 3", - Email: "test.user.3@example.com", + Name: "fresh user", + Email: "fresh.user@example.com", EmailVerified: true, UserID: "abcdedf1234567893", },