Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Incorrect type definition of CleanupResult #3400

Open
xeladotbe opened this issue Feb 20, 2025 · 0 comments
Open

Bug: Incorrect type definition of CleanupResult #3400

xeladotbe opened this issue Feb 20, 2025 · 0 comments

Comments

@xeladotbe
Copy link

According to the type definition, CleanupResult should have a property “deletedCacheRequests”. The PrecacheController returns a CleanupResult in the activate function, but instead of the “deletedCacheRequests” property you get “deletedURLs”

Type Definition CleanupResult:
https://github.com/GoogleChrome/workbox/blob/v7/packages/workbox-precaching/src/_types.ts#L17

Implementation of activate Function:
https://github.com/GoogleChrome/workbox/blob/v7/packages/workbox-precaching/src/PrecacheController.ts#L267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant