Skip to content

Dropping nodes onto a wire, to insert it inline, sometimes doesn't work for secondary inputs #2531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Keavon opened this issue Apr 8, 2025 · 2 comments · Fixed by #2583
Closed
Assignees
Labels
Good First Issue Good for newcomers
Milestone

Comments

@Keavon
Copy link
Member

Keavon commented Apr 8, 2025

We can usually drop a node onto a wire to get it to be inserted (via its primary input and output).

capture_17_.mp4

There are expected cases when this doesn't occur: if the node is over multiple wires, there'd be no one non-arbitrary choice, when the dragged node doesn't have a primary input or output, and when multiple nodes are being dragged. This issue isn't about these expected cases.

But sometimes situations arise where we can't drop a node in a place where it should clearly go:

capture_24_.mp4

This seems to happen often with secondary inputs, but it still works sometimes with them too. Here is a simple reproduction file:

reproduction.zip

@Keavon Keavon added the Good First Issue Good for newcomers label Apr 8, 2025
@Keavon Keavon added this to Task Board Apr 8, 2025
@github-project-automation github-project-automation bot moved this to Short-Term in Task Board Apr 8, 2025
@Keavon
Copy link
Member Author

Keavon commented Apr 10, 2025

CC @adamgerhant

@0HyperCube
Copy link
Member

editor/src/messages/portfolio/document/utility_types/network_interface.rs:5572
Could not get upstream output in insert_node_between

@Keavon Keavon changed the title Dropping nodes onto a wire, to insert it inline, sometimes doesn't work Dropping nodes onto a wire, to insert it inline, sometimes doesn't work for secondary inputs Apr 15, 2025
@github-project-automation github-project-automation bot moved this from Short-Term to Completed This Milestone in Task Board Apr 16, 2025
@Keavon Keavon added this to the Milestone 47 milestone May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for newcomers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants