Skip to content

File > Import should allow the user to place the image(s) in the viewport #2621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Keavon opened this issue Apr 29, 2025 · 2 comments · May be fixed by #2641
Open

File > Import should allow the user to place the image(s) in the viewport #2621

Keavon opened this issue Apr 29, 2025 · 2 comments · May be fixed by #2641
Labels
Good First Issue Good for newcomers

Comments

@Keavon
Copy link
Member

Keavon commented Apr 29, 2025

File > Import should support multiple imports at once. If there's no document open, it should do what it does now by creating a document with the correctly sized artboard, one per imported file. Except we should probably make the be part of File > Open instead of Import, so Open works with .graphite files as well as regular images.

But if a document is open, that's what Import is for. We want that to not place the import in the center of the viewport's current view, but instead attach it to the user's cursor and show a thumbnail preview of the image. Clicking places it center at the chosen location. Dragging draws a box with the image's aspect ratio which dictates where it will be placed. Once that's complete, it moves on to the next one if multiple images were imported.
@Keavon Keavon added the Good First Issue Good for newcomers label Apr 29, 2025
@github-project-automation github-project-automation bot moved this to Short-Term in Task Board Apr 29, 2025
@Daniel53245
Copy link
Contributor

Current Status:

  • File > Import only supports opening single file (Image files)
  • File > Open only support opening single .graphite file

Suggested goal

  • if there is no active document, File > Import should be able to open multiple files and create a document for each of those (I would implement this as File > Open )
  • if there is active document File > Import should attach a preview of the imported image at the cursor. The user could decide the location of imported files by clicking, drag and draw. This continues till every imported file has been located.

Discussion of the Suggested Goal

When there is no active document, file import will create a document for each file imported. This sounds more like a "Open" Instead of Import. At this case, I would suggest implementing this one as a feature of File > Open. And having File > Import focus on adding images to existing documents.
@Keavon What is you thought about it.

If there is no one else working on this have I look and try to create a PR for this feature

@Keavon
Copy link
Member Author

Keavon commented May 6, 2025

From what I can tell, you've basically restated what the original issue description says? Let me know if I'm missing anything that's a question you're in need of an answer of, rather than your restatement of the specification. This hasn't been attempted yet so you are welcome to begin it.

@Daniel53245 Daniel53245 linked a pull request May 12, 2025 that will close this issue
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Good for newcomers
Projects
Task Board
Status: Short-Term
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

File > Import should allow the user to place the image(s) in the viewport Daniel53245/Graphite
2 participants
@Keavon @Daniel53245