ESLint fixes

Author: JamesMessinger

src/deep-clone.ts

@@ -1,10 +1,9 @@
-// tslint:disable-next-line: no-any
 type ObjectOrArray = Record<string | number, any>;
 
 /**
  * Deep-clones a JSON object or array.
  */
-export function deepClone<T extends ObjectOrArray>(obj: T): T  {
+export function deepClone<T extends ObjectOrArray>(obj: T): T {
   let clone: ObjectOrArray = Array.isArray(obj) ? [] : {};
 
   for (let key of Object.keys(obj)) {

src/employees.ts

@@ -1,4 +1,4 @@
-// @ts-ignore - Prevent TypeScript from copying the JSON file to the output folder
+// @ts-expect-error - Prevent TypeScript from copying the JSON file to the output folder
 import jsonEmployees from "../employees.json";
 import { deepClone } from "./deep-clone";
 import { resolve } from "./isomorphic.node";

src/projects.ts

@@ -1,4 +1,4 @@
-// @ts-ignore - Prevent TypeScript from copying the JSON file to the output folder
+// @ts-expect-error - Prevent TypeScript from copying the JSON file to the output folder
 import jsonProjects from "../projects.json";
 import { deepClone } from "./deep-clone";
 

test/specs/employees.spec.js

@@ -67,28 +67,28 @@ describe("employees", () => {
 
       it("should have valid data types for all fields", () => {
         employees.forEach((employee) => {
-          expect(employee.username).to.be.a("string").and.not.empty;
-          expect(employee.password).to.be.a("string").and.not.empty;
-          expect(employee.name.first).to.be.a("string").and.not.empty;
-          expect(employee.name.last).to.be.a("string").and.not.empty;
+          expect(employee.username).to.be.a("string").with.length.of.at.least(1);
+          expect(employee.password).to.be.a("string").with.length.of.at.least(1);
+          expect(employee.name.first).to.be.a("string").with.length.of.at.least(1);
+          expect(employee.name.last).to.be.a("string").with.length.of.at.least(1);
           expect(employee.gender).to.be.a("string").and.match(/^male|female$/);
-          expect(employee.portrait).to.be.a("string").and.not.empty;
-          expect(employee.thumbnail).to.be.a("string").and.not.empty;
-          expect(employee.email).to.be.a("string").and.not.empty;
-          expect(employee.address.street).to.be.a("string").and.not.empty;
-          expect(employee.address.city).to.be.a("string").and.not.empty;
-          expect(employee.address.state).to.be.a("string").and.not.empty;
+          expect(employee.portrait).to.be.a("string").with.length.of.at.least(1);
+          expect(employee.thumbnail).to.be.a("string").with.length.of.at.least(1);
+          expect(employee.email).to.be.a("string").with.length.of.at.least(1);
+          expect(employee.address.street).to.be.a("string").with.length.of.at.least(1);
+          expect(employee.address.city).to.be.a("string").with.length.of.at.least(1);
+          expect(employee.address.state).to.be.a("string").with.length.of.at.least(1);
           expect(employee.address.zip).to.be.a("string").and.match(/^\d{5}$/);
           expect(employee.phones).to.be.an("array").and.have.length.above(0);
           expect(employee.ssn).to.be.a("string").and.match(/^\d{3}-\d{2}-\d{4}$/);
           expect(employee.department).to.be.a("string").and.match(/^Accounting|Sales|Human Resources|Marketing$/);
           expect(employee.roles).to.be.an("array").and.have.length.above(0);
 
           if (isJSON) {
-            expect(employee.dob).to.be.a("string").and.not.empty;
-            expect(employee.hiredOn).to.be.a("string").and.not.empty;
+            expect(employee.dob).to.be.a("string").with.length.of.at.least(1);
+            expect(employee.hiredOn).to.be.a("string").with.length.of.at.least(1);
             if (employee.terminatedOn) {
-              expect(employee.terminatedOn).to.be.a("string").and.not.empty;
+              expect(employee.terminatedOn).to.be.a("string").with.length.of.at.least(1);
             }
           }
           else {
@@ -125,8 +125,8 @@ describe("employees", () => {
               expect(employee.thumbnail).to.satisfy(path.isAbsolute);
             }
 
-            expect(fs.existsSync(employee.portrait)).to.be.true;
-            expect(fs.existsSync(employee.thumbnail)).to.be.true;
+            expect(fs.existsSync(employee.portrait)).to.equal(true);
+            expect(fs.existsSync(employee.thumbnail)).to.equal(true);
           }
           else {
             expect(employee.portrait).to.equal("portraits/" + employee.username + ".jpg");

test/specs/projects.spec.js

@@ -53,9 +53,9 @@ describe("projects", () => {
           expect(project.assigned).to.be.an("array").and.have.length.above(0);
 
           if (isJSON) {
-            expect(project.startedOn).to.be.a("string").and.not.empty;
+            expect(project.startedOn).to.be.a("string").with.length.of.at.least(1);
             if (project.endedOn !== null) {
-              expect(project.endedOn).to.be.a("string").and.not.empty;
+              expect(project.endedOn).to.be.a("string").with.length.of.at.least(1);
             }
           }
           else {
@@ -66,7 +66,7 @@ describe("projects", () => {
           }
 
           project.assigned.forEach((username) => {
-            expect(username).to.be.a("string").and.not.empty;
+            expect(username).to.be.a("string").with.length.of.at.least(1);
           });
         });
       });