Skip to content

Commit 24f60dc

Browse files
committed
re-add warning removed in electron#11013
1 parent 5fa29fc commit 24f60dc

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

lib/common/api/crash-reporter.js

+5-9
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ const {spawn} = require('child_process')
44
const os = require('os')
55
const path = require('path')
66
const electron = require('electron')
7-
const {app} = process.type === 'browser' ? electron : electron.remote
7+
const {app, deprecate} = process.type === 'browser' ? electron : electron.remote
88
const binding = process.atomBinding('crash_reporter')
99

1010
class CrashReporter {
@@ -106,14 +106,10 @@ class CrashReporter {
106106

107107
// TODO(2.0) Remove
108108
setExtraParameter (key, value) {
109-
// TODO(alexeykuzmin): Warning disabled since it caused
110-
// a couple of Crash Reported tests to time out on Mac. Add it back.
111-
// https://github.com/electron/electron/issues/11012
112-
113-
// if (!process.noDeprecations) {
114-
// deprecate.warn('crashReporter.setExtraParameter',
115-
// 'crashReporter.addExtraParameter or crashReporter.removeExtraParameter')
116-
// }
109+
if (!process.noDeprecations) {
110+
deprecate.warn('crashReporter.setExtraParameter',
111+
'crashReporter.addExtraParameter or crashReporter.removeExtraParameter')
112+
}
117113
binding.setExtraParameter(key, value)
118114
}
119115

0 commit comments

Comments
 (0)