Skip to content

Commit cd76ab8

Browse files
authored
Merge pull request #87 from JuliaAlgebra/explicit-imports
Explicit extend LinearAlgebra functions
2 parents 505d546 + 94e28a6 commit cd76ab8

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

src/MultivariatePolynomials.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ module MultivariatePolynomials
55
#using DocStringExtensions
66

77
using Compat
8-
import Compat.LinearAlgebra: dot, norm, det
8+
import Compat.LinearAlgebra
99

1010
# The ' operator lowers to `transpose()` in v0.6 and to
1111
# `adjoint()` in v0.7+.

src/det.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
function det(M::Matrix{<:AbstractPolynomialLike})
1+
function Compat.LinearAlgebra.det(M::Matrix{<:AbstractPolynomialLike})
22
m = size(M)[1]
33
if m > 2
44
return sum((-1)^(i-1) * M[i,1] * det(M[1:end .!= i, 2:end]) for i in 1:m)

src/operators.jl

+3-3
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,9 @@ adjoint_operator(m::AbstractMonomial) = m
104104
adjoint_operator(t::T) where {T <: AbstractTerm} = adjoint_operator(coefficient(t)) * monomial(t)
105105
adjoint_operator(p::AbstractPolynomialLike) = polynomial(map(adjoint_operator, terms(p)))
106106

107-
Base.dot(p1::AbstractPolynomialLike, p2::AbstractPolynomialLike) = p1' * p2
108-
Base.dot(x, p::AbstractPolynomialLike) = x' * p
109-
Base.dot(p::AbstractPolynomialLike, x) = p' * x
107+
Compat.LinearAlgebra.dot(p1::AbstractPolynomialLike, p2::AbstractPolynomialLike) = p1' * p2
108+
Compat.LinearAlgebra.dot(x, p::AbstractPolynomialLike) = x' * p
109+
Compat.LinearAlgebra.dot(p::AbstractPolynomialLike, x) = p' * x
110110

111111
# Amazingly, this works! Thanks, StaticArrays.jl!
112112
"""

src/polynomial.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ export mindegree, maxdegree, extdegree
44
export leadingterm, leadingcoefficient, leadingmonomial
55
export removeleadingterm, removemonomials, monic
66

7-
norm(p::AbstractPolynomialLike, r::Int=2) = norm(coefficients(p), r)
7+
Compat.LinearAlgebra.norm(p::AbstractPolynomialLike, r::Int=2) = norm(coefficients(p), r)
88

99
changecoefficienttype(::Type{TT}, ::Type{T}) where {TT<:AbstractTermLike, T} = termtype(TT, T)
1010
changecoefficienttype(::Type{PT}, ::Type{T}) where {PT<:AbstractPolynomial, T} = polynomialtype(PT, T)

0 commit comments

Comments
 (0)